[GitHub] cloudstack pull request: CLOUDSTACK-8658: make initializer static ...

2015-07-21 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/612#issuecomment-123579225 Keys are being created: [root@kvm1 ~]# ls -lart ~/.ssh/ total 16 dr-xr-x---. 3 root root 4096 Jul 22 02:37 .. drwx--. 2 root root 4096

[GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...

2015-07-21 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/609#discussion_r35184816 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java --- @@ -57,17 +57,22 @@ private LdapContextFacto

[GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...

2015-07-21 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/609#discussion_r35184810 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java --- @@ -43,14 +45,14 @@ private ConfigurationD

Re: [PROPOSAL] drop old upgrade code

2015-07-21 Thread Wido den Hollander
On 07/21/2015 06:01 PM, Somesh Naidu wrote: > +1 > > Reasons: > 1. Technically speaking, Apache Cloudstack never had version less than 4.0. > But even if they are considered they would be EOL'd at some point. > 2. At some point the feature set disparity between version will make it > really co

[GitHub] cloudstack pull request: CLOUDSTACK-8658: make initializer static ...

2015-07-21 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/612#issuecomment-123571169 Will test it against KVM + Agent. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

Re: Review Request for PR 609

2015-07-21 Thread Daan Hoogland
Lot of work Rajani, I don't understand the spec files in groovy, yet. How can I verify these are run? On Wed, Jul 22, 2015 at 6:39 AM, Rajani Karuturi wrote: > Can someone please review PR 609? Its an enhancement to LDAP import users > functionality > > https://github.com/apache/cloudstack/pull/6

[GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...

2015-07-21 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/609#discussion_r35181833 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java --- @@ -57,17 +57,22 @@ private LdapContextF

[GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...

2015-07-21 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/609#discussion_r35181750 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java --- @@ -43,14 +45,14 @@ private Configurat

[GitHub] cloudstack pull request: BUG-ID: CLOUDSTACK-8483 - Private templat...

2015-07-21 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/334#issuecomment-123562895 @sudhansu7 can you please rebase the changes for master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

Review Request for PR 609

2015-07-21 Thread Rajani Karuturi
Can someone please review PR 609? Its an enhancement to LDAP import users functionality https://github.com/apache/cloudstack/pull/609 Thanks, ~Rajani

[GitHub] cloudstack pull request: CLOUDSTACK-8648: Do not configure the Ima...

2015-07-21 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/606#issuecomment-123554934 yes. copy paste error :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cloudstack pull request: CLOUDSTACK-8650: Fix securitygroups ingre...

2015-07-21 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/601#issuecomment-123526526 LGTM, though I've not tested this with a real host --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cloudstack pull request: CLOUDSTACK-8655: [Browser Based Upload Vo...

2015-07-21 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/611#issuecomment-123526321 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: CLOUDSTACK-8658: make initializer static ...

2015-07-21 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/612#issuecomment-123526216 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: CLOUDSTACK-8658: make initializer static ...

2015-07-21 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/612#issuecomment-123471733 Hey @DaanHoogland Just the initialiser stuff and the return of the getPreferredCharset() method. Cheers, Wilder --- If your project i

[GitHub] cloudstack pull request: CLOUDSTACK-8658: make initializer static ...

2015-07-21 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/612#issuecomment-123460301 @wilderrodrigues of course, sure you want to wait for that? And to what extend? we want tests for this initializer but also for the agent and it's functionin

RE: CloudStack UI Plugins section not showing

2015-07-21 Thread Hopkins, Michael
Thanks very much Rohit, The plugins section is now displaying, I believe because I removed plugins.js.gz. I'm using Cloudstack version 4.5.1 Michael From: Rohit Yadav [rohit.ya...@shapeblue.com] Sent: Tuesday, July 21, 2015 12:00 PM To: dev@cloudstack.apache.org Su

[GitHub] cloudstack pull request: CLOUDSTACK-8658: make initializer static ...

2015-07-21 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/612#issuecomment-123387872 Hey @DaanHoogland Could you write a test for that, please? :) Cheers, Wilder --- If your project is set up for it, you can reply to th

RE: [PROPOSAL] drop old upgrade code

2015-07-21 Thread Somesh Naidu
+1 Reasons: 1. Technically speaking, Apache Cloudstack never had version less than 4.0. But even if they are considered they would be EOL'd at some point. 2. At some point the feature set disparity between version will make it really complex to have direct upgrade paths. 3. As Daan mentioned, 2.

RE: [PROPOSAL] drop old upgrade code

2015-07-21 Thread Kishan Kavala
-1 on dropping old upgrade code. I prefer skipping old upgrade paths during coverity scan instead of removing the code altogether. Even with multi-step upgrade, user will be forced to register system templates multiple times (once for every step). Agree with John regarding the need to establi

[GitHub] cloudstack pull request: CLOUDSTACK-8648: Do not configure the Ima...

2015-07-21 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/606#issuecomment-123381112 Shouldn't we then pass "params" to the configure method? That seems to be missing in your example. --- If your project is set up for it, you can reply to this email an

[GitHub] cloudstack pull request: CLOUDSTACK-8658: make initializer static ...

2015-07-21 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/612 CLOUDSTACK-8658: make initializer static instead of default bad bug: ommision of the static keyword on initializer leaves data uninitialized :{ You can merge this pull request into a Git r

[GitHub] cloudstack pull request: CLOUDSTACK-8648: Do not configure the Ima...

2015-07-21 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/606#issuecomment-123278333 while I agree with the code change based on the current implementations of getVirtualSize, should we just pass the storage layer in the params so that any new imple

[GitHub] cloudstack pull request: CLOUDSTACK-7539: coverity regression dead...

2015-07-21 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/610#issuecomment-123272585 @DaanHoogland Thanks for the information. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: CloudStack UI Plugins section not showing

2015-07-21 Thread Rohit Yadav
Define and include your plugin in the top plugins.js file, also remove any .js.gz file. Which CloudStack branch are you working against? Make sure to define correct names and use something like firebug or chrome dev-tools to see if require.js is missing to load any plugin asset (like js, css, im

CloudStack UI Plugins section not showing

2015-07-21 Thread Hopkins, Michael
Hi, I’m trying to write a 3rd party UI plugin for cloudstack for a university project, unfortunately I can’t seem to get the “plugins” section of the UI to display. In usr/share/cloudstack-management/webapps/client/plugins I have two test plugins “testPlugin” and “csMyFirstPlugin” which are fol

[GitHub] cloudstack pull request: CLOUDSTACK-7539: coverity regression dead...

2015-07-21 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/610#issuecomment-123252820 @koushik-das 'dead local storage' is a source analysis term for 'unused variable'. Not severe unless it happens a lot, because of memory consumption. --- If yo

[GitHub] cloudstack pull request: CLOUDSTACK-7539: coverity regression dead...

2015-07-21 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/610#issuecomment-123232196 Changes look good. Not sure what "dead local store" mean. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8655: [Browser Based Upload Vo...

2015-07-21 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/611#issuecomment-123227873 Test browser based incomplete volume upload, followed by SSVM destroy. Volume should go to UploadAbandoned/Error state and get cleaned up. ... === TestName: test

[GitHub] cloudstack pull request: CLOUDSTACK-8655: [Browser Based Upload Vo...

2015-07-21 Thread koushik-das
GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/611 CLOUDSTACK-8655: [Browser Based Upload Volume] Partially uploaded vol… …umes are not getting destroyed as part of storage GC As part of volume sync, that runs during of SSVM star

Re: [DISCUSS][PROPOSAL] CloudStack Upgrade Policy

2015-07-21 Thread Daan Hoogland
John, You wrote this here and on users and I think it is a good proposal. There is one technical catch and I don't think it is worth bothering users@ with: our current db installation scheme starts with a 4.0.0 database and performs all upgrade steps from that point onward. This can be solved in t