[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: project support in...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/508#issuecomment-121849880 Hi @resmo and @bhaisaab I will check with @remibergsma / @DaanHoogland / @snuf if that's something we could get involved in. I'm okay with helping,

[GitHub] cloudstack pull request: CLOUDSTACK-8588 - Remove redundant skip t...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/526#issuecomment-121848960 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

Re: [DISCUSS] PR list length

We should stick to the 2 LGTM. No matter if that a bug fix or a new feature. Currently we have PRs where 1 LGTM was given, but them the second reviewer asked questions and raised concerns which were not answered accordingly. If the 1 LGTM would have been applied, all concernes would have been ig

[GitHub] cloudstack pull request: CLOUDSTACK-8588 - Remove redundant skip t...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/526#issuecomment-121846745 @bhaisaab @DaanHoogland , could you also have a look at this one? It LGTM Cheers, Wilder --- If your project is set up for it, you can

[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: project support in...

Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/508#issuecomment-121846292 hey @bhaisaab, still WIP. I ask for some help to finish it on the ML, because I will not have time to work on it the next months. --- If your project is set up for it

[GitHub] cloudstack pull request: CLOUDSTACK-8608. System VM's failed to st...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/555#issuecomment-121844265 Travis failed due to a timeout. I will have a look at the code. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cloudstack pull request: CLOUDSTACK-8639:fixing calculation mistak...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/595#issuecomment-121843873 I browsed the code and found out that this "templateSize = int(int(templates[0].size) / (1024**3))" was already been used in other places. So, your changes d

[GitHub] cloudstack pull request: CLOUDSTACK-8580: user can view, expunge a...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/593#issuecomment-121843328 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-8632: Unable to revert snapsho...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/590#issuecomment-121843137 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] cloudstack pull request: To Verfiy that list templates by domain a...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/189#issuecomment-121830729 Patch fails, file already exists? Please rebase and push again, or close PR if this is already merged on master in some other PR --- If your project is set up for

[GitHub] cloudstack pull request: CLOUDSTACK-8582: Skipping unsuitable test...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/532 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: To Verfiy that list templates by domain a...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/189#issuecomment-121830270 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: BUG-ID: CLOUDSTACK-8483 - Private templat...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/334#discussion_r34755962 --- Diff: api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java --- @@ -124,6 +127,9 @@ description = "true

[GitHub] cloudstack pull request: CLOUDSTACK-8308:Adding automation testcas...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/384#issuecomment-121829822 Ping, any updates? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cloudstack pull request: CLOUDSTACK-8582: Skipping unsuitable test...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/532#issuecomment-121829768 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: CLOUDSTACK-8556: Unable to delete attache...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/481#issuecomment-121829664 LGTM, squashing and merging; please squash your changes in future as you iterate on your PR --- If your project is set up for it, you can reply to this email and h

[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: project support in...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/508#issuecomment-121829695 ping, any update on this? still WIP? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8556: Unable to delete attache...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/481 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8549:Update test_concurrent_sn...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/386 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8549:Update test_concurrent_sn...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/386#issuecomment-121829533 LGTM, really old so merging now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-7539: [S3] Parallel deployment...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/572#issuecomment-121829053 While LGTM and travis seems to be happy about it, my java kung - {locks and synchroization} -fu skills are not to be trusted --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/577#discussion_r34755687 --- Diff: packaging/centos63/cloud.spec --- @@ -129,6 +129,8 @@ Requires: perl Requires: libvirt-python Requires: qemu-img Requires: qemu-k

[GitHub] cloudstack pull request: CLOUDSTACK-8626 :[Automation]fixing test/...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/579#issuecomment-121828476 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: CLOUDSTACK-8626 :[Automation]fixing test/...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/579 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8628: kvm: Disable Fencing whe...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/580#discussion_r34755639 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtFenceCommandWrapper.java --- @@ -48,6 +48,18 @@ public Answer exe

[GitHub] cloudstack pull request: CLOUDSTACK-8581: S3, make connection TTL ...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/582#discussion_r34755599 --- Diff: api/src/com/cloud/agent/api/to/S3TO.java --- @@ -118,6 +122,14 @@ public boolean equals(final Object thatObject) { return false

[GitHub] cloudstack pull request: CLOUDSTACK-8616: Redundant VPC with both ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/587#issuecomment-121827701 LGTM, though did not test it due to lack of time and test infrastructure. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack pull request: CLOUDSTACK-8616: Redundant VPC with both ...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/587#discussion_r34755507 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsFile.py --- @@ -35,10 +35,9 @@ def load(self): self.new_config.append(lin

[GitHub] cloudstack pull request: CLOUDSTACK-8580

Github user borisroman closed the pull request at: https://github.com/apache/cloudstack/pull/589 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...

Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-121645521 /var/lib/libvirt/images is used for local storage also. com.cloud.hypervisor.kvm.resource.LibvirtComputingResource#configure _localStoragePath = (

Re: Error code 401 listdomains failed - Test of host allocator failing

Amy, The error message denotes that API signature generated by the client seems to be wrong or not what cloudstack is expecting. Follow the below link, so, basically check out the latest code from the branch you are running this with, seems you are using 4.5.2. Once you are done getting simulato

Build failed in Jenkins: build-4.5 #499

See Changes: [Rohit Yadav] CLOUDSTACK-8457: SAML UI Dialog fixes to use local $form -- [...truncated 2974 lines...] [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 2 resour

[GitHub] cloudstack pull request: CLOUDSTACK-8457: SAML UI Dialog fixes to ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/583 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8639:fixing calculation mistak...

GitHub user nitt10prashant opened a pull request: https://github.com/apache/cloudstack/pull/595 CLOUDSTACK-8639:fixing calculation mistakes in component/test_ss_doma… test result = Test secondary storage limit of domain and its sub-domains ... === TestName: test_04

[GitHub] cloudstack pull request: CLOUDSTACK-8635: Depend on the headless J...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/588#issuecomment-121607193 @bhaisaab We could, since users who would upgrade to 4.5.2 coming from 4.4.X wouldn't need to install all those packages. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-8457: SAML UI Dialog fixes to ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/583#issuecomment-121606896 LGTM from Abhi (on chat); test setup on http://acs.bhaisaab.org:8080/client/ --- If your project is set up for it, you can reply to this email and have your reply a

Error code 401 listdomains failed - Test of host allocator failing

Hi, I'm trying to run a test based on this guide: http://www.chipchilders.com/blog/2013/7/22/visualizing-the-cloudstack-planners-in-action.html the test code: https://gist.github.com/chipchilders/6056220#file-test_deploy_lots_of_vms_with_firstfitplanner-py I've done some minor changes to make it ru

[GitHub] cloudstack pull request: Improved message for peeples to actually ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/576 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8581: S3, make connection TTL ...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/582#discussion_r34674108 --- Diff: api/src/com/cloud/agent/api/to/S3TO.java --- @@ -118,6 +122,14 @@ public boolean equals(final Object thatObject) { return false

[GitHub] cloudstack pull request: CLOUDSTACK-8635: Depend on the headless J...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/588 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8635: Depend on the headless J...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/588#issuecomment-121603953 checked both debian packages and ubuntu ones, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cloudstack pull request: CLOUDSTACK-8635: Depend on the headless J...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/588#issuecomment-121603988 @wido do we need to port them on 4.5 branch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8633: Changing file permission...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/591 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8633: Changing file permission...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/591#issuecomment-121603506 Added same logic for fedora20/21 spec files as well. Merged on master now. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cloudstack pull request: CLOUDSTACK-8633: Changing file permission...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/591#issuecomment-121602657 LGTM, good catch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-8636: Verify failure of creati...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/592 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8636: Verify failure of creati...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/592#issuecomment-121602562 squashed/merged your commits; in future please try to squash them as you iterate with your reviews --- If your project is set up for it, you can reply to this emai

[GitHub] cloudstack pull request: CLOUDSTACK-8637: Verify that VM with same...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/594 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8636: Verify failure of creati...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/592#issuecomment-121602397 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: CLOUDSTACK-8637: Verify that VM with same...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/594#issuecomment-121601522 looks like this is for vmware only no way for me to verify, but good looks okay. LGTM, merging now --- If your project is set up for it, you can reply to th

[GitHub] cloudstack pull request: CLOUDSTACK-8580: user can view, expunge a...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/593#issuecomment-121600559 Added description to title. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

Re: [DISCUSS] Moving to Java 8

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 15-07-15 09:20, Wilder Rodrigues wrote: > If there would be dependencies on some other things, that in no way > could be fixed now, we could wait for 4.7 (5.0). However, if we > could give it a go, I would be able to tackle this in our next > Spri

[GitHub] cloudstack pull request: CLOUDSTACK-8580

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/593#issuecomment-121585809 Can you add the description of the functionality is short to the pr title? for instance 'CLOUDSTACK-8580: user access to deleted VMs' --- If your proje

RE: [GitHub] cloudstack pull request: CLOUDSTACK-8633: Changing file permission...

awesome! agree on the context... thanks! -Original Message- From: wilderrodrigues [mailto:g...@git.apache.org] Sent: Wednesday, July 15, 2015 4:18 PM To: dev@cloudstack.apache.org Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8633: Changing file permission... Github user wilderr

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8633: Changing file permission...

I was trying to bring up MS with xencluster. On Wed, Jul 15, 2015 at 4:10 PM, pvr9712 wrote: > Github user pvr9712 commented on the pull request: > > https://github.com/apache/cloudstack/pull/591#issuecomment-121571026 > > BTW, here is my email on the Dev list with the details for this i

[GitHub] cloudstack pull request: CLOUDSTACK-8633: Changing file permission...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/591#issuecomment-121573911 Hi @pvr9712 Thanks for the commit IDs, a bit of context always help. It would have saved us some time if the PR would have the commit ID whi

[GitHub] cloudstack pull request: CLOUDSTACK-8633: Changing file permission...

Github user pvr9712 commented on the pull request: https://github.com/apache/cloudstack/pull/591#issuecomment-121571026 BTW, here is my email on the Dev list with the details for this issues - including the earlier commit - Using Master builds, MS logs shows following error - "ma

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8637: Verify that VM with same...

LGTM On Wed, Jul 15, 2015 at 3:29 PM, pritisarap12 wrote: > GitHub user pritisarap12 opened a pull request: > > https://github.com/apache/cloudstack/pull/594 > > CLOUDSTACK-8637: Verify that VM with same Display name creation fails > if vm.instancename.flag=true > > When vm.instancen

[GitHub] cloudstack pull request: CLOUDSTACK-8633: Changing file permission...

Github user pvr9712 commented on the pull request: https://github.com/apache/cloudstack/pull/591#issuecomment-121566177 @wilderrodrigues if you look at the earlier commit, the code was refactored and I feel it is a miss. If this worked for someone, will be interested to know. b

[GitHub] cloudstack pull request: CLOUDSTACK-8633: Changing file permission...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/591#issuecomment-121563084 @pvr9712 the question here is not if it works or not, because it's quite clear that once the permission changes it will suffice @sanju1010's need. The point

[GitHub] cloudstack pull request: CLOUDSTACK-8637: Verify that VM with same...

GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/594 CLOUDSTACK-8637: Verify that VM with same Display name creation fails if vm.instancename.flag=true When vm.instancename.flag=true it will only set the "instancename" without any additional

[GitHub] cloudstack pull request: CLOUDSTACK-8633: Changing file permission...

Github user pvr9712 commented on the pull request: https://github.com/apache/cloudstack/pull/591#issuecomment-121559068 I have tested this changes and it works. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

Re: file /var/log/cloudstack/agent from install of cloudstack-agent-4.5.1-1.el7.centos.x86_64 conflicts with file from package cloudstack-management-4.5.1-1.el7.centos.x86_64

Hi, I totally agree with Wido, This should be fixed in the ACS repo for every one to use, Instead of sharing this using non ACS private builds. Thanks, Bharat. On 15-Jul-2015, at 2:41 pm, Rohit Yadav mailto:rohit.ya...@shapeblue.com>> wrote: On 14-Jul-2015, at 9:23 pm, Wido den Hollander ma

Re: file /var/log/cloudstack/agent from install of cloudstack-agent-4.5.1-1.el7.centos.x86_64 conflicts with file from package cloudstack-management-4.5.1-1.el7.centos.x86_64

On 14-Jul-2015, at 9:23 pm, Wido den Hollander mailto:w...@widodh.nl>> wrote: Although that will help the end-user, we shouldn't want that. This should be fixed in the ACS source releases as well rather then in packages. It seems to be fixed in the 4.5 branch, but 4.5.2 hasn't been released whi

[GitHub] cloudstack pull request: CLOUDSTACK-8580

GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/593 CLOUDSTACK-8580 Users are now able to view, expunge and recover their vm's themselves. Two configuration options are added to allow this behaviour on a global or per account scale. Configura

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8636: Verify failure of creati...

LGTM On Wed, Jul 15, 2015 at 2:04 PM, pritisarap12 wrote: > Github user pritisarap12 commented on a diff in the pull request: > > https://github.com/apache/cloudstack/pull/592#discussion_r34656988 > > --- Diff: test/integration/testpaths/testpath_custom_disk_offering.py > --- > @@ -0

[GitHub] cloudstack pull request: CLOUDSTACK-8632: Unable to revert snapsho...

Github user pritisarap12 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/590#discussion_r34657738 --- Diff: test/integration/testpaths/testpath_revert_snap.py --- @@ -0,0 +1,159 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-8636: Verify failure of creati...

Github user pritisarap12 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/592#discussion_r34656988 --- Diff: test/integration/testpaths/testpath_custom_disk_offering.py --- @@ -0,0 +1,84 @@ +# Licensed to the Apache Software Foundation (ASF) und

[GitHub] cloudstack pull request: Findbugs issues with instance acces to st...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/573#issuecomment-121528428 @bhaisaab this PR didn't auto close. You think your ref from shapeblue/cloudstack to here might have anything to do with it? --- If your project is set up for

[GitHub] cloudstack pull request: Findbugs issues with instance acces to st...

Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/573 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cloudstack pull request: Coverity resource leaks

Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/578 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cloudstack pull request: Coverity regressions

Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/584 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition to...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/585 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition to...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/585#issuecomment-121522610 thanks LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

Re: [DISCUSS] Moving to Java 8

If there would be dependencies on some other things, that in no way could be fixed now, we could wait for 4.7 (5.0). However, if we could give it a go, I would be able to tackle this in our next Sprint (within 1 1/2 week from now) and still get it into 4.6. What would be the main considerations

Re: Git Rebase Question

A directory rename? If you create a patch file of your branch and apply it on HEAD, does that work? On Wed, Jul 15, 2015 at 3:03 AM, Mike Tutkowski wrote: > Hi everyone, > > I have a Git question that relates to a rebase problem I've been seeing. > > I have a branch I've been working on the past

[GitHub] cloudstack pull request: CLOUDSTACK-8633: Changing file permission...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/591#issuecomment-121512748 @wilderrodrigues currently I am on holiday and not able to look into stuff. As far as I know sudo was implemented for KVM agent only. See ya in about 1

[GitHub] cloudstack pull request: CLOUDSTACK-8628: kvm: Disable Fencing whe...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/580#issuecomment-121512071 Hi @wido Could you please add an extra test to cover the "pools.size() == 0)"? Cheers, Wilder --- If your project is set up for it, yo

[GitHub] cloudstack pull request: CLOUDSTACK-8636: Verify failure of creati...

Github user sanju1010 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/592#discussion_r34650908 --- Diff: test/integration/testpaths/testpath_custom_disk_offering.py --- @@ -0,0 +1,84 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: CLOUDSTACK-8636: Verify failure of creati...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/592#issuecomment-121511374 This description looks better, @pritisarap12 . I think you meant something like that for your previous PR. I will wait for the build/travis and vote

[GitHub] cloudstack pull request: CLOUDSTACK-8633: Changing file permission...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/591#issuecomment-121511254 @bhaisaab @DaanHoogland @remibergsma could you have a look at this? Wasn't ACS management-server supposed to be executed as SUDO? If I'm right, there

[GitHub] cloudstack pull request: CLOUDSTACK-8632: Unable to revert snapsho...

Github user sanju1010 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/590#discussion_r34650668 --- Diff: test/integration/testpaths/testpath_revert_snap.py --- @@ -0,0 +1,159 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-8632: Unable to revert snapsho...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/590#issuecomment-121510634 Hi @pritisarap12 The issue/PR title says "Unable to rever snapshot on XenServer", however you have created a component test to "check that volume sn

[GitHub] cloudstack pull request: CLOUDSTACK-8636: Verify failure of creati...

GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/592 CLOUDSTACK-8636: Verify failure of creation of Custom disk offering with disksize parameter Custom disk creation should not take disksize parameter while creating the disk offering You ca