Re: [ACS45]reverting commits or branching?

2014-10-11 Thread Mike Tutkowski
I think Animesh is just stating that there is a use case for developers to only fix a bug that's in the master branch. For example, a feature that's been introduced in master that someone logged a ticket for would only have a fix put in in master. If the bug is in 4.4.1 and a fix goes in, it shoul

Re: [ACS45]reverting commits or branching?

2014-10-11 Thread Daan Hoogland
I am stating that any bugfix should fix the bug that is out there first and hence go into the release branch first and in master second! To reassert my last statement; it is very correct! The attention that has gone into bugfixing in master should not have gone there. It should have gone into rele

Re: [ACS45]reverting commits or branching?

2014-10-11 Thread Animesh Chaturvedi
I am not saying that. I am saying bug fixes should remain. Your last statement is not correct every bug fix should always go in master not just release branches. Sent from my iPhone On Oct 11, 2014, at 3:58 AM, "Daan Hoogland" mailto:daan.hoogl...@gmail.com>> wrote: I think we need to revert

Re: [ACS45]reverting commits or branching?

2014-10-11 Thread Daan Hoogland
I think we need to revert a lot, Animesh. I don't think you can say that all the commits since the 1st amount to bugfixes. At least they are not commented as such. And if so, they should have gone into 4.4, not master. On Fri, Oct 10, 2014 at 8:19 PM, Animesh Chaturvedi < animesh.chaturv...@citrix