Re: Review Request 24238: Fix mvn marvin.sync profile

> On Aug. 4, 2014, 4:35 p.m., Santhosh Edukulla wrote: > > tools/marvin/setup.py, line 35 > > > > > > Please tying like this to as a dependency on pom.xml, may unnecessarily > > lead to tight coupling with mvn logic in

Re: Review Request 24544: CLOUDSTACK-7294: Passing listall =True for listUsers api admin call

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24544/#review50421 --- Commit 9d7b85153747dfe378031455fc1231bcd6088d08 in cloudstack's bran

Re: Review Request 24599: CLOUDSTACK-7284: Fixed test script related to expunge VM in test_add_remove_network.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24599/#review50417 --- Commit 76cecc325fca5ead8b610c49608cb8fe8a4395c5 in cloudstack's bran

Jenkins build is still unstable: simulator-singlerun #107

See

Re: Review Request 24603: CLOUDSTACK-7321: Resolved cleanup issue in test_network.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24603/#review50402 --- Commit f9a66655e353fa3ff25d4231cf6cd60f7e9500e6 in cloudstack's bran

Re: Should we remove all the -forward branches?

On Tue, Aug 12, 2014 at 6:04 PM, Rohit Yadav wrote: > I remember we agreed to not use the -forward branches, so can we get rid of > them please? > > I was reviewing someone’s patch and they had targeted that for 4.3.0-forward, > though this branch is far behind than 4.3 branch; so does not make

Re: [SHOW] Authentication refactoring

On Tue, Aug 12, 2014 at 5:35 PM, Rohit Yadav wrote: > Hi Min, > > For for master, we don’t have any code freeze currently, I think merge > request/reviews are not mandatory and I was confident with the changes so I > pushed it on master. > This is an incorrect understanding of our community nor

Jenkins build is still unstable: simulator-singlerun #106

See

Jenkins build is still unstable: simulator-singlerun #105

See

Re: [SHOW] Authentication refactoring

Hi Silvano, in-line; On 12-Aug-2014, at 11:50 pm, Silvano Nogueira Buback wrote: > Rohit, > >When I started implementing OAuth2 integration I faced this problem, > but I had other things to do first, now I am back to this problem too. I > took a look at your implementation and it's almost

Jenkins build is still unstable: simulator-singlerun #104

See

Re: Review Request 24090: Externalized the hard-coded strings from JavaScript files to resource bundles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24090/ --- (Updated Aug. 12, 2014, 10:11 p.m.) Review request for cloudstack, Brian Federl

Re: Review Request 24571: Bugfix CS-7309: Null pointer in usage records listing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24571/#review50378 --- Thanks! Merged on 4.3, 4.4 (helping Daan here since it was a bugfix)

Should we remove all the -forward branches?

I remember we agreed to not use the -forward branches, so can we get rid of them please? I was reviewing someone’s patch and they had targeted that for 4.3.0-forward, though this branch is far behind than 4.3 branch; so does not make sense to merge their work on the forward branch. I’m going ah

Re: Review Request 24571: Bugfix CS-7309: Null pointer in usage records listing

> On Aug. 12, 2014, 9:56 p.m., Rohit Yadav wrote: > > Ship It! This needs to be picked on 4.3, 4.4 and master? Or already merged on these branches? - Rohit --- This is an automatically generated e-mail. To reply, visit: https://reviews

Re: Review Request 24571: Bugfix CS-7309: Null pointer in usage records listing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24571/#review50375 --- Ship it! Ship It! - Rohit Yadav On Aug. 12, 2014, 4:32 p.m., Lui

Re: Review Request 24238: Fix mvn marvin.sync profile

> On Aug. 4, 2014, 4:35 p.m., Santhosh Edukulla wrote: > > tools/marvin/setup.py, line 35 > > > > > > Please tying like this to as a dependency on pom.xml, may unnecessarily > > lead to tight coupling with mvn logic in

Re: Review Request 24611: New DNS provider (GloboDNS)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24611/#review50372 --- Hi Daniel, Thank you for your work, it looks comprehensive. Appreci

Re: [SHOW] Authentication refactoring

Rohit, When I started implementing OAuth2 integration I faced this problem, but I had other things to do first, now I am back to this problem too. I took a look at your implementation and it's almost fit for OAuth2. I have a few comments: Some authentication mechanisms may not work as a comma

Re: Review Request 24611: New DNS provider (GloboDNS)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24611/ --- (Updated Aug. 12, 2014, 9:43 p.m.) Review request for cloudstack, Chiradeep Vit

Re: [DISCUSS] Removing template URL format checking logic

Completely remove the checkFormat() will cause trouble for debugging issues later if the template format is wrong. I would prefer fail fast approach instead of spending hours later to deal with wrong file format issues. Thanks -min On 8/12/14 2:37 PM, "Rohit Yadav" wrote: >Hey, > >On 12-Aug-201

Re: [DISCUSS] Removing template URL format checking logic

Hey, On 12-Aug-2014, at 8:53 pm, Min Chen wrote: > A better fix to address this issue has been committed to master: > https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=e356465 > 8befaa72cbe5fd510bea2a25b40f108f5. This should address CLOUDSTACK-6940, > CLOUDSTACK-7312, CLOUDSTAC

Re: [SHOW] Authentication refactoring

Hi Min, For for master, we don’t have any code freeze currently, I think merge request/reviews are not mandatory and I was confident with the changes so I pushed it on master. After Daan’s email I did testing at my end (I’ve bunch of zotac zboxes to do the local testing, it was already failing

Jenkins build is still unstable: simulator-singlerun #103

See

Re: [SHOW] Authentication refactoring

Hi Rohit, My understanding is that you will do this on your feature branch "auth-refactor", then merge them after passing at least some CI automation tests. Today, I saw all these commits already in master: 10 hours agoRohit Yadav DefaultLoginAPIAuthenticatorCmd: return userId as U

Re: Regarding Shrinking of Volume

Yes, this is true. Ideally other storage maintainers/drivers would implement it as well, but we only committed a test for shrinking clvm (over a year ago now). I'd like to keep the test itself to run regression against clvm, but since this test is being used now for some continuous integration or o

Jenkins build is still unstable: simulator-singlerun #102

See

Regarding Shrinking of Volume

Hello Marcus, I see that shrinking of volume is not supported by XenServer (CLOUDSTACK-7228) . May I know whether KVM with CLVM Data Volumes is the only configuration that supports shrinking of data volume? If Yes, May I know if the corresponding test case that shrinks data disks be removed fro

Re: Review Request 24615: Fix CLOUDSTACK-7228: Shrinking Data Volume is not supported on many Configurations. Removing it from test_volumes.py test suite

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24615/ --- (Updated Aug. 12, 2014, 7:13 p.m.) Review request for cloudstack, Amogh Vasekar

Re: Review Request 24615: Fix CLOUDSTACK-7228: Shrinking Data Volume is not supported on many Configurations. Removing it from test_volumes.py test suite

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24615/ --- (Updated Aug. 12, 2014, 7:12 p.m.) Review request for cloudstack, Doug Clark, M

Review Request 24615: Fix CLOUDSTACK-7228: Shrinking Data Volume is not supported on many Configurations. Removing it from test_volumes.py test suite

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24615/ --- Review request for cloudstack, Doug Clark, Min Chen, Nitin Mehta, Raja Pullela,

Re: [DISCUSS] [PROPOSAL] Implementation of DNS Provider for Bind (for 4.5)

No change in the last two weeks, just sent code for review. https://reviews.apache.org/r/24611/ Regards, -- Daniel Simões Time Evolução Infra - Globo.com E-mail: daniel.sim...@corp.globo.com Tel.: +55 21 2483-6977 2014-07-30 11:04 GMT-03:00 Daniel Vega Simões : > Hi guys, > > Since nobody w

Review Request 24611: New DNS provider (GloboDNS)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24611/ --- Review request for cloudstack. Bugs: CLOUDSTACK-6998 https://issues.apache.

Re: [DISCUSS] Removing template URL format checking logic

A better fix to address this issue has been committed to master: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=e356465 8befaa72cbe5fd510bea2a25b40f108f5. This should address CLOUDSTACK-6940, CLOUDSTACK-7312, CLOUDSTACK-5512 altogether, same logic to handle registerTemplate, re

Jenkins build is still unstable: simulator-singlerun #101

See

Re: Review Request 24542: CLOUDSTACK-7302: UI: Removed Hover Interaction from breadcrumbs at top page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24542/#review50351 --- Commit af377430453ecf1fb9b44ed3e29541b7f20ce5d5 in cloudstack's bran

Re: Review Request 24542: CLOUDSTACK-7302: UI: Removed Hover Interaction from breadcrumbs at top page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24542/#review50350 --- Ship it! Ship It! - Brian Federle On Aug. 11, 2014, 8:06 a.m., M

Re: [GSoC] Fwd: Wrap-Up phase and final evaluations

Hi > It would be great to see a slide deck that summarizes your work this summer or some nice wrap-up/blog post about your experience. I don't currently have an active blog so I've pasted it into a gist: https://gist.github.com/imduffy15/5c4ac89c2ddb06e4eb60 On 12 August 2014 17:06, Mike Tut

Jenkins build is back to normal : build-master-simulator #189

See

Build failed in Jenkins: build-master-simulator #188

See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on cloudstack-buildslave-centos6-17c (cloudstack-buildslave-centos6) in workspace

Re: Review Request 24090: Externalized the hard-coded strings from JavaScript files to resource bundles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24090/#review50338 --- Please see my comments on dictionary.jsp: ui/dictionary.jsp

Re: Review Request 24571: Bugfix CS-7309: Null pointer in usage records listing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24571/ --- (Updated Aug. 12, 2014, 4:32 p.m.) Review request for cloudstack. Changes ---

Re: [GSoC] Fwd: Wrap-Up phase and final evaluations

Thanks, Sebastien I am currently in the process of reviewing the final bit of Seif's work. He'll be opening another Review Board request for this and then I'll check the code in. On Tue, Aug 12, 2014 at 1:59 AM, Sebastien Goasguen wrote: > Darren, Ian, Seif, > > See the message below. Final ev

Re: Registering an ISO

Hi, Have you ran through the steps at https://cwiki.apache.org/confluence/display/CLOUDSTACK/SSVM,+templates,+Secondary+storage+troubleshooting It sounds like it may be related to secstorage.allowed.internal.sites Thanks, Ian On 12 August 2014 16:36, Elapavuluri, Jaya wrote: > Hello, > > > >

Registering an ISO

Hello, I am trying to setup a development environment on my local server where cloudstack is running on Ubuntu installed on vmware workstation. While I perform register an iso under the template-> iso section of cloudstack. I have given proper url link for the ISO. However, when I click on

Re: [SHOW] Authentication refactoring

> On Aug 12, 2014, at 5:12 AM, Adrian Lewis wrote: > > Hi Rohit, > > Not a very constructive email I'm afraid but I too would be very > interested in one-time password authentication for CS. Is anyone that you > know of working on RADIUS auth as this would be a relatively easy way to > integra

Re: Review Request 24557: CLOUDSTACK-7308 - Adds tagging support for security group rules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24557/ --- (Updated Aug. 12, 2014, 2:39 p.m.) Review request for cloudstack, daan Hoogland

Re: Review Request 24557: CLOUDSTACK-7308 - Adds tagging support for security group rules

> On Aug. 12, 2014, 1:19 p.m., daan Hoogland wrote: > > seems resonable, but why is this for 4.4? In it self it does not provide > > any functionality. Let's put it in master, alright? I've changed it to master branch :) - Stephen ---

Re: Review Request 24557: CLOUDSTACK-7308 - Adds tagging support for security group rules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24557/#review50324 --- Ship it! Ship It! - Ilia Shakitko On Aug. 12, 2014, 7:27 a.m., S

Review Request 24605: CLOUDSTACK-7322 Tag disruptive tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24605/ --- Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-7322

Re: Review Request 24599: CLOUDSTACK-7284: Fixed test script related to expunge VM in test_add_remove_network.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24599/#review50322 --- Commit 97ecd5575c4b408ecb4e08a1b81933bb703b324a in cloudstack's bran

Re: Review Request 24599: CLOUDSTACK-7284: Fixed test script related to expunge VM in test_add_remove_network.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24599/#review50320 --- Commit 045a290cec2dbdf9b284934a4cd92836c227d513 in cloudstack's bran

Re: Review Request 24599: CLOUDSTACK-7284: Fixed test script related to expunge VM in test_add_remove_network.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24599/#review50321 --- Commit 07abf7d7c1cd4953bea0322f21aeb8379fc49e14 in cloudstack's bran

Re: Review Request 21696: CLOUDSTACK-6716: /usr volume is to small on SVMs. Reshuffling some space to fix that.

> On Aug. 8, 2014, 10:59 a.m., daan Hoogland wrote: > > b8deb6ba3f72d7da1944c47ee60db3ff4127da6c on master > > Rohit Yadav wrote: > We'll keep an eye on the systemvm build and test the systemvms (I'll do > for KVM, do I hear anyone else for XEN?) and if does not work revert; else we > can

Re: Review Request 24557: CLOUDSTACK-7308 - Adds tagging support for security group rules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24557/#review50318 --- seems resonable, but why is this for 4.4? In it self it does not pro

Review Request 24603: CLOUDSTACK-7321: Resolved cleanup issue in test_network.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24603/ --- Review request for cloudstack, Doug Clark and Santhosh Edukulla. Bugs: CLOUDSTA

Re: [SHOW] Authentication refactoring

Hi Adrian, On 12-Aug-2014, at 2:12 pm, Adrian Lewis wrote: > Hi Rohit, > > Not a very constructive email I'm afraid but I too would be very > interested in one-time password authentication for CS. Is anyone that you > know of working on RADIUS auth as this would be a relatively easy way to Not

Build failed in Jenkins: simulator-hotfix-trigger #19

See -- [...truncated 7104 lines...] main: [INFO] Executed tasks [INFO] [INFO] >>> exec-maven-plugin:1.2.1:java (create-schema-simulator) @ cloud-developer >>> [INFO] [INFO] --- maven-check

Re: Review Request 24547: CLOUDSTACK-7304: Fixed Exception not raised issue in portable IP test cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24547/#review50312 --- Commit d3f75618e7aeca5586d494c217ad5b6d3dcfd3c2 in cloudstack's bran

Re: Review Request 24547: CLOUDSTACK-7304: Fixed Exception not raised issue in portable IP test cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24547/#review50311 --- Ship it! Ship It! - Santhosh Edukulla On Aug. 11, 2014, 12:14 p.

RE: [SHOW] Authentication refactoring

Hi Rohit, Not a very constructive email I'm afraid but I too would be very interested in one-time password authentication for CS. Is anyone that you know of working on RADIUS auth as this would be a relatively easy way to integrate a wide number of OTP systems that rely on a secondary auth challen

Review Request 24600: Test script to verify if there is an error in editing network without network domain specified

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24600/ --- Review request for cloudstack and Santhosh Edukulla. Repository: cloudstack-git

Re: Review Request 24571: Bugfix CS-7309: Null pointer in usage records listing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24571/#review50309 --- server/src/com/cloud/api/ApiResponseHelper.java

Re: Review Request 24598: Copy Snapshot command too heavy on XenServer Dom0 resources when using dd top copy incremental snapshots

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24598/ --- (Updated Aug. 12, 2014, 11:21 a.m.) Review request for cloudstack, Alex Huang,

Re: Review Request 23982: CLOUDSTACK-7192: Skip tests on Hyper-V which don't apply

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23982/#review50307 --- Ship it! Ship It! - sanjeev n On Aug. 6, 2014, 2:41 p.m., John D

Re: Review Request 23982: CLOUDSTACK-7192: Skip tests on Hyper-V which don't apply

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23982/#review50306 --- Commit d75961d973021fbfec5058d907923f885ac8906a in cloudstack's bran

Re: Review Request 24598: Copy Snapshot command too heavy on XenServer Dom0 resources when using dd top copy incremental snapshots

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24598/#review50304 --- Ship it! c4b78c3aaa8df20c8e892b9d5108d8f34f96ed0c on 4.4 - daan Ho

Re: Review Request 23452: CLOUDSTACK-4840: Automation tests - LB for secondary IP

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23452/#review50299 --- test/integration/component/test_lb_secondary_ip.py

Jenkins build is still unstable: simulator-singlerun #100

See

Re: Review Request 24549: CLOUDSTACK-7305: hypervisor type parameter is mandatory when deploying VM using ISO

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24549/#review50302 --- Ship it! Ship It! - Koushik Das On Aug. 12, 2014, 11:03 a.m., Ha

Re: Review Request 24549: CLOUDSTACK-7305: hypervisor type parameter is mandatory when deploying VM using ISO

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24549/#review50301 --- Commit 6568e0bb31103ec9148a5c967db6563ca9af4307 in cloudstack's bran

Review Request 24598: Copy Snapshot command too heavy on XenServer Dom0 resources when using dd top copy incremental snapshots

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24598/ --- Review request for cloudstack, Alex Huang, anthony xu, daan Hoogland, edison su,

Review Request 24599: CLOUDSTACK-7284: Fixed test script related to expunge VM in test_add_remove_network.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24599/ --- Review request for cloudstack, Doug Clark and Santhosh Edukulla. Bugs: CLOUDSTA

Re: Review Request 24549: CLOUDSTACK-7305: hypervisor type parameter is mandatory when deploying VM using ISO

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24549/ --- (Updated Aug. 12, 2014, 11:03 a.m.) Review request for cloudstack and Koushik D

Re: [SHOW] Authentication refactoring

>From the user end there is no change, not in UI or any change expected in >clients except one: Since login and logout are now implemented like your regular api, we don’t allow uses to call login and logout and other such AuthenticatorAPIs directly like via integration port Stephen, I’m not sur

RE: [SHOW] Authentication refactoring

Are there any UI changes? Some auth mechanisms might need more than just username and password (RSA token, for example, or even just "give the 1st, 4th and 5th characters"). -- Stephen Turner -Original Message- From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com] Sent: 12 August 2014

Re: Review Request 23452: CLOUDSTACK-4840: Automation tests - LB for secondary IP

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23452/ --- (Updated Aug. 12, 2014, 10:05 a.m.) Review request for cloudstack, suresh sadhu

Jenkins build is still unstable: simulator-singlerun #99

See

Re: [SHOW] Authentication refactoring

On 12-Aug-2014, at 11:32 am, Daan Hoogland wrote: > looks alright at first glance. did you considder IAM/is it going to > give conflicts there? I don't suppose so as this work is more of a > front end thing and IAM should be more based in the background but > keep it in mind anyway;) > No reason

Re: [PROPOSAL] Solving the cherry-picking problem

Hi, Just wanted to check if anyone has any feedback on this thread? Something we want to discuss, add, change, adapt and adopt? if we’re all good I’ll start a voting thread tonight for adopting this. Cheers. On 07-Aug-2014, at 10:39 am, Rohit Yadav wrote: > Hi, > > I think the following can s

Re: [SHOW] Authentication refactoring

looks alright at first glance. did you considder IAM/is it going to give conflicts there? I don't suppose so as this work is more of a front end thing and IAM should be more based in the background but keep it in mind anyway;) No reason why you shouldn't merge, except feature freeze.. On Tue, Aug

Re: [SHOW] Authentication refactoring

This was done: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Authentication+Refactoring This is the branch: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/auth-refactor Updates: - Every auth mechanism now implements as a APICommand but these are special

Re: List APIs Behavior

Hi, The list apis is giving different behaviour on integration (default 8096) and authenticated (default 8080) ports. Using cloudmonkey you can try: list users with/out listall=true? Can someone check why we’ve different behaviours? Cheers. On 11-Aug-2014, at 7:53 am, Gaurav Aradhye wrote:

Re: Review Request 24589: Test script to verify fix for CS-5332

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24589/#review50296 --- test/integration/component/test_network_offering.py

Re: Review Request 24589: Test script to verify fix for CS-5332

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24589/#review50295 --- Ship it! Ship It! - Santhosh Edukulla On Aug. 12, 2014, 5:42 a.m

[GSoC] Fwd: Wrap-Up phase and final evaluations

Darren, Ian, Seif, See the message below. Final evaluations will be entered by 8/21 Pencil down is right now (till 18), so it's time to wrap up. It would be great to see a slide deck that summarizes your work this summer or some nice wrap-up/blog post about your experience. Cheers, -Sebastien

Re: Review Request 24557: CLOUDSTACK-7308 - Adds tagging support for security group rules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24557/ --- (Updated Aug. 12, 2014, 7:27 a.m.) Review request for cloudstack, daan Hoogland

Re: Zones, Domains and Templates

Thanks for your comments. I have the seen the documentation, talking of adding users and project invitations etc. How to assign virtual resources like a vm (instance), disk/networking to a specific project. As far as domains are concerned, I was thinking as follows, please correct, if any err: