----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24547/#review50311 -----------------------------------------------------------
Ship it! Ship It! - Santhosh Edukulla On Aug. 11, 2014, 12:14 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24547/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2014, 12:14 p.m.) > > > Review request for cloudstack, Doug Clark and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-7304 > https://issues.apache.org/jira/browse/CLOUDSTACK-7304 > > > Repository: cloudstack-git > > > Description > ------- > > The test cases failed because the list API did not throw exception, but > returned None. > Discussed with Alena, in case of IP addresses, when the IP is disassociated > then it will return None for list call as it is retained in the database but > is not in allocated state. Changed the test case accordingly. > > These two cases failed from past 4 builds only. > > > Diffs > ----- > > test/integration/component/test_portable_ip.py b9c9059 > > Diff: https://reviews.apache.org/r/24547/diff/ > > > Testing > ------- > > Yes. > > Log: > test delete account with portable ip with no services enabled ... === > TestName: test_delete_account_services_disabled | Status : SUCCESS === > ok > test delete account with portable ip with PF and firewall services enabled > ... === TestName: test_delete_account_services_enabled | Status : SUCCESS === > ok > > ---------------------------------------------------------------------- > Ran 2 tests in 359.275s > > OK > > > Thanks, > > Gaurav Aradhye > >
