zone-wide primary storage: 2 possible UI bugs

2013-11-07 Thread Ryan Lei
I have observed two possible UI bugs that have to do with 4.2's new feature "zone-wide primary storage": 1. Volumes with zone-wide primary storage show no Hypervisor type in Storage tab. In the Storage tab, volumes that are placed in zone-wide primary storage have their Hypervisor field empty. So

Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

2013-11-07 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14874/#review28510 --- 4.2: ae852adabb70f43d6d349dd4ab56dc3116e10aed - Girish Shilamkar

Re: Review Request 15342: CLOUDSTACK-4648: Fixed Snapshots test cases

2013-11-07 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15342/#review28509 --- Commit 3c350ab0b8ce1687a8f7e27e9e2f8e8d0fa68c47 in branch refs/heads

Re: Review Request 15342: CLOUDSTACK-4648: Fixed Snapshots test cases

2013-11-07 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15342/#review28508 --- Commit b9547b07c059d229e6aed6213366cc3ab59fa26e in branch refs/heads

Re: Review Request 15341: Fix-for-5099: Utils.py-has-wrong-reference, cleaned it. As well added Uniform naming convention

2013-11-07 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15341/ --- (Updated Nov. 8, 2013, 7:16 a.m.) Review request for cloudstack and Srikanteswa

Re: Review Request 15342: CLOUDSTACK-4648: Fixed Snapshots test cases

2013-11-07 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15342/#review28507 --- Ship it! Ship It! - Girish Shilamkar On Nov. 8, 2013, 7:07 a.m.,

Re: Review Request 15341: Fix-for-5099: Utils.py-has-wrong-reference, cleaned it. As well added Uniform naming convention

2013-11-07 Thread SrikanteswaraRao Talluri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15341/#review28506 --- i can't see the diff - SrikanteswaraRao Talluri On Nov. 8, 2013,

Review Request 15342: CLOUDSTACK-4648: Fixed Snapshots test cases

2013-11-07 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15342/ --- Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. B

Review Request 15341: Fix-for-5099: Utils.py-has-wrong-reference, cleaned it. As well added Uniform naming convention

2013-11-07 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15341/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-50

Re: pool.storage.capacity.disablethreshold global config

2013-11-07 Thread Koushik Das
>From what I understand, now there is a new interface Configurable that exposes >the config parameters. In this case if you look at the >CapacityManagerImpl.java, there is a method getCongigKeys() that return the >config parameters. During MS startup all these are automatically populated in >th

Re: Review Request 14872: CLOUDSTACK-4934: Rename Limit resources tests so that they have unique names

2013-11-07 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14872/#review28500 --- Commit 8f76c49a994a630bfdd583c3515ac06c11c7c662 in branch refs/heads

Re: Review Request 15241: Renamed two modules with same name to avoid confusion while reporting test results

2013-11-07 Thread Santhosh Edukulla
> On Nov. 8, 2013, 4:30 a.m., SrikanteswaraRao Talluri wrote: > > Ship It! > > SrikanteswaraRao Talluri wrote: > These two files are already covered as part of > https://reviews.apache.org/r/14872/ ok. - Santhosh --- This is an au

RE: Reviewboard needs your attention

2013-11-07 Thread Animesh Chaturvedi
I can see it fine, were you logged in at that time > -Original Message- > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] > Sent: Thursday, November 07, 2013 6:03 PM > To: dev@cloudstack.apache.org > Subject: Re: Reviewboard needs your attention > > Hi Animesh, > > For whateve

Re: Review Request 15241: Renamed two modules with same name to avoid confusion while reporting test results

2013-11-07 Thread SrikanteswaraRao Talluri
> On Nov. 8, 2013, 4:30 a.m., SrikanteswaraRao Talluri wrote: > > Ship It! These two files are already covered as part of https://reviews.apache.org/r/14872/ - SrikanteswaraRao --- This is an automatically generated e-mail. To reply, v

Re: Review Request 14872: CLOUDSTACK-4934: Rename Limit resources tests so that they have unique names

2013-11-07 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14872/#review28497 --- Commit 5d6d14bc1f1579006406a68cd069fba14ba3fa0c in branch refs/heads

[ACS4.2.1]RC Date

2013-11-07 Thread Abhinandan Prateek
We are coming close to a RC. There are still some criticals open, have spoken to assignees and they are confident that these will be closed this week. Sudha has already asked for volunteers to test 4.1.1->4.2.1 upgrade paths and we have folks who have volunteered. I will also request the commun

Re: Review Request 15241: Renamed two modules with same name to avoid confusion while reporting test results

2013-11-07 Thread SrikanteswaraRao Talluri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15241/#review28495 --- Ship it! Ship It! - SrikanteswaraRao Talluri On Nov. 6, 2013, 2:

Re: Review Request 14872: CLOUDSTACK-4934: Rename Limit resources tests so that they have unique names

2013-11-07 Thread SrikanteswaraRao Talluri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14872/#review28496 --- Ship it! Ship It! - SrikanteswaraRao Talluri On Oct. 23, 2013, 8

Re: Review Request 15263: Added fix for bug 5056.

2013-11-07 Thread SrikanteswaraRao Talluri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15263/#review28494 --- Ship it! - SrikanteswaraRao Talluri On Nov. 6, 2013, 1:44 p.m., S

Re: Review Request 15263: Added fix for bug 5056.

2013-11-07 Thread SrikanteswaraRao Talluri
> On Nov. 7, 2013, 5:05 p.m., SrikanteswaraRao Talluri wrote: > > tools/marvin/marvin/remoteSSHClient.py, line 116 > > > > > > it should be self.keyPairFiles instead of keyPairFiles > > > > again keyPairFiles

Re: Storage overprovisioning for RBD / disable threshold?

2013-11-07 Thread Nitin Mehta
Please find answers inline On 07/11/13 3:32 AM, "Indra Pramana" wrote: >Dear all, > >I am using CloudStack 4.2.0, KVM hypervisors, Ceph RBD primary storage and >NFS secondary storage. > >I tried to change the storage.overprovisioning.factor from 1 to 2 under >Global Settings, and it doesn't seem

Re: ComponentContext :: getComponent() ?

2013-11-07 Thread Darren Shepherd
Not really. There is a away but it's intended for only framework code. The API framework uses it. For regular business logic, I've yet to see any good reason on why you need to look up things in the application context. There is typically a cleaner way. Darren > On Nov 6, 2013, at 2:19 PM,

RE: [ACS 421] Upgrade testing

2013-11-07 Thread Sudha Ponnaganti
Hi, Looks like Schuberg Philis is covering 4. 1.1 -> 4.2.1 upgrade We ( Citrix systems) would cover 4.2 -> 4.2.1 I think these two paths might be enough for this minor release. I think RC is going to cut soon so these need to be covered before that. Thanks /sudha -Original Message-

Re: Review Request 12883: DNS value in Zone is not getting set in the Network created for the Zone

2013-11-07 Thread Amogh Vasekar
> On July 30, 2013, 3:57 a.m., Soheil Eizadi wrote: > > In researching this more look like there is a code in NetworkManager that > > will set the Network DNS Domain, given proper DNS Capabilities > > (Capability.AllowDnsSuffixModification) is set in the DNS Offering. I need > > to investigate

Re: Review Request 13865: Extend support of CloudStack-managed storage to KVM

2013-11-07 Thread Mike Tutkowski
Hi, I just sent an e-mail to Animesh about this as I can no longer edit this review for some reason. Thanks! On Thu, Nov 7, 2013 at 7:04 PM, Amogh Vasekar wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13865/ > > Reminder - > Hi, > This r

Re: Review Request 14023: NetworkManager Exception Fix Due to call to getDhcpServiceProvider()

2013-11-07 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14023/#review28485 --- Reminder - Hi, This review has been pending for long. Please update

Re: Review Request 12098: Add PCI Passthrough to CloudStack on KVM Hypervisor

2013-11-07 Thread Amogh Vasekar
> On Aug. 7, 2013, 10:30 a.m., Pawit Pornkitprasan wrote: > > I will rebase it in a few days. > > > > This patch only includes support for KVM, but the concepts used can apply > > for all hypervisors supporting PCI Passthrough so additional patches can > > add support for XenServer. (Just to b

Re: Review Request 13865: Extend support of CloudStack-managed storage to KVM

2013-11-07 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13865/#review28483 --- Reminder - Hi, This review has been pending for long. Please update

Re: Review Request 13072: Print agent host name in logging of agent commands

2013-11-07 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13072/#review28482 --- Reminder - Hi, This review has been pending for long. Request the r

Re: Reviewboard needs your attention

2013-11-07 Thread Mike Tutkowski
Hi Animesh, For whatever reason, I can no longer edit https://reviews.apache.org/r/13865/. Any thoughts on this? Thanks! On Thu, Nov 7, 2013 at 6:41 PM, Nguyen Anh Tu wrote: > 2013/11/8 Animesh Chaturvedi > > > Given that we are approaching the 4.3 feature freeze tomorrow if you have > > su

Re: [PROPOSAL] Liaison with ETSI NFV ISG

2013-11-07 Thread Nguyen Anh Tu
2013/11/7 Chiradeep Vittal > While I appreciate the confidence, there are weekly calls to attend. > The particularly interesting one (MANO WG) happens on Wednesdays at 6am > PST. > I've tried but there's very little chance that I can attend these > meetings. > Anybody in a more agreeable timezone

Jenkins build is back to normal : build-master-noredist #1740

2013-11-07 Thread jenkins
See

Re: Reviewboard needs your attention

2013-11-07 Thread Nguyen Anh Tu
2013/11/8 Animesh Chaturvedi > Given that we are approaching the 4.3 feature freeze tomorrow if you have > submitted patches and are still pending reviews please reach out to your > reviewers Dear Sebastien & Hugo, I have two pending patches on review board need to review: Rebase OVS (sdnexte

Re: Router requires upgrade. Unable to send command to router Error

2013-11-07 Thread Alena Prokharchyk
Nitin, I had the same problem, but I fixed it by uploading 4.2 system templates to my secondary storage. Make sure you have the latest too. -alena. From: Nitin Mehta mailto:nitin.me...@citrix.com>> Reply-To: "dev@cloudstack.apache.org" mailto:dev@cloudstack.apa

Re: Commit 25c8cee01a450ee924fe108cafe54b046485ab2b broke Vmware on Master

2013-11-07 Thread Sheng Yang
Hi Daan, I think your patch is completely wrong. The BroadcastDomainType.getValue() would accept format of URI, not the number. I don't think your change would work, either in code or by semantic. I think your commit would break all elements your code touched. The current assumption of vlanId an

Router requires upgrade. Unable to send command to router Error

2013-11-07 Thread Nitin Mehta
Unable to deploy vms in the latest master because of the commit below. Is anyone noticing this on the latest master. I checked the code and there was a commit made recently 3f5b8f which is where the exception points to. WARN [o.a.c.alerts] (CapacityChecker:ctx-4f1ef01f) alertType:: 2 // data

Re: Commit 25c8cee01a450ee924fe108cafe54b046485ab2b broke Vmware on Master

2013-11-07 Thread Min Chen
Then we need to clearly define the semantic of parameter "vlanId" of HypervisorHostHelper.prepareNetwork is indeed the vlan Id string, not other format. The invoker method should pass the correct one to this utility to make it work. Thanks -min On 11/7/13 3:43 PM, "Daan Hoogland" wrote: >Doesn'

Re: Commit 25c8cee01a450ee924fe108cafe54b046485ab2b broke Vmware on Master

2013-11-07 Thread Daan Hoogland
Doesn't sound like a guarantee, If the stack is build otherwise there might come in a different (non-integer-representing) string. On Thu, Nov 7, 2013 at 6:08 PM, Min Chen wrote: > Yes. From callstack, > BroadcastDomainType.getValue(BroadcastDomainType.fromString(vlanId) is > already called befor

Build failed in Jenkins: build-master-noredist #1739

2013-11-07 Thread jenkins
See Changes: [sudison] Add quiencevm option on createsnapshotcmd [min.chen] CLOUDSTACK-4833:[Automation][BVT] Template and ISO test cases failing -- [...truncated 415 lines...] [INFO]

Re: [jira] [Updated] (CLOUDSTACK-4982) Top of dialogs cut off

2013-11-07 Thread Luis
Hi I will appreciate your help to fix this problem CloudStack 4.2 Ubuntu 12.04 single machine The errors 10.0.0.20:/export/primary/ 684G  2.5G  646G   1% /mnt/primary 10.0.0.20:/export/secondary/   684G  2.5G  646G   1% /mnt/secondary 10.0.0.20:/export/pr

pool.storage.capacity.disablethreshold global config

2013-11-07 Thread Alena Prokharchyk
I've run into the problem in master where I can't deploy the VM due to insufficient capacity: 2013-11-07 14:21:20,439 DEBUG [c.c.s.StorageManagerImpl] (Job-Executor-27:ctx-e5d8814d ctx-e5375ad7) Insufficient space on pool: 1 since its usage percentage: 4.875950712239125 has crossed the pool.st

Re: Bug? Should we allow detaching volumes when VMs have snapshots

2013-11-07 Thread Nux!
On 07.11.2013 21:17, Mike Tutkowski wrote: Especially since it appears to have been working for XenServer and I'd hate to take that functionality away from people who might be using it. +100, removing functionality will not gain you any extra points; especially doing it for what is probably t

Re: Review Request 15309: Fixed bug with deleting VMWare VM Snapshots

2013-11-07 Thread edison su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15309/#review28458 --- Ship it! Ship It! - edison su On Nov. 7, 2013, 9:30 p.m., Chris

Re: Review Request 15313: Updated VMSnapshotDetails* to match *Details* pattern (e.g. UserVMDetails*)

2013-11-07 Thread edison su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15313/#review28457 --- Ship it! Ship It! - edison su On Nov. 7, 2013, 9 p.m., Chris Sui

Re: Review Request 15326: Added option to reload VM during in RevertToVMSnapshotCommand

2013-11-07 Thread edison su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15326/#review28456 --- Ship it! Ship It! - edison su On Nov. 7, 2013, 9 p.m., Chris Sui

Re: Review Request 15309: Fixed bug with deleting VMWare VM Snapshots

2013-11-07 Thread Chris Suich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15309/ --- (Updated Nov. 7, 2013, 9:30 p.m.) Review request for cloudstack and edison su.

api incompatibility between 4.1 and 4.2 in ACLs

2013-11-07 Thread Marcus Sorensen
Maybe this has been discussed already, but we seem to have run into an api incompatibility. In 4.1, you could create ad-hoc ACL rules that applied to a network. In 4.2, you have to first create an 'ACL list', then add those rules to the list, then apply the list to a network. Or so it seems. This

Re: Bug? Should we allow detaching volumes when VMs have snapshots

2013-11-07 Thread Mike Tutkowski
Especially since it appears to have been working for XenServer and I'd hate to take that functionality away from people who might be using it. On Thu, Nov 7, 2013 at 2:15 PM, Mike Tutkowski wrote: > I can see the appeal in consistent behavior, but I'm not sure we want > CloudStack to always fol

Re: Bug? Should we allow detaching volumes when VMs have snapshots

2013-11-07 Thread Mike Tutkowski
I can see the appeal in consistent behavior, but I'm not sure we want CloudStack to always follow a least-common-denominator approach. Personally I recommend we leave XenServer's functionality here as is. On Thu, Nov 7, 2013 at 6:14 AM, SuichII, Christopher wrote: > Thanks for replying, Kelvin

RE: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

2013-11-07 Thread Animesh Chaturvedi
Ok I closed out the review as "submitted" > -Original Message- > From: Mike Tutkowski [mailto:nore...@reviews.apache.org] On Behalf Of > Mike Tutkowski > Sent: Thursday, November 07, 2013 1:03 PM > To: Edison Su; Mike Tutkowski > Cc: Marcus Sorensen; cloudstack > Subject: Re: Review Reques

Re: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

2013-11-07 Thread Mike Tutkowski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14381/#review28443 --- Ship it! Ship It! - Mike Tutkowski On Sept. 30, 2013, 5:14 p.m.,

Re: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

2013-11-07 Thread Mike Tutkowski
> On Oct. 7, 2013, 7:49 p.m., Mike Tutkowski wrote: > > This looks reasonable to me, Marcus. > > > > When do you think you might start the process of getting this into master? > > Animesh Chaturvedi wrote: > is this expected for 4.3? then this should be in master soon This code has been co

Re: Review Request 15313: Updated VMSnapshotDetails* to match *Details* pattern (e.g. UserVMDetails*)

2013-11-07 Thread Chris Suich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15313/ --- (Updated Nov. 7, 2013, 9 p.m.) Review request for cloudstack and edison su. R

Re: Review Request 15309: Fixed bug with deleting VMWare VM Snapshots

2013-11-07 Thread Chris Suich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15309/ --- (Updated Nov. 7, 2013, 9 p.m.) Review request for cloudstack and edison su. R

Review Request 15326: Added option to reload VM during in RevertToVMSnapshotCommand

2013-11-07 Thread Chris Suich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15326/ --- Review request for cloudstack and edison su. Repository: cloudstack-git Descr

Re: Review Request 15068: Change labels for VLAN to vNet

2013-11-07 Thread Yoshikazu Nojima
> On Nov. 4, 2013, 10:24 p.m., Jessica Wang wrote: > > Ship It! > > Animesh Chaturvedi wrote: > Has this been applied? Yes, it has. https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=5ccf3a90abb79eace839a8e61cf950248aa913c8 - Yoshikazu --

Review Request 15323: CLOUDSTACK-5080: Hypervisor Capabilities table missing entry for Simulator

2013-11-07 Thread David Grizzanti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15323/ --- Review request for cloudstack. Bugs: CLOUDSTACK-5080 https://issues.apache.

Re: Question: Error when creating templates from ROOT volumes in the Simulator

2013-11-07 Thread David Grizzanti
Prasanna, I took a look at the SimulatorImageStoreDriverImpl, but it seems like it's setting size correctly in that case. Also, in trying to step through the code, that section doesn't appear to be called when creating a template from a ROOT volume (I could be doing something wrong though when st

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-07 Thread Chip Childers
On Thu, Nov 07, 2013 at 06:59:25PM +, Animesh Chaturvedi wrote: > mvn --projects='org.apache.cloudstack:cloudstack' > org.apache.rat:apache-rat-plugin:0.8:check s/0.8/0.10 if you want the latest

Re: Enabling AMQP/RabbitMQ Events on master

2013-11-07 Thread David Grizzanti
Alena, I don't think these steps will work on master (not installing packages of cloudstack), I'm building from source. The componentContext XML file doesn't seem to exist anymore since some of the Spring refactoring was done. Thanks On Thu, Nov 7, 2013 at 12:42 PM, Alena Prokharchyk < alena.p

Re: Review Request 14784: [CLOUDSTACK-4805] Installation instructions drops support for Ubuntu

2013-11-07 Thread Travis Graham
> On Nov. 7, 2013, 2:38 p.m., Sebastien Goasguen wrote: > > this does not seem to apply. Can you please pull the latest and see what's > > going on > > > > thanks Do you want this based against master or 4.2? The patch was originally created against 4.2. - Travis

Re: [DISCUSS] Domain/Account/User Sync Up Among Multiple Regions

2013-11-07 Thread Chip Childers
On Thu, Nov 7, 2013 at 2:37 PM, Chiradeep Vittal wrote: > It may be an admin burden, but it has to be optional. There are other ways > to achieve global sync (e.g., LDAP/AD/Oauth). > A lot of service providers who run cloudstack have their own user database > / portal. In their implementations the

Re: Review Request 14786: [CLOUDSTACK-4609] [doc] Review Comments on Dedicated Resources: POD, CLUSTER

2013-11-07 Thread Sebastien Goasguen
> On Nov. 7, 2013, 7:34 p.m., Sebastien Goasguen wrote: > > Ship It! applied to master docs repo: 1f4822a75e2c100e19f2af8044ea6d767762d6ef - Sebastien --- This is an automatically generated e-mail. To reply, visit: https://reviews.apach

Re: Review Request 14783: [CLOUDSTACK-4844] Docs show incorrect URL for Windows password reset service download

2013-11-07 Thread Sebastien Goasguen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14783/#review28435 --- Ship it! applied to master: 5e6d003c57474c2e6c0d75e009e390468f67ab2

Re: [DISCUSS] Domain/Account/User Sync Up Among Multiple Regions

2013-11-07 Thread Chiradeep Vittal
It may be an admin burden, but it has to be optional. There are other ways to achieve global sync (e.g., LDAP/AD/Oauth). A lot of service providers who run cloudstack have their own user database / portal. In their implementations the CloudStack database is not the master source of user records, bu

Re: Review Request 14784: [CLOUDSTACK-4805] Installation instructions drops support for Ubuntu

2013-11-07 Thread Sebastien Goasguen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14784/#review28433 --- this does not seem to apply. Can you please pull the latest and see

Re: Review Request 14785: [CLOUDSTACK-4692] Release notes refer to componentsContext.xml instead of componentContext.xml

2013-11-07 Thread Sebastien Goasguen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14785/#review28432 --- Ship it! applied to master: 7229caff6eef3d5ed9b0bb282a593eb3425365a

Re: Review Request 14786: [CLOUDSTACK-4609] [doc] Review Comments on Dedicated Resources: POD, CLUSTER

2013-11-07 Thread Sebastien Goasguen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14786/#review28430 --- Ship it! Ship It! - Sebastien Goasguen On Nov. 7, 2013, 6:52 p.m

Re: Reviewboard needs your attention

2013-11-07 Thread Sebastien Goasguen
I hate to move deadline, but it might be good to have couple days to try to clean review board. -Sebastien On 7 Nov 2013, at 19:26, Animesh Chaturvedi wrote: > There are large number of patches in review board. I went through some of > them and followed up and closed out few that are already

Re: Review Request 12185: Remove dependency on backport-util.concurrent, and just use built in classes

2013-11-07 Thread Amogh Vasekar
> On Aug. 1, 2013, 8:31 a.m., daan Hoogland wrote: > > I think you need to rework this. Jenkins can't apply your patch and build > > it. Reminder- Hi, The review has been pending for long. Please update the patch since the build fails. Thanks - Amogh ---

Re: Review Request 12192: set the field 'state' rather than the unread parameter 'state', if the parameter is null

2013-11-07 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12192/#review28418 --- Reminder- Hi, The review has been pending for long. Please update th

Re: Review Request 14451: Some test for NetUtils

2013-11-07 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14451/#review28417 --- Reminder- Hi, The review has been pending for long. Please update th

Re: Review Request 14603: fixed Rules

2013-11-07 Thread Amogh Vasekar
> On Oct. 13, 2013, 6:32 p.m., daan Hoogland wrote: > > Ship It! Reminder- Hi, The review has been pending for long. Please update the review status to "submitted" if it has already been committed. Thanks - Amogh --- This is an automat

Re: Review Request 14604: Removing coded documentation

2013-11-07 Thread Amogh Vasekar
> On Oct. 13, 2013, 6:34 p.m., daan Hoogland wrote: > > :) Reminder- Hi, The review has been pending for long. Please update the review status if it has already been committed. Thanks - Amogh --- This is an automatically generated e-ma

Re: Review Request 8294: Store NetworkServiceProvider connectivity service configuration in database.

2013-11-07 Thread Amogh Vasekar
> On Jan. 29, 2013, 9:43 a.m., Hugo Trippaers wrote: > > The change looks good. Could you update the patch to the latest state of > > master? > > Animesh Chaturvedi wrote: > Hiroaki can you update the patch to latetst master. > > Animesh Chaturvedi wrote: > Any updates Hiroaki? Remind

RE: [ACS43] Schedule reminder : feature freeze this Friday 11/08

2013-11-07 Thread Animesh Chaturvedi
That's what I thought because you had said 7th morning > -Original Message- > From: Chip Childers [mailto:chip.child...@gmail.com] > Sent: Thursday, November 07, 2013 10:59 AM > To: dev@cloudstack.apache.org > Subject: Re: [ACS43] Schedule reminder : feature freeze this Friday > 11/08 > >

Re: Review Request 11861: double slash fix for windows based nfs servers [CLOUDSTACK-2968]

2013-11-07 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11861/#review28410 --- Reminder- Hi, The review has been pending for long. Please update th

Re: Review Request 14628: AutoScaling without NetScaler

2013-11-07 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14628/#review28408 --- Reminder- Hi, The review has been pending for long. Please update th

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-07 Thread Will Stevens
Perfect. Thank you for the details. On Thu, Nov 7, 2013 at 1:59 PM, Sheng Yang wrote: > Oh, that means something wrong with the license header of the file(header > missing in this case). > > http://creadur.apache.org/rat/ > > --Sheng > > > On Thu, Nov 7, 2013 at 10:50 AM, Will Stevens > wrote

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-07 Thread Sheng Yang
Oh, that means something wrong with the license header of the file(header missing in this case). http://creadur.apache.org/rat/ --Sheng On Thu, Nov 7, 2013 at 10:50 AM, Will Stevens wrote: > Just so I know, can you explain what it means to 'Fail RAT'? Thx... > > > On Thu, Nov 7, 2013 at 1:46

RE: [Merge] Palo Alto Networks firewall integration to master

2013-11-07 Thread Animesh Chaturvedi
RAT is release audit tool and checks for missing license headers. You can run it as below mvn --projects='org.apache.cloudstack:cloudstack' org.apache.rat:apache-rat-plugin:0.8:check The build should FAIL if there are any non-compliant files that are not specifically excluded from the ASF li

Re: [ACS43] Schedule reminder : feature freeze this Friday 11/08

2013-11-07 Thread Chip Childers
I was off - this morning it cleared. Sorry. Merge away. On Thu, Nov 7, 2013 at 1:55 PM, Chip Childers wrote: > Please wait for tomorrow morning US time. 72 hours is not up yet. > >> On Nov 7, 2013, at 12:45 PM, Animesh Chaturvedi >> wrote: >> >> Chip can you confirm if the IP clearance is don

Re: [ACS43] Schedule reminder : feature freeze this Friday 11/08

2013-11-07 Thread Chip Childers
Yes - please do. On Thu, Nov 07, 2013 at 05:45:27PM +, Animesh Chaturvedi wrote: > Chip can you confirm if the IP clearance is done, should Devdeep proceed with > merging into master? > > > -Original Message- > > From: Chip Childers [mailto:chipchild...@apache.org] > > Sent: Tuesday,

Re: [ACS43] Schedule reminder : feature freeze this Friday 11/08

2013-11-07 Thread Chip Childers
Please wait for tomorrow morning US time. 72 hours is not up yet. > On Nov 7, 2013, at 12:45 PM, Animesh Chaturvedi > wrote: > > Chip can you confirm if the IP clearance is done, should Devdeep proceed with > merging into master? > >> -Original Message- >> From: Chip Childers [mailto

Re: Review Request 14784: [CLOUDSTACK-4805] Installation instructions drops support for Ubuntu

2013-11-07 Thread Travis Graham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14784/ --- (Updated Nov. 7, 2013, 1:53 p.m.) Review request for cloudstack and Joe Brockme

Re: Review Request 14783: [CLOUDSTACK-4844] Docs show incorrect URL for Windows password reset service download

2013-11-07 Thread Travis Graham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14783/ --- (Updated Nov. 7, 2013, 1:53 p.m.) Review request for cloudstack and Joe Brockme

Re: Review Request 14785: [CLOUDSTACK-4692] Release notes refer to componentsContext.xml instead of componentContext.xml

2013-11-07 Thread Travis Graham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14785/ --- (Updated Nov. 7, 2013, 1:52 p.m.) Review request for cloudstack and Joe Brockme

Re: Review Request 14786: [CLOUDSTACK-4609] [doc] Review Comments on Dedicated Resources: POD, CLUSTER

2013-11-07 Thread Travis Graham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14786/ --- (Updated Nov. 7, 2013, 1:52 p.m.) Review request for cloudstack and Joe Brockme

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-07 Thread Will Stevens
Just so I know, can you explain what it means to 'Fail RAT'? Thx... On Thu, Nov 7, 2013 at 1:46 PM, Sheng Yang wrote: > Fixed. > > --Sheng > > > On Thu, Nov 7, 2013 at 10:23 AM, Animesh Chaturvedi < > animesh.chaturv...@citrix.com> wrote: > > > Fails RAT on > > > plugins/network-elements/palo-

Re: Review Request 12660: Replaced multiple grep/awk/head commands by one awk

2013-11-07 Thread Animesh Chaturvedi
> On July 26, 2013, 10:24 p.m., Jenkins Cloudstack.org wrote: > > Review 12660 failed the build test : FAILURE > > The url of build cloudstack-master-with-patch #55 is : > > http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/55/ Patch needs to br updated, fails the build - Animesh

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-07 Thread Sheng Yang
Fixed. --Sheng On Thu, Nov 7, 2013 at 10:23 AM, Animesh Chaturvedi < animesh.chaturv...@citrix.com> wrote: > Fails RAT on > plugins/network-elements/palo-alto/src/com/cloud/network/utils/HttpClientWrapper.java > > > > -Original Message- > > From: williamstev...@gmail.com [mailto:william

Re: Review Request 12679: CLOUDSTACK-904: Changed multiple vcpus to one vcpu with multiple sockets

2013-11-07 Thread Animesh Chaturvedi
> On July 17, 2013, 4:43 p.m., Wido den Hollander wrote: > > Hmm, I'm not sure about this one. > > > > In the UI we indeed mention the amount of cores, however, the API parameter > > is "cpunumber". > > > > So I get the reasoning, but we would be changing a lot here. I don't know > > if this

Re: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

2013-11-07 Thread Animesh Chaturvedi
> On Oct. 7, 2013, 7:49 p.m., Mike Tutkowski wrote: > > This looks reasonable to me, Marcus. > > > > When do you think you might start the process of getting this into master? is this expected for 4.3? then this should be in master soon - Animesh

Reviewboard needs your attention

2013-11-07 Thread Animesh Chaturvedi
There are large number of patches in review board. I went through some of them and followed up and closed out few that are already checked in, but the list is huge. Given that we are approaching the 4.3 feature freeze tomorrow if you have submitted patches and are still pending reviews please re

RE: [Merge] Palo Alto Networks firewall integration to master

2013-11-07 Thread Animesh Chaturvedi
Fails RAT on plugins/network-elements/palo-alto/src/com/cloud/network/utils/HttpClientWrapper.java > -Original Message- > From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On > Behalf Of Will Stevens > Sent: Wednesday, November 06, 2013 10:15 AM > To: dev@cloudstack.apache

Re: [DISCUSS] Domain/Account/User Sync Up Among Multiple Regions

2013-11-07 Thread Alex Ough
I don't mind implementing it in the core server unless there is anyone who thinks differently. Anyone with another thought? Thank Daan for your suggestion. Alex Ough On Thu, Nov 7, 2013 at 11:23 AM, Daan Hoogland wrote: > Alex, > > Why would you want to make this a plugin? It sounds like a func

Re: Review Request 15068: Change labels for VLAN to vNet

2013-11-07 Thread Animesh Chaturvedi
> On Nov. 4, 2013, 10:24 p.m., Jessica Wang wrote: > > Ship It! Has this been applied? - Animesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15068/#review28144 --

RE: [ACS43] Schedule reminder : feature freeze this Friday 11/08

2013-11-07 Thread Animesh Chaturvedi
Chip can you confirm if the IP clearance is done, should Devdeep proceed with merging into master? > -Original Message- > From: Chip Childers [mailto:chipchild...@apache.org] > Sent: Tuesday, November 05, 2013 9:36 AM > To: dev@cloudstack.apache.org > Subject: Re: [ACS43] Schedule reminde

Re: Enabling AMQP/RabbitMQ Events on master

2013-11-07 Thread Alena Prokharchyk
David, Here are the instructions that I've got from one of the CS QA engineers, hope it helps. FS - http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.1.0/html/Admin_Guide/events.html#event-framework Test cases relating to this feature was covered as part of Regions Feature testing -

Re: Review Request 15263: Added fix for bug 5056.

2013-11-07 Thread Santhosh Edukulla
> On Nov. 7, 2013, 5:05 p.m., SrikanteswaraRao Talluri wrote: > > tools/marvin/marvin/remoteSSHClient.py, line 115 > > > > > > self.keyPairFiles is not defined at this moment we are getting an > > exception here. > >

  1   2   >