Re: Patch Available vs Needs Committer

2025-01-29 Thread Dmitry Konstantinov
> Jira actually does that and creates a diagram, Yes, I am aware about this functionality, unfortunately it does not show the most interesting part: conditions/expectations for transitions I have combined the following summary based on comments from Benedict, the docs and a discussion with Stefan:

Re: Patch Available vs Needs Committer

2025-01-29 Thread Brandon Williams
On Wed, Jan 29, 2025 at 10:26 AM Dmitry Konstantinov wrote: > I want to draw it explicitly (as a diagram or as a table) and share to check > my understanding, then after a discussion it can be integrated in the > contributor docs. > I hope it makes sense.. Jira actually does that and creates a

Re: Patch Available vs Needs Committer

2025-01-29 Thread Benedict
Patch available means the PR is ready for review.Needs committer means we think it’s ready to merge but we need at least one more committer +1 (and maybe one to actually merge).There’s a requirement that at least one contributor reviews a patch. There’s a separate a requirement that two committers

Re: Patch Available vs Needs Committer

2025-01-29 Thread Dmitry Konstantinov
Hi all, I have used Cassandra for a long time and had my fork to make changes but recently I have started to contribute more actively to the upstream. As a quite a new contributor I am a bit confused with a lack of clarity for ticket transition rules. I understand that for the majority there is no

Patch Available vs Needs Committer

2025-01-27 Thread Brandon Williams
Hello, This is just a reminder of the difference between these states. "Needs committer" is for when there is already one reviewer, and a second is needed (this state used to be called "Needs 2nd reviewer".) "Patch Available" is the state used when you need an initial review. If in doubt, use "Pat