Patch available means the PR is ready for review.
Needs committer means we think it’s ready to merge but we need at least one more committer +1 (and maybe one to actually merge).
There’s a requirement that at least one contributor reviews a patch. There’s a separate a requirement that two committers +1 a patch. One of these can be the author, and neither committers have to have fully reviewed the patch themselves.
This is documented somewhere, but its relation to these Jira states probably is not
On 29 Jan 2025, at 16:25, Dmitry Konstantinov <netud...@gmail.com> wrote:
Hi all,
I have used Cassandra for a long time and had my fork to make changes but recently I have started to contribute more actively to the upstream. As a quite a new contributor I am a bit confused with a lack of clarity for ticket transition rules. I understand that for the majority there is no real need for it - people just have it learned from practice but probably we can use me as a tester for the process description to make it more clear and explicit. I read the following docs:
but still I do not have a very clear picture of a ticket lifecycle (especially about the part with reviewing/approvals). For me as an engineer it is a finite state machine with conditions on transitions between states. I want to draw it explicitly (as a diagram or as a table) and share to check my understanding, then after a discussion it can be integrated in the contributor docs. I hope it makes sense..
Regards, Dmitry Hello,
This is just a reminder of the difference between these states.
"Needs committer" is for when there is already one reviewer, and a
second is needed (this state used to be called "Needs 2nd reviewer".)
"Patch Available" is the state used when you need an initial review.
If in doubt, use "Patch Available" please, and thanks!
https://lists.apache.org/thread/g4mvx41jdvn700719po0nxhz7n1ftpnc
Kind Regards,
Brandon
-- Dmitry Konstantinov
|
