Re: [Discuss] disabling io.netty.transport.noNative in tests

2023-09-07 Thread Miklosovic, Stefan
io.netty.transport.noNative in tests NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe. I think the Native dependencies were disabled for in-jvm Netty because they prevented the in-jvm dtest

Re: [Discuss] disabling io.netty.transport.noNative in tests

2023-09-07 Thread Jon Meredith
I think the Native dependencies were disabled for in-jvm Netty because they prevented the in-jvm dtest InstanceClassLoaders from being garbage collected and were a source of out-of-metaspace exceptions. I'll echo Alex's comment that you will also need to investigate in-jvm upgrade tests. I'm not s

Re: [Discuss] disabling io.netty.transport.noNative in tests

2023-09-06 Thread Alex Petrov
I think most of the time people actually use netty _with_ native. This might have been introduced when we were tried to make shaded in-JVM dtest jars. If all tests are passing, and we actually do have a confirmtion that native Netty is being used, I would say +1 to remove `noNative`. Just to m

[Discuss] disabling io.netty.transport.noNative in tests

2023-08-31 Thread Miklosovic, Stefan
Hi list, Currently, we are skipping the usage of native libraries in Netty as part of testing here (1). In 5.0 branch, we upgraded Netty to 4.1.96 and we brought all native dependencies to the class path so they are there in runtime (x86, arm, mac). I conducted few CI tests for 5.0+ and not ha