Re: [DISCUSS] Bring cassandra-harry in tree as a submodule

2023-05-24 Thread Alex Petrov
While we are at it, we may also want to pull the in-jvm dtest API as a submodule, and actually move some tests that are common between the branches there. On Thu, May 25, 2023, at 6:03 AM, Caleb Rackliffe wrote: > Isn’t the other reason Accord works well as a submodule that it has no > dependen

Re: [DISCUSS] Bring cassandra-harry in tree as a submodule

2023-05-24 Thread Caleb Rackliffe
Isn’t the other reason Accord works well as a submodule that it has no dependencies on C* proper? Harry does at the moment, right? (Not that we couldn’t address that…just trying to think this through…)On May 24, 2023, at 6:54 PM, Benedict wrote:In this case Harry is a testing module - it’s not so

Re: [DISCUSS] Bring cassandra-harry in tree as a submodule

2023-05-24 Thread Benedict
In this case Harry is a testing module - it’s not something we will develop in tandem with C* releases, and we will want improvements to be applied across all branches.So it seems a natural fit for submodules to me.On 24 May 2023, at 21:09, Caleb Rackliffe wrote:> Submodules do have their own ove

[GitHub] [cassandra-analytics] yifan-c closed pull request #2: CASSANDRA-18548: Add the .asf.yaml file

2023-05-24 Thread via GitHub
yifan-c closed pull request #2: CASSANDRA-18548: Add the .asf.yaml file URL: https://github.com/apache/cassandra-analytics/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [cassandra-analytics] frankgh commented on a diff in pull request #2: CASSANDRA-18548: Add the .asf.yaml file

2023-05-24 Thread via GitHub
frankgh commented on code in PR #2: URL: https://github.com/apache/cassandra-analytics/pull/2#discussion_r1204795137 ## .asf.yaml: ## @@ -0,0 +1,8 @@ +github: + enabled_merge_buttons: +squash: false Review Comment: Makes sense, I've updated the PR -- This is an aut

[GitHub] [cassandra-analytics] yifan-c commented on a diff in pull request #2: CASSANDRA-18548: Add the .asf.yaml file

2023-05-24 Thread via GitHub
yifan-c commented on code in PR #2: URL: https://github.com/apache/cassandra-analytics/pull/2#discussion_r1204782644 ## .asf.yaml: ## @@ -0,0 +1,8 @@ +github: + enabled_merge_buttons: +squash: false Review Comment: If ever wants to allow merge directly from gh, can we

Re: [GitHub] [cassandra-analytics] frankgh opened a new pull request, #1: Provide a SecretsProvider interface to abstract the secret provisioning

2023-05-24 Thread Francisco Guerrero
I have created this JIRA to add the .asf.yaml file https://issues.apache.org/jira/browse/CASSANDRA-18548 And here is the corresponding patch: https://github.com/apache/cassandra-analytics/pull/2 Best, - Francisco On 2023/05/24 07:55:44 Mick Semb Wever wrote: > Francisco, can you please put the a

[GitHub] [cassandra-analytics] frankgh opened a new pull request, #2: CASSANDRA-18548: Add the .asf.yaml file

2023-05-24 Thread via GitHub
frankgh opened a new pull request, #2: URL: https://github.com/apache/cassandra-analytics/pull/2 This commit adds the .asf.yaml file to control notifications and github settings for the Cassandra Analytics project. -- This is an automated message from the Apache Git Service. To respond to

Re: [DISCUSS] Bring cassandra-harry in tree as a submodule

2023-05-24 Thread Caleb Rackliffe
> Submodules do have their own overhead and edge cases, so I am mostly in favor of using for cases where the code must live outside of tree (such as jvm-dtest that lives out of tree as all branches need the same interfaces) Agreed. Basically where I've ended up on this topic. > We could go over s

Re: [DISCUSS] Bring cassandra-harry in tree as a submodule

2023-05-24 Thread Alex Petrov
> I'm about to need to harry test for the paging across tombstone work for > https://issues.apache.org/jira/browse/CASSANDRA-18424 (that's where my own > overlapping fuzzing came in). In the process, I'll see if I can't distill > something really simple along the lines of how React approaches it

Re: [DISCUSS] Bring cassandra-harry in tree as a submodule

2023-05-24 Thread Mick Semb Wever
> > So looking at accord trunk, we needed 12 votes for a release, and each > vote is a min of 3 days, so 36 days of overhead vs 5 hours of work? > That's apples and oranges (wait time vs effort time). I was most interested in (and supportive of) your qualified opinion :-) > One thing that ca

Re: [DISCUSS] Bring cassandra-harry in tree as a submodule

2023-05-24 Thread David Capwell
> The time spent on getting that running has been a fair few hours, where we > could have cut many manual module releases in that time. We spent a few hours getting submodules working, and we no longer need to release for every single commit… $ git log b9025e59395f47535e4ed1fec20b1186cdb07db8.

Re: [VOTE] Release dtest-api 0.0.15

2023-05-24 Thread Jon Meredith
+1 On Wed, May 24, 2023 at 10:13 AM Francisco Guerrero wrote: > +1 (nb) > > On 2023/05/24 15:38:54 Alex Petrov wrote: > > +1 > > > > On Wed, May 24, 2023, at 5:36 PM, Doug Rohrer wrote: > > > +1 (nb) > > > > > > > On May 24, 2023, at 11:32 AM, Brandon Williams > wrote: > > > > > > > > +1 > > >

Re: Vector search demo, and query syntax

2023-05-24 Thread DuyHai Doan
Hello all Sorry to disturb the discussion but there is an official announcement from Microsoft about CosmosDB supporting Vector Search https://devblogs.microsoft.com/cosmosdb/introducing-vector-search-in-azure-cosmos-db-for-mongodb-vcore/ Looks like Jonathan is spot on about this feature, it's q

Re: [VOTE] Release dtest-api 0.0.15

2023-05-24 Thread Francisco Guerrero
+1 (nb) On 2023/05/24 15:38:54 Alex Petrov wrote: > +1 > > On Wed, May 24, 2023, at 5:36 PM, Doug Rohrer wrote: > > +1 (nb) > > > > > On May 24, 2023, at 11:32 AM, Brandon Williams wrote: > > > > > > +1 > > > > > > Kind Regards, > > > Brandon > > > > > > On Wed, May 24, 2023 at 10:31 AM Dine

Re: [VOTE] Release dtest-api 0.0.15

2023-05-24 Thread Alex Petrov
+1 On Wed, May 24, 2023, at 5:36 PM, Doug Rohrer wrote: > +1 (nb) > > > On May 24, 2023, at 11:32 AM, Brandon Williams wrote: > > > > +1 > > > > Kind Regards, > > Brandon > > > > On Wed, May 24, 2023 at 10:31 AM Dinesh Joshi wrote: > >> > >> Proposing the test build of in-jvm dtest API 0.0.

Re: [VOTE] Release dtest-api 0.0.15

2023-05-24 Thread Doug Rohrer
+1 (nb) > On May 24, 2023, at 11:32 AM, Brandon Williams wrote: > > +1 > > Kind Regards, > Brandon > > On Wed, May 24, 2023 at 10:31 AM Dinesh Joshi wrote: >> >> Proposing the test build of in-jvm dtest API 0.0.15 for release. >> >> Repository: >> https://gitbox.apache.org/repos/asf?p=cassa

Re: [VOTE] Release dtest-api 0.0.15

2023-05-24 Thread Brandon Williams
+1 Kind Regards, Brandon On Wed, May 24, 2023 at 10:31 AM Dinesh Joshi wrote: > > Proposing the test build of in-jvm dtest API 0.0.15 for release. > > Repository: > https://gitbox.apache.org/repos/asf?p=cassandra-in-jvm-dtest-api.git > > Candidate SHA: > https://github.com/apache/cassandra-in-jv

[VOTE] Release dtest-api 0.0.15

2023-05-24 Thread Dinesh Joshi
Proposing the test build of in-jvm dtest API 0.0.15 for release. Repository: https://gitbox.apache.org/repos/asf?p=cassandra-in-jvm-dtest-api.git Candidate SHA: https://github.com/apache/cassandra-in-jvm-dtest-api/commit/48af78d1d4b5f285d3dd4991afd4df3101e3983a tagged with 0.0.15 Artifacts: http

Re: [DISCUSS] Bring cassandra-harry in tree as a submodule

2023-05-24 Thread Josh McKenzie
> I have submitted a proposal to Cassandra Summit for a 4-hour Harry workshop, I'm about to need to harry test for the paging across tombstone work for https://issues.apache.org/jira/browse/CASSANDRA-18424 (that's where my own overlapping fuzzing came in). In the process, I'll see if I can't dist

Re: [DISCUSS] Bring cassandra-harry in tree as a submodule

2023-05-24 Thread Alex Petrov
> I wonder if a mini-onboarding session would be good as a community session - > go over Harry, how to run it, how to add a test? Would that be the right > venue? I just would like to see how we can not only plug it in to regular CI > but get everyone that wants to add a test be able to know h

Re: [DISCUSS] Bring cassandra-harry in tree as a submodule

2023-05-24 Thread Brandon Williams
On Wed, May 24, 2023 at 7:45 AM Josh McKenzie wrote: > What prompted this thread was harry being external to the core codebase and > the lack of adoption and usage of it having led to atrophy of certain aspects > of it, which then led to redundant implementation of some fuzz testing and > lost

Re: [DISCUSS] Bring cassandra-harry in tree as a submodule

2023-05-24 Thread Alex Petrov
I think pulling Harry into the tree will make adoption easier for the folks. I have been a bit swamped with Transactional Metadata work, but I wanted to make some of the things we were using for testing TCM available outside of TCM branch. This includes a bunch of helper methods to perform opera

Re: [DISCUSS] Bring cassandra-harry in tree as a submodule

2023-05-24 Thread Josh McKenzie
> importantly it’s a million times better than the dtest-api process - which > stymies development due to the friction. This is my major concern. What prompted this thread was harry being external to the core codebase and the lack of adoption and usage of it having led to atrophy of certain aspe

Re: Vector search demo, and query syntax

2023-05-24 Thread Josh McKenzie
+1 to the flow of: 1: ORDER BY? 2: Oh. Yeah. That *does *makes sense. ;) (sending from fastmail in the hopes the image doesn't get stripped. Thanks ASF smtp server...) ~Josh On Wed, May 24, 2023, at 1:00 AM, Jeremiah D Jordan wrote: > At first I wasn’t sure about using ORDER BY, but the mor

Re: [DISCUSS] Bring cassandra-harry in tree as a submodule

2023-05-24 Thread Benedict
It’s not without hiccups, and I’m sure we have more to learn. But it mostly just works, and importantly it’s a million times better than the dtest-api process - which stymies development due to the friction.On 24 May 2023, at 08:39, Mick Semb Wever wrote:WRT git submodules and CASSANDRA-18204, ar

Re: [GitHub] [cassandra-analytics] frankgh opened a new pull request, #1: Provide a SecretsProvider interface to abstract the secret provisioning

2023-05-24 Thread Mick Semb Wever
Francisco, can you please put the appropriate .asf.yaml file in place so notifications are sent to correct MLs. On Tue, 23 May 2023 at 22:56, frankgh (via GitHub) wrote: > > frankgh opened a new pull request, #1: > URL: https://github.com/apache/cassandra-analytics/pull/1 > >This commit intr

Re: [DISCUSS] Bring cassandra-harry in tree as a submodule

2023-05-24 Thread Mick Semb Wever
WRT git submodules and CASSANDRA-18204, are we happy with how it is working for accord ? The time spent on getting that running has been a fair few hours, where we could have cut many manual module releases in that time. David and folks working on accord ? On Tue, 23 May 2023 at 20:09, Josh Mc