Thanks all! Sent a patch out in
https://issues.apache.org/jira/browse/CASSANDRA-16096 and tested the change
autogenerates the annotation now (if using Intellij it is best to delete
the project and regenerate it as the change didn't take without deleting in
intellij).
On Wed, Sep 2, 2020 at 10:22
+1
> On Sep 1, 2020, at 11:27 AM, David Capwell wrote:
>
> Currently our style guide recommends to avoid using @Override and updates
> intellij's code style to exclude it by default; I would like to propose we
> change this recommendation to use it and to update intellij's style to
> include it
+1. Some of us have already adopted this change some time ago, but it’d be nice
to make it official for everybody.
> On 1 Sep 2020, at 19:27, David Capwell wrote:
>
> Currently our style guide recommends to avoid using @Override and updates
> intellij's code style to exclude it by default; I wo
+1
—
Robert Stupp
@snazy
> On 2. Sep 2020, at 10:38, Sylvain Lebresne wrote:
>
> +1
> --
> Sylvain
>
>
> On Wed, Sep 2, 2020 at 10:21 AM Sam Tunnicliffe wrote:
>
>> +1
>>
>>> On 2 Sep 2020, at 09:03, Benjamin Lerer
>> wrote:
>>>
>>> +1
>>>
>>>
>>>
>>> On Wed, Sep 2, 2020 at 5:36 AM Ber
+1
--
Sylvain
On Wed, Sep 2, 2020 at 10:21 AM Sam Tunnicliffe wrote:
> +1
>
> > On 2 Sep 2020, at 09:03, Benjamin Lerer
> wrote:
> >
> > +1
> >
> >
> >
> > On Wed, Sep 2, 2020 at 5:36 AM Berenguer Blasi >
> > wrote:
> >
> >> +1
> >>
> >> On 2/9/20 5:09, Joshua McKenzie wrote:
> >>> +1
> >>>
>
+1
> On 2 Sep 2020, at 09:03, Benjamin Lerer wrote:
>
> +1
>
>
>
> On Wed, Sep 2, 2020 at 5:36 AM Berenguer Blasi
> wrote:
>
>> +1
>>
>> On 2/9/20 5:09, Joshua McKenzie wrote:
>>> +1
>>>
>>> On Tue, Sep 1, 2020 at 6:26 PM Jordan West wrote:
>>>
+1
On Tue, Sep 1, 2020 at
+1
On Wed, Sep 2, 2020 at 5:36 AM Berenguer Blasi
wrote:
> +1
>
> On 2/9/20 5:09, Joshua McKenzie wrote:
> > +1
> >
> > On Tue, Sep 1, 2020 at 6:26 PM Jordan West wrote:
> >
> >> +1
> >>
> >> On Tue, Sep 1, 2020 at 12:22 PM Benedict Elliott Smith <
> >> bened...@apache.org>
> >> wrote:
> >>
>
Very much appreciated that this was raised here Blake, and the
detailed write-up you provided.
If 4.0-beta gets more such large improvement patches than it does testing
and bug-fix patches, then the concern is we will never get to 4.0-rc. So I
hope it is only obvious and valued that we do and cont
