+1 > On 2 Sep 2020, at 09:03, Benjamin Lerer <benjamin.le...@datastax.com> wrote: > > +1 > > > > On Wed, Sep 2, 2020 at 5:36 AM Berenguer Blasi <berenguerbl...@gmail.com> > wrote: > >> +1 >> >> On 2/9/20 5:09, Joshua McKenzie wrote: >>> +1 >>> >>> On Tue, Sep 1, 2020 at 6:26 PM Jordan West <jorda...@gmail.com> wrote: >>> >>>> +1 >>>> >>>> On Tue, Sep 1, 2020 at 12:22 PM Benedict Elliott Smith < >>>> bened...@apache.org> >>>> wrote: >>>> >>>>> +1 >>>>> >>>>> >>>>> >>>>> On 01/09/2020, 20:09, "Caleb Rackliffe" <calebrackli...@gmail.com> >>>> wrote: >>>>> >>>>> >>>>> +1 >>>>> >>>>> >>>>> >>>>> On Tue, Sep 1, 2020, 2:00 PM Jasonstack Zhao Yang < >>>>> jasonstack.z...@gmail.com> >>>>> >>>>> wrote: >>>>> >>>>> >>>>> >>>>>> +1 >>>>> >>>>>> >>>>> >>>>>> On Wed, 2 Sep 2020 at 02:45, Dinesh Joshi <djo...@apache.org> >>>> wrote: >>>>>> >>>>> >>>>>>> +1 >>>>> >>>>>>> >>>>> >>>>>>>> On Sep 1, 2020, at 11:27 AM, David Capwell < >> dcapw...@gmail.com >>>>> >>>>> wrote: >>>>> >>>>>>>> >>>>> >>>>>>>> Currently our style guide recommends to avoid using @Override >>>> and >>>>>> updates >>>>> >>>>>>>> intellij's code style to exclude it by default; I would like >> to >>>>> propose >>>>> >>>>>>> we >>>>> >>>>>>>> change this recommendation to use it and to update intellij's >>>>> style to >>>>> >>>>>>>> include it by default. >>>>> >>>>>>>> >>>>> >>>>>>>> @Override is used by javac to enforce that a method is in >> fact >>>>> >>>>>> overriding >>>>> >>>>>>>> from an abstract class or an interface and if this stops >> being >>>>> true >>>>> >>>>>> (such >>>>> >>>>>>>> as a refactor happens) then a compiler error is thrown; when >> we >>>>> default >>>>> >>>>>>> to >>>>> >>>>>>>> excluding, it makes it harder to detect that a refactor >> catches >>>>> all >>>>> >>>>>>>> implementations and can lead to subtle and hard to track down >>>>> bugs. >>>>> >>>>>>>> >>>>> >>>>>>>> This proposal is for new code and would not be to go rewrite >>>> all >>>>> code >>>>> >>>>>> at >>>>> >>>>>>>> once, but would recommend new code adopt this style, and to >>>> pull >>>>> old >>>>> >>>>>> code >>>>> >>>>>>>> forward which is related to changes being made (similar to >> our >>>>> stance >>>>> >>>>>> on >>>>> >>>>>>>> imports). >>>>> >>>>>>>> >>>>> >>>>>>>> If people are ok with this, I will file a JIRA, update the >>>> docs, >>>>> and >>>>> >>>>>>>> update intellij's formatting. >>>>> >>>>>>>> >>>>> >>>>>>>> Thanks for your time! >>>>> >>>>>>> >>>>> >>>>>>> >>>>> >>>>>>> >>>>> --------------------------------------------------------------------- >>>>> >>>>>>> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org >>>>> >>>>>>> For additional commands, e-mail: dev-h...@cassandra.apache.org >>>>> >>>>>>> >>>>> >>>>>>> >>>>> >>>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> >>>>> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org >>>>> >>>>> For additional commands, e-mail: dev-h...@cassandra.apache.org >>>>> >>>>> >>>>> >>>>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org >> For additional commands, e-mail: dev-h...@cassandra.apache.org >> >>
--------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
