Re: Proposal: github pull requests for all code changes

2017-12-20 Thread Jeff Jirsa
Inline -- Jeff Jirsa > On Dec 20, 2017, at 8:38 PM, kurt greaves wrote: > > It would definitely be nice if PR's were made against the actual repo. > Makes commenting/reviewing code a lot easier. I'd say as long as PR's are > kept permanently (after closing) so we can go back and look over >

Re: Proposal: github pull requests for all code changes

2017-12-20 Thread kurt greaves
It would definitely be nice if PR's were made against the actual repo. Makes commenting/reviewing code a lot easier. I'd say as long as PR's are kept permanently (after closing) so we can go back and look over comments/patches would be a big plus. Not a fan of going through JIRA tickets and finding

Re: Proposal: github pull requests for all code changes

2017-12-20 Thread mck
> There's also no way for us to label, assign or otherwise use PR related > features, so I'm really wondering why it would make sense to more > heavily using them. Apache does now offer the GitBox service. This makes the github repository writable. The asf and github repos are kept in sync, rat

Re: How to fetch replication factor of a given keyspace

2017-12-20 Thread kurt greaves
Did you look at how status fetches and initialises the keyspace? Have a look at org.apache.cassandra.service.StorageService#effectiveOwnership. It uses a keyspace and its RF to measure ownership. The same method should work for any nodetool command that needs a keyspace. Note that depending on what

Re: How to fetch replication factor of a given keyspace

2017-12-20 Thread Nate McCall
I think you want: Schema.instance.getKeyspaceMetadata There is a ReplicationParams nested under there which should have everything you need fully populated. On Thu, Dec 21, 2017 at 2:02 PM, Tyagi, Preetika wrote: > Hi, > > If I need to get the replication factor of a given keyspace in nodetool

How to fetch replication factor of a given keyspace

2017-12-20 Thread Tyagi, Preetika
Hi, If I need to get the replication factor of a given keyspace in nodetool commands (e.g. status), how can I do that? I'm trying to figure it out for a JIRA item I'm working on. I tried using the below: Keyspace keyspace = Keyspace.open(keyspaceName); Int rf = keyspace.getReplicationStrategy()

Reviewer for CASSANDRA-14055

2017-12-20 Thread Oleksandr Petrov
Hi everyone, I still couldn't find enough time to review the https://issues.apache.org/jira/browse/CASSANDRA-14055 for which I'm deeply sorry. It's a SASI issue related to index redistribution. Unfortunately, this week doesn't look very promising in terms of time as well, so I'm making a call for