Re: calcite+graal native-image

2022-08-02 Thread Jacques Nadeau
I definitely suggest that you look at how Substrait compiles. There are a number of customizations on top of vanilla Calcite that are done. Key things to observe include: * Configuration of runtime/compile time classes at build. [1] * Registration of addition reflection, etc items [2] * Use of prox

Re: PR Review Request

2022-06-21 Thread Jacques Nadeau
Martijn, thanks for sharing that thread in the Flink community. I'm someone who has forked Calcite twice: once in Apache Drill and again in Dremio. In both cases, it was all about trading short term benefits against long term costs. In both cases, I think the net amount of work was probably 5x as

Re: [QUESTION] Window functions and Relational Operator Tree

2022-04-23 Thread Jacques Nadeau
As you think about this, I might suggest trying to use Substrait as an intermediate serialized representation between ZetaSQL and Calcite. We have already done some work on Substrait <=> Calcite [1] and are hoping some work can be done to add support for ZetaSQL => Substrait [2]. The benefit here i

Re: [DISCUSS] Parser with involved tables

2022-04-13 Thread Jacques Nadeau
You need to complete validation in order to confirm that all tables are real. For example, validation includes clarifying ambiguities (since users can rely on implicit resolution but rel trees cannot). For #2: this is a really hard thing to do with Calcite. We did this in Apache Drill by basically

Re: Changes to the rule pattern interface

2022-04-13 Thread Jacques Nadeau
Vladimir, It's always good to ask these kinds of questions. e.g. "Is progress really progress?" I think moving to a configuration object was a substantial improvement. Until Java has default parameters and named parameters, I don't know of another good way to make rules sufficiently configurable

Re: [DISCUSS] Rename 'master' branch to 'main' (part 2)

2022-04-13 Thread Jacques Nadeau
+1 on moving this forward. Thanks for bringing it up again. On Wed, Apr 13, 2022 at 3:52 AM Stamatis Zampetakis wrote: > +1 > > Indeed the process seems to be rather easy with GitHub. I assume the > changes will be propagated automatically to the Gitbox repo as well. > > Stamatis > > On Tue, Apr

Re: How to handle the fact that different databases have different ideas of what a "db"/"schema" are?

2022-01-31 Thread Jacques Nadeau
If I recall correctly, my experience is you have to code per underlying database. I believe there are only a few patterns but I don't think there is sufficient odbc/jdbc info to answer behavior reliably (or at least in a way that feels correct/native to each database). For example, I believe some d

Re: Using Calcite with Python

2022-01-31 Thread Jacques Nadeau
A couple of related (possibly useful?) pointers here: - Dask-sql [1] uses Calcite in a python context. Might be some good stuff to leverage there. - I'm working on compiling Calcite as a GraalVM shared native library [2] as part of Substrait [3] with the goal of ultimately having a fri

Re: [DISCUSS] Refactoring tests

2022-01-25 Thread Jacques Nadeau
t;> > >> > https://github.com/julianhyde/calcite/blob/4885-test-fixtures/summary-of-calcite-4885.md > >> < > >> > https://github.com/julianhyde/calcite/blob/4885-test-fixtures/summary-of-calcite-4885.md > > > >> > >> > >> Julian >

Re: [ANNOUNCE] New Calcite PMC chair: Ruben Q L

2022-01-19 Thread Jacques Nadeau
Ditto, thanks Haisheng and congrats Ruben! On Wed, Jan 19, 2022, 6:35 PM Julian Hyde wrote: > Congratulations, Ruben, and good luck! > > Haisheng, Thank you for serving as Chair. > > Julian > > On Wed, Jan 19, 2022 at 6:29 PM Haisheng Yuan wrote: > > > > Calcite community members, > > > > I am

Re: [DISCUSS] Refactoring tests

2022-01-19 Thread Jacques Nadeau
Unfortunately, the last minute attendance of the meetup today threw my schedule off and I won't be able to look at this for at least a few days. Don't feel obligated to hold up for me. On Wed, Jan 19, 2022, 9:04 AM Jacques Nadeau wrote: > FYI, I'm trying to do a thorough rev

Re: [DISCUSS] Apache Calcite Online Meetup January 2022

2022-01-19 Thread Jacques Nadeau
missed the meetup. > > > On Jan 19, 2022, at 9:08 AM, Jacques Nadeau wrote: > > > > Shoot, totally missed that this was using meetup.com. Figured the > date/time > > would be discussed here. In the future would be helpful to also mention > > time/date on the mailin

Re: Projection for SELECT COUNT(*)

2022-01-19 Thread Jacques Nadeau
I think Viliam's complaint is that the fields aren't being trimmed from the scan. I don't remember the details but my question is whether this code is running [1] And whether it is behaving as expected. I assume you've enabled trim fields [2] on SqlToRel? [1] https://github.com/apache/calcite/bl

Re: [DISCUSS] Apache Calcite Online Meetup January 2022

2022-01-19 Thread Jacques Nadeau
Shoot, totally missed that this was using meetup.com. Figured the date/time would be discussed here. In the future would be helpful to also mention time/date on the mailing list. On Wed, Jan 19, 2022, 8:43 AM Stamatis Zampetakis wrote: > Forgo the link to the event: > https://www.meetup.com/Apac

Re: [DISCUSS] Refactoring tests

2022-01-19 Thread Jacques Nadeau
FYI, I'm trying to do a thorough review today (as much as possible with patch this size). On Wed, Jan 19, 2022, 4:36 AM Michael Mior wrote: > Thanks for doing this Julian! I haven't been able to do a detailed review, > but from my skim of the PR, this looks like a nice improvement. I think > it'

Re: Why should invalidate all of the caches of HANDLERS when adding a new RelNode class in JaninoRelMetadataProvider.revise() method?

2022-01-16 Thread Jacques Nadeau
rovider.revise()" method. > So I'd like to know the reason why invalidate all of the caches of HANDLERS > when adding a new RelNode class to ALL_RELS. > > Jacques Nadeau 于2022年1月16日周日 02:04写道: > > > I should you produce a test case that represents the specific concern

Re: Why should invalidate all of the caches of HANDLERS when adding a new RelNode class in JaninoRelMetadataProvider.revise() method?

2022-01-15 Thread Jacques Nadeau
I should you produce a test case that represents the specific concern you have as opposed to proposing a snippet of code. I'm not sure what you propose is necessary. I think their is implicit expected logic that a revise should only influence an exception outcome, not a value outcome. Only value ou

Re: [DISCUSS] Writing good summaries for Jira cases

2022-01-14 Thread Jacques Nadeau
> > Under the current process, the Jira subject becomes the commit message I didn't know this was perceived as a "rule" and I don't follow it (oops?). I also don't agree with it being a good idea. I typically put substantially more information in a commit message than a jira subject. A commit mes

Re: [DISCUSS] Writing good summaries for Jira cases

2022-01-14 Thread Jacques Nadeau
I don't think we should have any rules about summaries. Per Vladimir Ozerov comments, being militant about something that is relatively subjective is a good way to dissuade high quality contribution. I definitely find that rules around such minor things distract from high quality discussion around

Re: Apache Calcite - Understanding RelNode vs RexNode

2022-01-12 Thread Jacques Nadeau
RexNode => Works on one record (aka a row expression) RelNode => Works on a set of records (aka a relational expression) For example: A sort reorders a number of records. As such it is a RelNode (it works on many records) Adding two numbers (e.g. 4+6) is a RexNode, it works on each record independ

Re: Parsing ALTER TABLE Statements

2022-01-06 Thread Jacques Nadeau
I believe this is a feature that is off by default. Try creating your parser with an alternative parser factory. I think it is something like this: SqlParser.Config.DEFAULT.withParserFactory(SqlDdlParserImpl.FACTORY) On Thu, Jan 6, 2022 at 6:10 AM Yogendra Sharma wrote: > Wondering why does cal

Re: StackOverflowError in HepPlanner

2022-01-05 Thread Jacques Nadeau
Stackoverflow typically means one of two things: infinite planning or very deep trees being created that go beyond stack height. It's important to remember that this is a relatively arbitrary magic threshold so small non-functional changes can potentially influence whether you hit this condition or

Re: [DISCUSS] SBOM (Software Bill of Materials)

2021-12-29 Thread Jacques Nadeau
WRT SBOM (Julian): My general experience is that most large orgs use scanners now (either open or closed) and they will scan whether you have a bill of materials or not. I wouldn't worry about adding something additional. WRT too many dependencies (Gunnar): I completely agree with the general feel

Re: [ANNOUNCE] Apache Calcite 1.29.0 released

2021-12-27 Thread Jacques Nadeau
This is great news! Thanks Rui for being RM. Thanks Julian for helping teach/facilitate the process. On Mon, Dec 27, 2021 at 11:55 AM Stamatis Zampetakis wrote: > Many thanks for being the RM Rui! > > I will update the site with Julian's changes shorthly. > > Best, > Stamatis > > On Mon, Dec 27,

Re: Hope to be a contributer in Calcite

2021-12-27 Thread Jacques Nadeau
I've added you. Let me know if it doesn't work. Glad to have you as part of the project. On Mon, Dec 27, 2021 at 8:54 AM 刘骏 wrote: > Hi Calcite Followers, > I am working on Calcite recently with Xiong Duan (Jira) and Zhe > Hu(Jira) , who have already made some contributions to Calcite. >

Re: [DISCUSS] Trolls and community

2021-12-22 Thread Jacques Nadeau
This is a hard message to respond to. Hopefully my comments will reduce the friction for others to share their own observations. Something that I will reiterate here is that Julian posted this on a public forum which is a request to not only get feedback from committers and PMC members but the comm

Re: Clean up Metadata type boiler plate and removing generic from MetadataHandler

2021-12-22 Thread Jacques Nadeau
Hi James, I think it is great that you are pushing this effort forward. I have a few requests: - Can we have detailed discussions around code, etc on Jira instead of the ml? It's really hard to read here and also tends to get lost over time. - If we think we need to make one or more breaking chang

Re: Acquiring original SQL identifier from RexInputRef

2021-12-21 Thread Jacques Nadeau
If I understand your situation correctly, I would typically model this as a rule in Calcite that pushes partial predicates (whatever is supported in the underlying library) directly into the table scan operator. At that point, the references are directly related to the original table schema (and th

Re: Introduction and picking an issue

2021-12-20 Thread Jacques Nadeau
Hey Abhishek, welcome! Happy to have you as part of the community. I think it would be great for you to pick this issue. Can you share your jira username so we can assign the case to you? Thanks, Jacques On Mon, Dec 20, 2021 at 9:17 AM Abhishek Dasgupta < abhishekdasgupta...@gmail.com> wrote:

[jira] [Created] (CALCITE-4952) Enable use of RelMetadataQuery using a simplistic & slow proxy path

2021-12-18 Thread Jacques Nadeau (Jira)
Jacques Nadeau created CALCITE-4952: --- Summary: Enable use of RelMetadataQuery using a simplistic & slow proxy path Key: CALCITE-4952 URL: https://issues.apache.org/jira/browse/CALCITE-4952 Pro

Re: [Calcite Release] Preparing for 1.29.0 Release

2021-12-17 Thread Jacques Nadeau
I've merged CALCITE-4948 to mitigate the concerns around CALCITE-4898 and maven repositories and category x licenses. On Fri, Dec 17, 2021 at 1:02 PM Rui Wang wrote: > For the list of 1.29 fix Jira, several Jira have been marked as resolved > since this Monday. I will do another pass today but p

[jira] [Created] (CALCITE-4949) Evaluate if org.codelibs.elasticsearch.module:lang-painless is an appropriate dependency

2021-12-17 Thread Jacques Nadeau (Jira)
Jacques Nadeau created CALCITE-4949: --- Summary: Evaluate if org.codelibs.elasticsearch.module:lang-painless is an appropriate dependency Key: CALCITE-4949 URL: https://issues.apache.org/jira/browse/CALCITE-4949

[jira] [Created] (CALCITE-4948) Revert Elasticsearch to 7.10.2 to avoid extra repo and category x license

2021-12-17 Thread Jacques Nadeau (Jira)
Jacques Nadeau created CALCITE-4948: --- Summary: Revert Elasticsearch to 7.10.2 to avoid extra repo and category x license Key: CALCITE-4948 URL: https://issues.apache.org/jira/browse/CALCITE-4948

Re: Build failed in Jenkins: Calcite » Calcite-snapshots #13

2021-12-14 Thread Jacques Nadeau
FYI, This appears to be the job that Vladimir implemented on Jenkins, not the pr I implemented on Github actions. I haven't looked how this is configured and what will trigger emails. I'm also curious if these are real failures or infra problems. I would be pretty surprised if we broke master twic

Re: JIRA perm issues?

2021-12-13 Thread Jacques Nadeau
u log in? > > > Best, > Chunwei > > > On Tue, Dec 14, 2021 at 8:17 AM Jacques Nadeau wrote: > > > Hey all, I am no longer able to resolve things in jira (across multiple > > projects). Are others seeing the same thing? The buttons are just gone > and > &g

Re: Automatic maven snapshot releases

2021-12-13 Thread Jacques Nadeau
Josh, I've enabled the basic integration tests in my updated patch: https://github.com/apache/calcite/runs/4513702440?check_suite_focus=true LMK if you think that is sufficient. Thanks On Mon, Dec 13, 2021 at 4:05 PM Jacques Nadeau wrote: > I added a blurb about snapshot releases in t

JIRA perm issues?

2021-12-13 Thread Jacques Nadeau
Hey all, I am no longer able to resolve things in jira (across multiple projects). Are others seeing the same thing? The buttons are just gone and most fields are no longer editable. thanks, Jacques

Re: Automatic maven snapshot releases

2021-12-13 Thread Jacques Nadeau
; your CI against snapshots, but remember that if they fail, there are > now TWO places to look for the failure.) > > Julian > > > On Sun, Dec 12, 2021 at 4:11 PM Jacques Nadeau wrote: > > > > Good questions, Julian. > > > > Some thoughts, in random order.

Re: [RESULT] [VOTE] Release apache-calcite-avatica-1.20.0 (release candidate 0) (second vote)

2021-12-13 Thread Jacques Nadeau
Thanks for sheparding this through Julian On Mon, Dec 13, 2021, 11:52 AM Julian Hyde wrote: > Thanks to everyone who has tested the release candidate and given > their comments and votes. > > A special thank you to all of you who worked over the weekend on this, > fixing bugs, making release can

Re: Automatic maven snapshot releases

2021-12-13 Thread Jacques Nadeau
t; test suite which can reliably run against master > before the new job would run. I know folks have been chasing this for > some time. > > On 12/12/21 1:23 PM, Jacques Nadeau wrote: > > Hey All, > > > > I've been wanting to do more testing against master for int

Re: Druid test hangs?

2021-12-13 Thread Jacques Nadeau
with a thread printing stack traces > of other threads at some intervals. > > Best, > Stamatis > > On Sun, Dec 12, 2021 at 7:00 PM Jacques Nadeau wrote: > > > It could be infra but I'm wondering if it is some kind of concurrency > bug. > > > > Anyone k

Re: Automatic maven snapshot releases

2021-12-13 Thread Jacques Nadeau
Let's keep the "should" conversation separate from the "how" conversation. *On should: * I understand that it worked in the past and then stopped working. I still think it is appropriate to confirm people are comfortable with enabling it again. *On how:* Vladimir, the github workflow job is confi

Re: [VOTE] Release apache-calcite-avatica-1.20.0 (release candidate 0) (second vote)

2021-12-12 Thread Jacques Nadeau
+1 (binding). RC0 looks good to me (built/tested/verified) and I agree that CALCITE-4935 is not a release blocker. On Sun, Dec 12, 2021 at 6:45 PM Julian Hyde wrote: > Hi all, > > Yesterday I started a vote for Apache Calcite Avatica 1.20.0, release > candidate 0, and then canceled it due to CA

Re: Automatic maven snapshot releases

2021-12-12 Thread Jacques Nadeau
releases. > > Is the additional convenience worth these downsides? Just asking. I’m > prepared to be persuaded. > > Julian > > > > > On Dec 12, 2021, at 10:23 AM, Jacques Nadeau wrote: > > > > Hey All, > > > > I've been wanting to do more

Automatic maven snapshot releases

2021-12-12 Thread Jacques Nadeau
Hey All, I've been wanting to do more testing against master for integration purposes and right now that requires private builds. As such, I opened CALCITE-4934 [1] to add support for automatic snapshot builds deployed to the Apache snapshot Maven repository on master merges. As noted in the ticke

Re: Druid test hangs?

2021-12-12 Thread Jacques Nadeau
mail.com> wrote: > I started noticing that intermittently around a month ago, I had a quick > look back then but I could not pinpoint the root cause. > > I don't think it is expected, and I guess it comes from test infra setup > rather than the Calcite code itself. > &

Re: how to represent and optimize a query over partitioned storage

2021-12-12 Thread Jacques Nadeau
the > estimation of predicate selectivity over the partitioning expression maybe? > > Il Dom 12 Dic 2021, 05:48 Jacques Nadeau ha scritto: > > > What we have done in the past is push filters into a scan and alter the > > costing (and estimated row count). In cases where the

Re: how to represent and optimize a query over partitioned storage

2021-12-11 Thread Jacques Nadeau
What we have done in the past is push filters into a scan and alter the costing (and estimated row count). In cases where the filter or portions of the filter can be applied against partitioning columns, you prune partitions and use a new row count estimate/cost estimate based on the reduced partit

Druid test hangs?

2021-12-11 Thread Jacques Nadeau
I see a couple of recent builds with Druid tests hanging. Is that a normal thing or something that has started recently. Examples: https://github.com/apache/calcite/runs/4487013505?check_suite_focus=true https://github.com/jacques-n/calcite/runs/4494836558?check_suite_focus=true

Re: [VOTE] Release apache-calcite-avatica-1.20.0 (release candidate 0)

2021-12-11 Thread Jacques Nadeau
+1 (binding) Checked sig, checksum. Built and tested on macos/jdk8b302/gradle6.8.1. Thanks for being RM Julian. On Sat, Dec 11, 2021 at 1:30 PM Francis Chuang wrote: > Thanks for being RM, Julian! > > My vote is: +1 > > - Verified GPG signature - OK > - Verified SHA512 - OK > - Checked release

[jira] [Created] (CALCITE-4934) Deploy snapshot releases to Apache snapshot repo

2021-12-11 Thread Jacques Nadeau (Jira)
Jacques Nadeau created CALCITE-4934: --- Summary: Deploy snapshot releases to Apache snapshot repo Key: CALCITE-4934 URL: https://issues.apache.org/jira/browse/CALCITE-4934 Project: Calcite

Re: [DISCUSS] Do we need a Avatica release before Calcite 1.29.0 release?

2021-12-10 Thread Jacques Nadeau
Given the conversation around the log4j cve, it seems like we may need an Avatica release afterall... Let's see how that discussion resolves. On Thu, Dec 9, 2021 at 12:47 PM Rui Wang wrote: > Ack thanks! > > If there is no objection until the end of this week I will just go for the > 1.29.0 rel

[jira] [Created] (CALCITE-4929) Add default methods for getDef on metadata handlers

2021-12-09 Thread Jacques Nadeau (Jira)
Jacques Nadeau created CALCITE-4929: --- Summary: Add default methods for getDef on metadata handlers Key: CALCITE-4929 URL: https://issues.apache.org/jira/browse/CALCITE-4929 Project: Calcite

Re: Feedback on a generic return type version of RelShuttle?

2021-12-09 Thread Jacques Nadeau
Stamatis et al, any additional feedback on desired features for such a change? Thanks, Jacques On Mon, Dec 6, 2021 at 11:48 AM Julian Hyde wrote: > > > > On Dec 4, 2021, at 9:41 PM, Jacques Nadeau wrote: > > > > A few thoughts: > > > > Algebra approach. &

[jira] [Created] (CALCITE-4928) Decouple Janino from RelMetadataQuery

2021-12-09 Thread Jacques Nadeau (Jira)
Jacques Nadeau created CALCITE-4928: --- Summary: Decouple Janino from RelMetadataQuery Key: CALCITE-4928 URL: https://issues.apache.org/jira/browse/CALCITE-4928 Project: Calcite Issue Type

Re: Feedback on a generic return type version of RelShuttle?

2021-12-04 Thread Jacques Nadeau
low a visitor pattern(aka > > walking the tree) and fixing that could be a breaking change. I would > > prefer if the tree traversal and the dispatch was independent of the > > RelNode implementation. This would help with loose coupling so we do not > > have email thre

Re: calcite-core 1.28.0 now depends on kotlin-stdlib?

2021-12-03 Thread Jacques Nadeau
; On Tue, Nov 30, 2021 at 1:26 PM Stamatis Zampetakis > > wrote: > > > >> It seems that Vladimir fixed this already in [1]. > >> > >> [1] > >> > >> > https://github.com/apache/calcite/commit/f3e2f041567e35e65464676d3171db3b5f2ddf9c > >>

Re: Feedback on a generic return type version of RelShuttle?

2021-12-03 Thread Jacques Nadeau
I think this thread has forked into two distinct topics: 1. A general discussion of the utility of visitors 2. Support for generic return type for RelShuttle (the original purpose of the thread) My quick thoughts on #1: I've historically used the visitors in Calcite extensively (externa

Re: [DISCUSS] Writing rules in dependent projects without depending on Immutables

2021-12-02 Thread Jacques Nadeau
Hey Julian, To me, there are currently three avenues I envisioned for extension project use: 1. Use the Immutable project or similar alternatives (e.g. [1]) 2. Write a concrete class that implements the declared interface. 3. Use a record metaphor appropriate to the environment you're in that impl

Feedback on a generic return type version of RelShuttle?

2021-12-01 Thread Jacques Nadeau
Right now, RelNode's accept method and RelShuttle forces a user to return RelNodes. This makes tree traversal/conversion extra painful in main circumstances (you want to have more specific relnode classes explicit, you want to rewrite to non-relnodes, etc). I've worked around this for many years bu

Re: [DISCUSS] JIRA vs GitHub Issues

2021-12-01 Thread Jacques Nadeau
I'm generally -0.47 on this. This seems to solve a problem that doesn't exist (or at least isn't pressing). Calcite contribution speed is very helpful. Don't get me wrong, I hate jira as much as anyone. Nonetheless, process change takes time in both the direct costs (migration/workflow disruption/

[jira] [Created] (CALCITE-4914) Prep existing interfaces to support making RelMetadataQuery abstract

2021-12-01 Thread Jacques Nadeau (Jira)
Jacques Nadeau created CALCITE-4914: --- Summary: Prep existing interfaces to support making RelMetadataQuery abstract Key: CALCITE-4914 URL: https://issues.apache.org/jira/browse/CALCITE-4914 Project

Re: calcite-core 1.28.0 now depends on kotlin-stdlib?

2021-11-30 Thread Jacques Nadeau
thub.com/apache/calcite/commit/f3e2f041567e35e65464676d3171db3b5f2ddf9c > > On Tue, Nov 30, 2021 at 7:50 PM Jacques Nadeau wrote: > > > Can you file a JIRA? We should address before 1.29. > > > > On Tue, Nov 30, 2021 at 6:40 AM Zoltan Farkas > > > > > wrote

Re: calcite-core 1.28.0 now depends on kotlin-stdlib?

2021-11-30 Thread Jacques Nadeau
Can you file a JIRA? We should address before 1.29. On Tue, Nov 30, 2021 at 6:40 AM Zoltan Farkas wrote: > According to the published pom it is a direct dependency: > https://repo1.maven.org/maven2/org/apache/calcite/calcite-core/1.28.0/calcite-core-1.28.0.pom > < > https://repo1.maven.org/maven

Re: calcite-core 1.28.0 now depends on kotlin-stdlib?

2021-11-29 Thread Jacques Nadeau
Hopefully I didn't introduce this when doing the immutables work... I don't think I did. But I'm also weak on gradle... On Mon, Nov 29, 2021, 6:23 PM Julian Hyde wrote: > This is a surprise to me too. Vladimir? > > > On Nov 29, 2021, at 4:45 PM, Zoltan Farkas > wrote: > > > > I see that the lat

Re: ProjectRemoveRule replaces project with its input ignoring alias

2021-11-26 Thread Jacques Nadeau
> > Yes, I'm referring to the RelNode's row type, the planBefore and > planAfter's row types are different in field name. > You cannot rely on field names from individual RelNodes. It's just the way Calcite was designed. I'm trying to convert the optimized RelNodes tree to a sql with same > seman

Re: ProjectRemoveRule replaces project with its input ignoring alias

2021-11-25 Thread Jacques Nadeau
+ "select name, deptno from dept\n" > + ") aa\n"; > sql(sql) > .withRule(CoreRules.PROJECT_SET_OP_TRANSPOSE, > CoreRules.PROJECT_REMOVE, > CoreRules.UNION_MERGE) > .check(); > } > > The result plan

Re: ProjectRemoveRule replaces project with its input ignoring alias

2021-11-24 Thread Jacques Nadeau
Are you looking at the RelRoot's field names or the field names of the RelNodes in the plan? The names of the fields in RelNodes are semantically meaningless in Calcite's eyes (rule semantics are based on ordinal position, not field name). The validated row type (and correct field names) may only e

Re: Re: [DISCUSS] Apache Calcite Online Meetup January 2022

2021-11-23 Thread Jacques Nadeau
年11月22日周一 下午10:50写道: > > > > > > > >> +1 for online meetup. > > > >> And I’m curious about if there is any playback for this meetup, > because > > > >> somebody might couldn't attend due to timezone variety or any other > > &g

Re: [DISCUSS] Apache Calcite Online Meetup January 2022

2021-11-19 Thread Jacques Nadeau
WRT to talk structure, I propose we do 5 or 10 minute lightning talks as opposed to something longer. It ensures a wider variety of topics, better attendance and you never have to sit that long through something you're not interested in... On Thu, Nov 18, 2021 at 11:47 PM Vladimir Sitnikov < sitni

Re: DISCUSS: merge calcite-avatica and calcite repositories

2021-11-17 Thread Jacques Nadeau
Vladimir, I proposed a straw poll to try to move this thread from a shouting match to a productive conversation. Straw polls are an imperfect mechanism but can sometimes be helpful. It's too bad you didn't find it helpful. I did and I hope others did. > Suppose PR verification passes. > Suppose

Re: [DISCUSS] Apache Calcite Online Meetup January 2022

2021-11-17 Thread Jacques Nadeau
Great idea. +1 from me. On Wed, Nov 17, 2021 at 8:22 AM Stamatis Zampetakis wrote: > Hi all, > > Last meetup [1] was roughly 10 months ago. How about organising another one > around mid January 2022? > > Organising an in-person event would be nice but I think it is still a bit > complicated so I

Re: [DISCUSS] Refactoring tests

2021-11-16 Thread Jacques Nadeau
I think it is a great idea to make the tests more accessible. A few comments to consider in your work (no response expected): - I would vote to try to minimize the use of non-interface class inheritance , especially in downstream cases. For example, I would avoid a dominant path using bas

Re: DISCUSS: merge calcite-avatica and calcite repositories

2021-11-16 Thread Jacques Nadeau
We've had 7 responses so far on the straw poll. For a reminder, results are here: https://docs.google.com/spreadsheets/d/1EXhrRkYp2owGAK2e3bBw1bEvNj5O3V22iTqndBAuyG8/edit?usp=sharing My high level observations: - There isn't a lot of agreement on most questions :D. - 70% of people preferre

Re: DISCUSS: merge calcite-avatica and calcite repositories

2021-11-10 Thread Jacques Nadeau
I'm finding it difficult to make sense of all the responses on this thread. I put up a quick straw poll that will hopefully try to give us a better sense of where people's heads are at. I think the thread outlines a number of concerns for both outcomes. I'd ask people to read the thread and then sh

[jira] [Created] (CALCITE-4882) Explore a LambdaMetadataFactory alternative to Janino for metadata retrieval

2021-11-09 Thread Jacques Nadeau (Jira)
Jacques Nadeau created CALCITE-4882: --- Summary: Explore a LambdaMetadataFactory alternative to Janino for metadata retrieval Key: CALCITE-4882 URL: https://issues.apache.org/jira/browse/CALCITE-4882

Re: DISCUSS: merge calcite-avatica and calcite repositories

2021-11-08 Thread Jacques Nadeau
Can you confirm that Calcite is building against both avatica latest release and avatica master (this seems to be the case based on an avatica merge breaking calcite ci)? If we truly want to treat the projects as separate, I would suggest that Calcite only be built against released avatica artifact

[jira] [Created] (CALCITE-4879) Make RelMedataQuery abstract

2021-11-05 Thread Jacques Nadeau (Jira)
Jacques Nadeau created CALCITE-4879: --- Summary: Make RelMedataQuery abstract Key: CALCITE-4879 URL: https://issues.apache.org/jira/browse/CALCITE-4879 Project: Calcite Issue Type

Re: Proposal: Better abstraction/encapsulation for RelMetadataQuery

2021-10-28 Thread Jacques Nadeau
projects > to extend classes that exposed internal implementation and require them to > change their code. > > James > > [1] > https://github.com/apache/calcite/pull/2378 > [2] > > core/src/main/java/org/apache/calcite/rel/metadata/JaninoMetadataHandlerProvider.java &

Proposal: Better abstraction/encapsulation for RelMetadataQuery

2021-10-27 Thread Jacques Nadeau
Hey all, I've been working on AOT compilation with Graal (Janino not usable) and I'm struggling with the hierarchy of classes related to RelMetadataQuery. Right now it feels like there is tight coupling between how the JaninoRelMetadataProvider works and RelMetdataQuery. In a perfect world, it see

Re: [VOTE] Release Apache Calcite 1.28.0 (release candidate 0)

2021-10-17 Thread Jacques Nadeau
+1 (binding). Checked signature, checksum. Built with success (other than a couple ES tests that always fail on my machine). Also downloaded the core jar file from maven and compared with the locally built one and confirmed they are consistent. On Fri, Oct 15, 2021 at 11:51 AM Julian Hyde wr

Re: [VOTE] Release apache-calcite-avatica-1.19.0 (release candidate 0)

2021-10-07 Thread Jacques Nadeau
+1 (binding). Thanks for putting this together. Validated keys, that gradle-wrapper is excluded, built and tested on macos big sur. Worked with JDK8u302. Two issues I found: - Failed with JDK17 with a nonsensical gradle stacktrace. Guessing that isn't supported despite docs saying java8+? We shou

[jira] [Created] (CALCITE-4840) Readme from source release clearly state how to build

2021-10-07 Thread Jacques Nadeau (Jira)
Jacques Nadeau created CALCITE-4840: --- Summary: Readme from source release clearly state how to build Key: CALCITE-4840 URL: https://issues.apache.org/jira/browse/CALCITE-4840 Project: Calcite

Re: [DISCUSS] Next releases

2021-10-07 Thread Jacques Nadeau
I merged the last patch and have linked the release ticket to a release note gist for the changes. Thanks. On Wed, Oct 6, 2021, 10:21 PM Jacques Nadeau wrote: > FYI, the last patch for immutables is up and passing all checks. I'll do > another pass in the morning to make sure every

[jira] [Created] (CALCITE-4839) Remove remnants of ImmutableBeans post 1.28 release

2021-10-07 Thread Jacques Nadeau (Jira)
Jacques Nadeau created CALCITE-4839: --- Summary: Remove remnants of ImmutableBeans post 1.28 release Key: CALCITE-4839 URL: https://issues.apache.org/jira/browse/CALCITE-4839 Project: Calcite

Re: [DISCUSS] Next releases

2021-10-06 Thread Jacques Nadeau
FYI, the last patch for immutables is up and passing all checks. I'll do another pass in the morning to make sure everything looks good and then will merge if I don't hear any concerns. https://github.com/apache/calcite/pull/2568 On Wed, Oct 6, 2021, 1:04 PM Jacques Nadeau wrote: &g

Re: [DISCUSS] Next releases

2021-10-06 Thread Jacques Nadeau
their > own rules. > > > > On Oct 6, 2021, at 12:59 PM, Jacques Nadeau wrote: > > > > I'm hoping (fingers crossed) to have the final Immutables patch up today > > and if all goes well, get that merged before the release. > > > > On Wed, Oct 6, 2

Re: [DISCUSS] Next releases

2021-10-06 Thread Jacques Nadeau
I'm hoping (fingers crossed) to have the final Immutables patch up today and if all goes well, get that merged before the release. On Wed, Oct 6, 2021 at 11:34 AM Julian Hyde wrote: > So, the vote for Avatica 1.19 is underway, and we will likely have a > release in 4 or 5 days. > > Next up, Calc

Lots of warnings with latest gradle?

2021-10-05 Thread Jacques Nadeau
Hey all, Calcite master has the latest gradle in it now. It seems like I'm seeing a lot of warnings like: https://gist.github.com/jacques-n/910b917f52cbf8dda22b2749ef0ea6b6 Are others seeing that as well? Do we have a ticket to address (quick search didn't find one)? It makes it much harder to se

[jira] [Created] (CALCITE-4831) Cleanup Nullable rule annotations post fix for Immutables checker conflict bug

2021-10-05 Thread Jacques Nadeau (Jira)
Jacques Nadeau created CALCITE-4831: --- Summary: Cleanup Nullable rule annotations post fix for Immutables checker conflict bug Key: CALCITE-4831 URL: https://issues.apache.org/jira/browse/CALCITE-4831

[jira] [Created] (CALCITE-4830) Move Cassandra module to use Immutables instead of ImmutableBeans

2021-10-05 Thread Jacques Nadeau (Jira)
Jacques Nadeau created CALCITE-4830: --- Summary: Move Cassandra module to use Immutables instead of ImmutableBeans Key: CALCITE-4830 URL: https://issues.apache.org/jira/browse/CALCITE-4830 Project

[jira] [Created] (CALCITE-4827) Refactor annotation processor tasks to be used across multiple modules

2021-10-04 Thread Jacques Nadeau (Jira)
Jacques Nadeau created CALCITE-4827: --- Summary: Refactor annotation processor tasks to be used across multiple modules Key: CALCITE-4827 URL: https://issues.apache.org/jira/browse/CALCITE-4827

[jira] [Created] (CALCITE-4826) Fix Intellij annotation processing failure post CALCITE-4787

2021-10-04 Thread Jacques Nadeau (Jira)
Jacques Nadeau created CALCITE-4826: --- Summary: Fix Intellij annotation processing failure post CALCITE-4787 Key: CALCITE-4826 URL: https://issues.apache.org/jira/browse/CALCITE-4826 Project

[jira] [Created] (CALCITE-4825) Update enumerables rules to use immutables instead of ImmutableBeans.EMPTY

2021-10-04 Thread Jacques Nadeau (Jira)
Jacques Nadeau created CALCITE-4825: --- Summary: Update enumerables rules to use immutables instead of ImmutableBeans.EMPTY Key: CALCITE-4825 URL: https://issues.apache.org/jira/browse/CALCITE-4825

Re: Substrait, a new project focused on serialized algebra

2021-10-03 Thread Jacques Nadeau
Hey Andrew, Sorry for the late reply. For some reason, your email never came through to me and I didn't know about it until someone just referenced it within the apache mail archive. I'll respond to your questions inline. In general, we're experimenting with the GitHub discussions functionality as

Re: [DISCUSS] Remove contributors name from commit summary

2021-09-23 Thread Jacques Nadeau
I lead towards allowing people to use github if they want to know who contributed what. Simple is better. On Thu, Sep 23, 2021 at 11:25 AM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > I incline to "The following people contributed to this release" > For instance, I like the way Gradl

Re: [DISCUSS] Changing from ImmutableBeans to Immutables

2021-09-22 Thread Jacques Nadeau
either of those items. Also, Julian pointed out that my rule example was slightly misleading and a larger change than necessary. I made a new diff to show smaller example rule change: https://www.diffchecker.com/Ba5a0agP On Tue, Sep 21, 2021 at 5:47 PM Jacques Nadeau wrote: > In the or

[DISCUSS] Changing from ImmutableBeans to Immutables

2021-09-21 Thread Jacques Nadeau
In the original creation of ImmutableBeans [1], there was a discussion of using Immutables instead of something custom to do the configuration pojos. Because no one did the work of integrating one of those off the shelf packages at the time, we just went forward with the custom ImmutableBeans. When

Re: Tableau dialect specification for Calcite

2021-09-20 Thread Jacques Nadeau
I wonder if the Dremio connector would be a good place to start since it uses Calcite: https://github.com/dremio-hub/tableau-connector On Fri, Sep 10, 2021 at 12:37 PM Julian Hyde wrote: > Tableau has a text file [1] where you can define your dialect. It lets > Tableau know how to generate SQL

[jira] [Created] (CALCITE-4787) Evaluate use of Immutables instead of ImmutableBeans

2021-09-19 Thread Jacques Nadeau (Jira)
Jacques Nadeau created CALCITE-4787: --- Summary: Evaluate use of Immutables instead of ImmutableBeans Key: CALCITE-4787 URL: https://issues.apache.org/jira/browse/CALCITE-4787 Project: Calcite

  1   2   >