I could add a basic build & test. Right now it is just a build and publish.
Basic unit test suite seems like it would cover most common cases (where a rebase after pre-commit test causes a problem). Do you think it should be more thorough? Less? On Mon, Dec 13, 2021 at 9:52 AM Josh Elser <[email protected]> wrote: > (top-posting to avoid extending the "how" divergence) > > Looks great and thanks for your care to avoid advertising them as > "releases". > > Only thing I was going to mention was about whether or not there's a > minimally "acceptable" test suite which can reliably run against master > before the new job would run. I know folks have been chasing this for > some time. > > On 12/12/21 1:23 PM, Jacques Nadeau wrote: > > Hey All, > > > > I've been wanting to do more testing against master for integration > > purposes and right now that requires private builds. As such, I opened > > CALCITE-4934 [1] to add support for automatic snapshot builds deployed to > > the Apache snapshot Maven repository on master merges. As noted in the > > ticket, this used to be the case many years ago (CALCITE-351 enabled it). > > The right bits are now enabled in GitHub to make this effortless and I've > > confirmed that this looks like it is working correctly [2][3]. > > > > Before merging I wanted to make sure that people were comfortable with > this > > addition since it changes build infra. The PR is pretty trivial [4] and > > modeled off other Apache projects. > > > > Lastly, note that snapshots are *not* Apache Releases and shouldn't be > > presented as such in docs, etc. > > > > Please raise your hand if you have any concerns. > > > > Thanks, > > Jacques > > > > > > [1] https://issues.apache.org/jira/browse/CALCITE-4934 > > [2] > https://github.com/apache/calcite/runs/4499040456?check_suite_focus=true > > [3] > > > https://repository.apache.org/content/groups/snapshots/org/apache/calcite/calcite-core/1.29.0-SNAPSHOT/ > > [4] https://github.com/apache/calcite/pull/2641 > > >
