Re: [PR] Use butil::ThreadLocal to store keytable (brpc)

2024-07-07 Thread via GitHub
MJY-HUST commented on PR #2645: URL: https://github.com/apache/brpc/pull/2645#issuecomment-2212394912 > 请问下按照这样做了设计之后,有具体的性能测试报告么?能够直观的显示这种改造在特定场景下带来的性能提升 修改前: ![image](https://github.com/apache/brpc/assets/52315061/a768eaf1-c245-4ea6-b618-b0f86bcaaf59) -- This is an automat

Re: [PR] Use butil::ThreadLocal to store keytable (brpc)

2024-07-07 Thread via GitHub
MJY-HUST commented on PR #2645: URL: https://github.com/apache/brpc/pull/2645#issuecomment-2212397182 > 请问下按照这样做了设计之后,有具体的性能测试报告么?能够直观的显示这种改造在特定场景下带来的性能提升 相同的负载下,修改前单链表维护的keytable,锁成为瓶颈。cpu被打满,sy时间占比高; 修改后,解除了锁的瓶颈,cpu利用率降低,QPS提升了一倍。火焰图上和加锁/解锁操作对应的futex_wait\futex_wake耗时部分消失 -- Th

Re: [PR] Use butil::ThreadLocal to store keytable (brpc)

2024-07-07 Thread via GitHub
Huixxi merged PR #2645: URL: https://github.com/apache/brpc/pull/2645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

(brpc) branch master updated (8b9138ac -> 5f991fe6)

2024-07-07 Thread huixxi
This is an automated email from the ASF dual-hosted git repository. huixxi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git from 8b9138ac Merge pull request #2672 from chenBright/fix_local_side add b339a7b5 update add c707aa3a update by co

(brpc) 01/01: Merge pull request #2645 from MJY-HUST/keytable_optimize

2024-07-07 Thread huixxi
This is an automated email from the ASF dual-hosted git repository. huixxi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git commit 5f991fe6d4be1cbff5a913fb909f1aa83a48784a Merge: 8b9138ac efcaba72 Author: HU AuthorDate: Sun Jul 7 20:07:07 2024 +0800

Oncall report from Jul 1st to jul 7th

2024-07-07 Thread Xiguo Hu
Hi, all During the last week 2 issues were closed, 3 issues were commented on, and following 4 PRs were merged and closed: 1. fix bug: switch between stream_rpc and baidu_std #2678 2. Add debug log for Socket health check #2673 3. Fix uninitialized local side of Socket #2672 4. Use butil::ThreadLoc

Re: [PR] Use butil::ThreadLocal to store keytable (brpc)

2024-07-07 Thread via GitHub
chenBright commented on code in PR #2645: URL: https://github.com/apache/brpc/pull/2645#discussion_r1612686703 ## src/bthread/key.cpp: ## @@ -226,14 +267,15 @@ void return_keytable(bthread_keytable_pool_t* pool, KeyTable* kt) { delete kt; return; } -s

Re: [PR] Use butil::ThreadLocal to store keytable (brpc)

2024-07-07 Thread via GitHub
chenBright commented on code in PR #2645: URL: https://github.com/apache/brpc/pull/2645#discussion_r1612586070 ## src/bthread/types.h: ## @@ -83,8 +83,17 @@ inline std::ostream& operator<<(std::ostream& os, bthread_key_t key) { } #endif // __cplusplus +namespace bthread{ +

Re: [I] 线程池的线程回收退时core在brpc (brpc)

2024-07-07 Thread via GitHub
ligangbin117 commented on issue #1606: URL: https://github.com/apache/brpc/issues/1606#issuecomment-2212885281 我在使用jni调用brpc的时候 也遇到了这个问题。 #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51 #1 0x7f259f32ff95 in __GI_abort () at abort.c:79 #2 0x7f259b95

[I] 线程池的线程回收退时core在brpc https://github.com/apache/brpc/issues/1606 (brpc)

2024-07-07 Thread via GitHub
ligangbin117 opened a new issue, #2685: URL: https://github.com/apache/brpc/issues/2685 **Describe the bug (描述bug)** 使用jni加载brpc.so时报pthread_mutex_lock未定义, 使用export LD_PRELOAD=/usr/lib64/libbrpc.so 解决了加载的问题,但java线程在退出时core掉了。 **To Reproduce (复现方法)** 使用jni加载brpc.so 并在java中使用线程

Re: [I] variable.cpp error: ‘StringFlagDestructor’ does not name a type (brpc)

2024-07-07 Thread via GitHub
skyflower commented on issue #2679: URL: https://github.com/apache/brpc/issues/2679#issuecomment-2212953955 ok, I'll try it. Thank you for your help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Fix multi FlatMap scale and size (brpc)

2024-07-07 Thread via GitHub
wwbmmm commented on PR #2669: URL: https://github.com/apache/brpc/pull/2669#issuecomment-2213126321 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m