chenBright commented on code in PR #2645:
URL: https://github.com/apache/brpc/pull/2645#discussion_r1612686703
##########
src/bthread/key.cpp:
##########
@@ -226,14 +267,15 @@ void return_keytable(bthread_keytable_pool_t* pool,
KeyTable* kt) {
delete kt;
return;
}
- std::unique_lock<pthread_mutex_t> mu(pool->mutex);
+ pthread_rwlock_rdlock(&pool->rwlock);
if (pool->destroyed) {
- mu.unlock();
+ pthread_rwlock_unlock(&pool->rwlock);
delete kt;
return;
}
- kt->next = (KeyTable*)pool->free_keytables;
- pool->free_keytables = kt;
+ kt->next = pool->list->get()->keytable;
+ pool->list->get()->keytable = kt;
+ pthread_rwlock_unlock(&pool->rwlock);
Review Comment:
想了一下，应该先不用加这个逻辑吧。放回全局链表，到时候再取，都要加写锁，还会跟操作tls
list有竞争，所以限制啥上限应该没必要。全局链表只保留预先reserve的功能就好了吧。
或者不放回全局链表，而是直接delete。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
