wwbmmm commented on PR #2524:
URL: https://github.com/apache/brpc/pull/2524#issuecomment-1931485963
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
yanglimingcn commented on code in PR #2519:
URL: https://github.com/apache/brpc/pull/2519#discussion_r1482210916
##
src/brpc/global.cpp:
##
@@ -329,6 +334,9 @@ static void GlobalInitializeOrDieImpl() {
// Make GOOGLE_LOG print to comlog device
SetLogHandler(&BaiduStrea
Severity: moderate
Affected versions:
- Apache bRPC 0.9.5 before 1.8.0
Description:
Request smuggling vulnerability in HTTP server in Apache bRPC 0.9.5~1.7.0 on
all platforms allows attacker to smuggle request.
Vulnerability Cause Description:
The http_parser does not comply with the RFC-732
wwbmmm commented on code in PR #2519:
URL: https://github.com/apache/brpc/pull/2519#discussion_r1482380653
##
src/brpc/global.cpp:
##
@@ -329,6 +334,9 @@ static void GlobalInitializeOrDieImpl() {
// Make GOOGLE_LOG print to comlog device
SetLogHandler(&BaiduStreamingLo
yanglimingcn commented on code in PR #2519:
URL: https://github.com/apache/brpc/pull/2519#discussion_r1482419094
##
src/brpc/global.cpp:
##
@@ -329,6 +334,9 @@ static void GlobalInitializeOrDieImpl() {
// Make GOOGLE_LOG print to comlog device
SetLogHandler(&BaiduStrea
yanglimingcn commented on code in PR #2519:
URL: https://github.com/apache/brpc/pull/2519#discussion_r1482420118
##
src/brpc/global.cpp:
##
@@ -329,6 +334,9 @@ static void GlobalInitializeOrDieImpl() {
// Make GOOGLE_LOG print to comlog device
SetLogHandler(&BaiduStrea