yanglimingcn commented on code in PR #2519:
URL: https://github.com/apache/brpc/pull/2519#discussion_r1482419094


##########
src/brpc/global.cpp:
##########
@@ -329,6 +334,9 @@ static void GlobalInitializeOrDieImpl() {
     // Make GOOGLE_LOG print to comlog device
     SetLogHandler(&BaiduStreamingLogHandler);
 
+    // Set bthread create span function
+    bthread_set_create_span_func(CreateBthreadSpan);

Review Comment:
   
我这边使用的话,会通过rpcz_service服务把span信息查询出来,上报到我们的trace服务端,这里加了一个type,但是通过rpcz_service查询其实是感知不到bthread这个类型的,它看上去是server
 span的内容。
   其实我本来不想多加一个类型,但是没有这个类型处理上会不合理。
   不太清楚其他人的使用方式,如果依赖了span.proto确实协议变了。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

Reply via email to