[GitHub] [incubator-brpc] fansehep commented on issue #1894: Remove implementation specific function name of EventDispatcher

2022-10-09 Thread GitBox
fansehep commented on issue #1894: URL: https://github.com/apache/incubator-brpc/issues/1894#issuecomment-1272575919 这里只需改变```AddEpollOut``` 和 ```RemoveEpollOut``` 两个函数即可, ```AddEpollOut``` => ```AddMultiplex``` ```RemoveEpollOut``` => ```RemoveMultiplex``` 这样是否是一个合适的做法呢? --

[GitHub] [incubator-brpc] fansehep opened a new pull request, #1948: change the default EventDispatcher some functions' name

2022-10-09 Thread GitBox
fansehep opened a new pull request, #1948: URL: https://github.com/apache/incubator-brpc/pull/1948 Signed-off-by: fan Issue: https://github.com/apache/incubator-brpc/issues/1894 What i do: change some function name. -- This is an automated message from the Apache Git Service

[GitHub] [incubator-brpc] wwbmmm merged pull request #1942: update rpc_press.md

2022-10-09 Thread GitBox
wwbmmm merged PR #1942: URL: https://github.com/apache/incubator-brpc/pull/1942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apa

[incubator-brpc] branch master updated: fix rpc_press.md (#1942)

2022-10-09 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git The following commit(s) were added to refs/heads/master by this push: new 5fbe3a8c fix rpc_press.md (#1942) 5fbe3a

[GitHub] [incubator-brpc] wwbmmm merged pull request #1939: fix typo in json2pb doc

2022-10-09 Thread GitBox
wwbmmm merged PR #1939: URL: https://github.com/apache/incubator-brpc/pull/1939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apa

[incubator-brpc] branch master updated: fix typo in json2pb doc (#1939)

2022-10-09 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git The following commit(s) were added to refs/heads/master by this push: new 1675f163 fix typo in json2pb doc (#1939)

[GitHub] [incubator-brpc] wwbmmm commented on pull request #1948: change the default EventDispatcher some functions' name

2022-10-09 Thread GitBox
wwbmmm commented on PR #1948: URL: https://github.com/apache/incubator-brpc/pull/1948#issuecomment-1272704858 Multiplex的意思是多路复用,好像不是很匹配这里的含义 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Oncall report from Sept 26th to Oct 9th

2022-10-09 Thread Shuai Liu
Hi, all During the last 2 weeks 1 issue were closed and following 4 PRs were merged: * add cases.md https://github.com/apache/incubator-brpc/pull/1944 * add cases.md https://github.com/apache/incubator-brpc/pull/1941 * fix(rpc_replay) continue when failed to init channel https://github.com/apache/i

Re: Hello to the bRPC community

2022-10-09 Thread Shuai Liu
welcome Guangming Best Regards, serverglen 陈光明 于2022年10月10日周一 10:24写道: > Hey guys, > > I'm Guangming Chen, from the yy company, mainly responsible for developing > and maintaining C++ microservice based on bRPC framework. > > My GitHUb address is https://github.com/chenBright . Here are my > c

Re: Hello to the bRPC community

2022-10-09 Thread Wang,Weibing
Welcome! On Mon, Oct 10, 2022 at 10:24 AM 陈光明 wrote: > > Hey guys, > > I'm Guangming Chen, from the yy company, mainly responsible for developing > and maintaining C++ microservice based on bRPC framework. > > My GitHUb address is https://github.com/chenBright . Here are my > contributions: > >

Re: Hello to the bRPC community

2022-10-09 Thread Hu go
Welcome~ On Mon, Oct 10, 2022 at 10:27 AM Wang,Weibing wrote: > Welcome! > > On Mon, Oct 10, 2022 at 10:24 AM 陈光明 wrote: > > > > Hey guys, > > > > I'm Guangming Chen, from the yy company, mainly responsible for > developing and maintaining C++ microservice based on bRPC framework. > > > > My Gi

Re: Hello to the bRPC community

2022-10-09 Thread Wang Wei
Welcome Guangming On Mon, Oct 10, 2022 at 10:33 AM Hu go wrote: > Welcome~ > > On Mon, Oct 10, 2022 at 10:27 AM Wang,Weibing wrote: > > > Welcome! > > > > On Mon, Oct 10, 2022 at 10:24 AM 陈光明 > wrote: > > > > > > Hey guys, > > > > > > I'm Guangming Chen, from the yy company, mainly responsible

Re: Hello to the bRPC community

2022-10-09 Thread Xiaofeng
Welcome~ Hu go 于 2022年10月10日周一 10:33写道: > Welcome~ > > On Mon, Oct 10, 2022 at 10:27 AM Wang,Weibing wrote: > > > Welcome! > > > > On Mon, Oct 10, 2022 at 10:24 AM 陈光明 > wrote: > > > > > > Hey guys, > > > > > > I'm Guangming Chen, from the yy company, mainly responsible for > > developing and

Re: Hello to the bRPC community

2022-10-09 Thread Lorin Lee
Welcome, Guangming! Hu go 于2022年10月10日周一 10:33写道: > > Welcome~ > > On Mon, Oct 10, 2022 at 10:27 AM Wang,Weibing wrote: > > > Welcome! > > > > On Mon, Oct 10, 2022 at 10:24 AM 陈光明 wrote: > > > > > > Hey guys, > > > > > > I'm Guangming Chen, from the yy company, mainly responsible for > > develo

[GitHub] [incubator-brpc] fansehep commented on pull request #1948: change the default EventDispatcher some functions' name

2022-10-09 Thread GitBox
fansehep commented on PR #1948: URL: https://github.com/apache/incubator-brpc/pull/1948#issuecomment-1272729773 > Multiplex的意思是多路复用,好像不是很匹配这里的含义 那要不 AddEventOut?这样可以吗,kqueue 和 epoll 都是事件通知接口。 -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-brpc] adonis0147 opened a new pull request, #1950: Fix "sched_to itself" error when building by Clang on Linux aarch64

2022-10-09 Thread GitBox
adonis0147 opened a new pull request, #1950: URL: https://github.com/apache/incubator-brpc/pull/1950 修复在Linux aarch64平台上用Clang编译器编译,运行时报出来的`sched_to itself`错误。 项目:Apache Doris 平台:Ubuntu 22.04 aarch64 编译器:Ubuntu clang version 14.0.0-1ubuntu1 验证:用clang编译后跑UT,`./run-be-ut.sh` --r

[GitHub] [incubator-brpc] adonis0147 commented on issue #845: 在aarch64下编译之后,运行会触发 LOG(FATAL) << "bthread=" << g->current_tid() << " sched_to itself!"; 请问下哪种情况下会有这个情况?

2022-10-09 Thread GitBox
adonis0147 commented on issue #845: URL: https://github.com/apache/incubator-brpc/issues/845#issuecomment-1272748791 感谢大神 @jamesge 的回复! 经过我的尝试,在Ubuntu 22.04 aarch64平台上,禁止Clang对`TaskGroup::task_runner`和`TaskGroup::sched_to`这两个函数进行优化,好像在我们的项目中就可以正常通过UT测试了。 这个是[修改](https://github.

[GitHub] [incubator-brpc] wwbmmm commented on a diff in pull request #1950: Fix "sched_to itself" error when building by Clang on Linux aarch64

2022-10-09 Thread GitBox
wwbmmm commented on code in PR #1950: URL: https://github.com/apache/incubator-brpc/pull/1950#discussion_r990898308 ## src/bthread/task_group.cpp: ## @@ -248,6 +248,10 @@ int TaskGroup::init(size_t runqueue_capacity) { return 0; } +#if defined (__linux__) && defined (__a

[GitHub] [incubator-brpc] adonis0147 commented on a diff in pull request #1950: Fix "sched_to itself" error when building by Clang on Linux aarch64

2022-10-09 Thread GitBox
adonis0147 commented on code in PR #1950: URL: https://github.com/apache/incubator-brpc/pull/1950#discussion_r990900962 ## src/bthread/task_group.cpp: ## @@ -248,6 +248,10 @@ int TaskGroup::init(size_t runqueue_capacity) { return 0; } +#if defined (__linux__) && defined

Re: Hello to the bRPC community

2022-10-09 Thread Jerry Tan
welcome On 2022/10/10 02:35:45 Lorin Lee wrote: > Welcome, Guangming! > > Hu go 于2022年10月10日周一 10:33写道: > > > > Welcome~ > > > > On Mon, Oct 10, 2022 at 10:27 AM Wang,Weibing wrote: > > > > > Welcome! > > > > > > On Mon, Oct 10, 2022 at 10:24 AM 陈光明 wrote: > > > > > > > > Hey guys, > > > > > >

[GitHub] [incubator-brpc] fansehep opened a new issue, #1951: Should add a pull_request_template.md?

2022-10-09 Thread GitBox
fansehep opened a new issue, #1951: URL: https://github.com/apache/incubator-brpc/issues/1951 **Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)** 项目并没有 pull_request_template.md. 这可能不利于贡献者对问题的详细描述. This project don't have a pull_request_template.md, this can be d