wwbmmm commented on code in PR #1950:
URL: https://github.com/apache/incubator-brpc/pull/1950#discussion_r990898308
##########
src/bthread/task_group.cpp:
##########
@@ -248,6 +248,10 @@ int TaskGroup::init(size_t runqueue_capacity) {
return 0;
}
+#if defined (__linux__) && defined (__aarch64__)
+#pragma clang optimize off
Review Comment:
能否找出clang具体是哪个优化选项导致了这个问题
##########
src/bthread/task_group.cpp:
##########
@@ -248,6 +248,10 @@ int TaskGroup::init(size_t runqueue_capacity) {
return 0;
}
+#if defined (__linux__) && defined (__aarch64__)
+#pragma clang optimize off
Review Comment:
给函数声明加上__attribute__((optnone))会不会更简单一些。
##########
src/bthread/task_group.cpp:
##########
@@ -248,6 +248,10 @@ int TaskGroup::init(size_t runqueue_capacity) {
return 0;
}
+#if defined (__linux__) && defined (__aarch64__)
+#pragma clang optimize off
Review Comment:
只给这俩函数加会不会不够。其它用到tls、且存在bthread切换的代码也可能会有类似的问题
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
