TousakaRin commented on code in PR #2651:
URL: https://github.com/apache/brpc/pull/2651#discussion_r1612875583
##
src/brpc/span.h:
##
@@ -206,6 +206,7 @@ void AnnotateSpan(const char* fmt, ...);
class SpanFilter {
public:
+virtual ~SpanFilter() = 0;
Review Comment:
定
chenBright commented on code in PR #2645:
URL: https://github.com/apache/brpc/pull/2645#discussion_r1612880616
##
src/bthread/key.cpp:
##
@@ -204,14 +205,54 @@ class BAIDU_CACHELINE_ALIGNMENT KeyTable {
SubKeyTable* _subs[KEY_1STLEVEL_SIZE];
};
+class KeyTableList {
+pub
TousakaRin commented on code in PR #2651:
URL: https://github.com/apache/brpc/pull/2651#discussion_r1612875583
##
src/brpc/span.h:
##
@@ -206,6 +206,7 @@ void AnnotateSpan(const char* fmt, ...);
class SpanFilter {
public:
+virtual ~SpanFilter() = 0;
Review Comment:
定
yozhao commented on PR #2651:
URL: https://github.com/apache/brpc/pull/2651#issuecomment-2128574202
Fix non-virtual-dtor warning or error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
yozhao opened a new pull request, #2651:
URL: https://github.com/apache/brpc/pull/2651
### What problem does this PR solve?
Issue Number:
Problem Summary:
### What is changed and the side effects?
Changed:
Side effects:
- Performance effects(性能影响):
chenBright commented on code in PR #2645:
URL: https://github.com/apache/brpc/pull/2645#discussion_r1611156371
##
src/bthread/types.h:
##
@@ -83,8 +83,17 @@ inline std::ostream& operator<<(std::ostream& os,
bthread_key_t key) {
}
#endif // __cplusplus
+namespace bthread{
+
MJY-HUST commented on code in PR #2645:
URL: https://github.com/apache/brpc/pull/2645#discussion_r1612048199
##
src/bthread/key.cpp:
##
@@ -226,14 +267,15 @@ void return_keytable(bthread_keytable_pool_t* pool,
KeyTable* kt) {
delete kt;
return;
}
-std
MJY-HUST commented on code in PR #2645:
URL: https://github.com/apache/brpc/pull/2645#discussion_r1612006692
##
src/bthread/key.cpp:
##
@@ -204,14 +205,54 @@ class BAIDU_CACHELINE_ALIGNMENT KeyTable {
SubKeyTable* _subs[KEY_1STLEVEL_SIZE];
};
+class KeyTableList {
+publi
yybear opened a new issue, #2650:
URL: https://github.com/apache/brpc/issues/2650
**Describe the bug (描述bug)**
服务使用了brpc库，使用容器绑定cpu部署（numa感知）。服务启动后会报Program terminated with signal 11,
Segmentation fault.。
**To Reproduce (复现方法)**
容器绑定cpu部署（numa感知），必现。
**Expected behavior (
chenBright commented on code in PR #2645:
URL: https://github.com/apache/brpc/pull/2645#discussion_r1611178035
##
src/bthread/key.cpp:
##
@@ -226,14 +267,15 @@ void return_keytable(bthread_keytable_pool_t* pool,
KeyTable* kt) {
delete kt;
return;
}
-s
Georgexzp opened a new issue, #2649:
URL: https://github.com/apache/brpc/issues/2649
我启动了一个带有brpcDummyServer的进程并希望他能够正常工作，启动过程没有异常，brpc也打印了服务已在指定端口号启动，但是通过curl
命令却一直卡住没有回复。
我对比了一个示例程序和我的程序的pstack，两者都包含如下线程的堆栈
#0 0x7fd1ee58d9fd in nanosleep () from /lib64/libc.so.6
#1 0x7fd
TousakaRin commented on issue #2648:
URL: https://github.com/apache/brpc/issues/2648#issuecomment-2126628611
应该是编译器版本或者编译选项导致的，欢迎提个PR给他加上一个virtual destructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
chenBright commented on code in PR #2645:
URL: https://github.com/apache/brpc/pull/2645#discussion_r1611151985
##
src/bthread/key.cpp:
##
@@ -226,14 +267,15 @@ void return_keytable(bthread_keytable_pool_t* pool,
KeyTable* kt) {
delete kt;
return;
}
-s
13 matches
Mail list logo
