TousakaRin commented on code in PR #2651:
URL: https://github.com/apache/brpc/pull/2651#discussion_r1612875583
##########
src/brpc/span.h:
##########
@@ -206,6 +206,7 @@ void AnnotateSpan(const char* fmt, ...);
class SpanFilter {
public:
+ virtual ~SpanFilter() = 0;
Review Comment:
定义成纯虚函数最后链接会出错吧。。 virtual ~SpanFilter() = default 比较好
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
