Re: the tasklist that needed for the first apache release

2019-03-28 Thread Hu,Wenwei
I would like take 6. 在 2019/3/28 09:23,“tan zhongyi” 写入: Thanks,zhangyi, Anyone else who want to volunteer to take some task? 在 2019/3/27 下午10:17,“Zhangyi Chen” 写入: I would like take 1 and 2. On Tue, Mar 26, 2019 at 2:25 PM tan zhongyi wrot

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call

2019-03-28 Thread GitBox
zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r270268975 ## File path: src/brpc/details/health_check.cpp ## @@ -0,0 +1,233 @@ +// Copyright (c) 2014 Baidu, Inc. +// +// Licensed

[GitHub] [incubator-brpc] reachfish commented on issue #699: Fail to select server from list

2019-03-28 Thread GitBox
reachfish commented on issue #699: Fail to select server from list URL: https://github.com/apache/incubator-brpc/issues/699#issuecomment-477850065 两个节点时使用la也遇到过 This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call

2019-03-28 Thread GitBox
zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r270268750 ## File path: src/brpc/details/health_check.cpp ## @@ -0,0 +1,233 @@ +// Copyright (c) 2014 Baidu, Inc. +// +// Licensed

[GitHub] [incubator-brpc] xxp125 commented on issue #699: Fail to select server from list

2019-03-28 Thread GitBox
xxp125 commented on issue #699: Fail to select server from list URL: https://github.com/apache/incubator-brpc/issues/699#issuecomment-477846062 也遇到了,la, 只有一个节点也出现Fail to select server, 是否可以做加判断, 只有一个节点时不使用 lb? This is an autom

[GitHub] [incubator-brpc] gydong commented on a change in pull request #694: Health check by rpc call

2019-03-28 Thread GitBox
gydong commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r270046557 ## File path: src/brpc/details/health_check.cpp ## @@ -0,0 +1,233 @@ +// Copyright (c) 2014 Baidu, Inc. +// +// Licensed

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #694: Health check by rpc call

2019-03-28 Thread GitBox
jamesge commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r269980096 ## File path: src/brpc/details/health_check.cpp ## @@ -0,0 +1,233 @@ +// Copyright (c) 2014 Baidu, Inc. +// +// License

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #694: Health check by rpc call

2019-03-28 Thread GitBox
jamesge commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r269979808 ## File path: src/brpc/details/health_check.h ## @@ -0,0 +1,33 @@ +// Copyright (c) 2014 Baidu, Inc. +// +// Licensed u

[GitHub] [incubator-brpc] xuxiping opened a new issue #708: NamingService 初始化过多导致LOG(FATAL)

2019-03-28 Thread GitBox
xuxiping opened a new issue #708: NamingService 初始化过多导致LOG(FATAL) URL: https://github.com/apache/incubator-brpc/issues/708 **Describe the bug (描述bug)** Channel 使用NamingService 初始化, 当Channel过多时导致LOG(FATAL) 进程崩溃。 pthread_key_create 超过系统限制 1024。 https://github.com/apache/incubator-br

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call

2019-03-28 Thread GitBox
zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r269896275 ## File path: src/brpc/details/health_check.cpp ## @@ -0,0 +1,246 @@ +// Copyright (c) 2014 Baidu, Inc. +// +// Licensed

Re: the tasklist that needed for the first apache release

2019-03-28 Thread Wang,Weibing
I would like to take 3. 在 2019/3/28 09:23,“tan zhongyi” 写入: Thanks,zhangyi, Anyone else who want to volunteer to take some task? 在 2019/3/27 下午10:17,“Zhangyi Chen” 写入: I would like take 1 and 2. On Tue, Mar 26, 2019 at 2:25 PM tan zhongyi wro

[GitHub] [incubator-brpc] hairet commented on issue #707: 关于bthread task精准调度signal的疑问,请务必看一下

2019-03-28 Thread GitBox
hairet commented on issue #707: 关于bthread task精准调度signal的疑问,请务必看一下 URL: https://github.com/apache/incubator-brpc/issues/707#issuecomment-477477120 如果觉得有必要,我可以简单修复,似乎在task_group里记录所属work线程 id更合理 This is an automated message fro

[GitHub] [incubator-brpc] hairet commented on issue #707: 关于bthread task精准调度signal的疑问,请务必看一下

2019-03-28 Thread GitBox
hairet commented on issue #707: 关于bthread task精准调度signal的疑问,请务必看一下 URL: https://github.com/apache/incubator-brpc/issues/707#issuecomment-477476784 麻烦帮确认下问题是否存在,虽然只要不是在自己创建的线程里创建bthread没有问题,以及此问题在高qps场景下几乎没有影响 This is an automa

[GitHub] [incubator-brpc] hairet opened a new issue #707: 关于bthread task精准调度signal的疑问,请务必看一下

2019-03-28 Thread GitBox
hairet opened a new issue #707: 关于bthread task精准调度signal的疑问,请务必看一下 URL: https://github.com/apache/incubator-brpc/issues/707 **Describe the bug (描述bug)** 现在一个具体的TaskGroup在入了rq或者remote_queue之后,会根据no_signal开关决定是否立即signal 该TaskGroup对应的work线程,或者还是等待bthread_flush再执行。 有一个问题是TaskGroup里的signal

[GitHub] [incubator-brpc] cuisonghui commented on issue #697: 客户端出现大量timeout

2019-03-28 Thread GitBox
cuisonghui commented on issue #697: 客户端出现大量timeout URL: https://github.com/apache/incubator-brpc/issues/697#issuecomment-477474143 我用gperf跑了一下内存,没发现明显问题,而且这个程序一直在线运行,也一直表现平稳,最近想把grpc替换成brpc就出现了莫名的问题. 我再用asan跑跑. This is an a