Re: Stacked PRs and BP-14

2017-10-24 Thread Sijie Guo
On Tue, Oct 24, 2017 at 1:20 PM, Enrico Olivelli wrote: > Il mar 24 ott 2017, 18:44 Sijie Guo ha scritto: > > > Enrico, > > > > I had a comment in the way how you split the changes. If you split the > > changes by features, do you really need create branches on main repo for > > sending reviews?

Re: Stacked PRs and BP-14

2017-10-24 Thread Enrico Olivelli
Il mar 24 ott 2017, 18:44 Sijie Guo ha scritto: > Enrico, > > I had a comment in the way how you split the changes. If you split the > changes by features, do you really need create branches on main repo for > sending reviews? I don't see any updates to my comments though. > I apologize Sijie, I

Re: Stacked PRs and BP-14

2017-10-24 Thread Sijie Guo
Enrico, I had a comment in the way how you split the changes. If you split the changes by features, do you really need create branches on main repo for sending reviews? I don't see any updates to my comments though. I would suggest us thinking carefully before using share branches, or at least un

Re: Stacked PRs and BP-14

2017-10-24 Thread Ivan Kelly
I would prefix it with your username, so eolivello/issue--part- -Ivan On Tue, Oct 24, 2017 at 5:23 PM, Enrico Olivelli wrote: > Sijie, Ivan and/or other PMC > > I would like to create branches on shared Apache repo in order to create > the chain of Pull Requests. > I think we should agre

Re: Stacked PRs and BP-14

2017-10-24 Thread Enrico Olivelli
Sijie, Ivan and/or other PMC I would like to create branches on shared Apache repo in order to create the chain of Pull Requests. I think we should agree on a naming convention What about issue-471-x issue-471-y issue-471-z where xx is a local name which describes better the inte

Re: Stacked PRs and BP-14

2017-10-21 Thread Enrico Olivelli
Il sab 21 ott 2017, 01:00 Ivan Kelly ha scritto: > Hey Enrico, > > I think we can do better than that stacked PR blog says. GH now allows > you to change the target of a PR which wasn't the case when that was > written. Good news! I think we could even start using branches in the main repo, >

Re: Stacked PRs and BP-14

2017-10-20 Thread Ivan Kelly
Hey Enrico, I think we can do better than that stacked PR blog says. GH now allows you to change the target of a PR which wasn't the case when that was written. I think we could even start using branches in the main repo, and delete them after we merge, and set the base of the pull request to be t

Re: Stacked PRs and BP-14

2017-10-20 Thread Enrico Olivelli
I have created a chain of stacked Pull Requests using my private fork (eolivelli/bookkeeper) https://github.com/eolivelli/bookkeeper/pulls https://github.com/eolivelli/bookkeeper/pull/2 part 1 https://github.com/eolivelli/bookkeeper/pull/3 part 2 https://github.com/eolivelli/bookkeeper/pull/4 par

Re: Stacked PRs and BP-14

2017-10-18 Thread Ivan Kelly
For branching, I would create the on your own personal fork. -Ivan On Wed, Oct 18, 2017 at 8:37 AM, Ivan Kelly wrote: > I had a quick look, I'll get to reviewing today (in bay area this > week, so day is just starting), but looks great. > > -Ivan > > On Wed, Oct 18, 2017 at 8:31 AM, Enrico Olive

Re: Stacked PRs and BP-14

2017-10-18 Thread Ivan Kelly
I had a quick look, I'll get to reviewing today (in bay area this week, so day is just starting), but looks great. -Ivan On Wed, Oct 18, 2017 at 8:31 AM, Enrico Olivelli wrote: > Hi, > I am trying to split the patch for BP-14 in multiple pieces > > This is the umbrella issue, I will link here al