For branching, I would create the on your own personal fork. -Ivan
On Wed, Oct 18, 2017 at 8:37 AM, Ivan Kelly <iv...@apache.org> wrote: > I had a quick look, I'll get to reviewing today (in bay area this > week, so day is just starting), but looks great. > > -Ivan > > On Wed, Oct 18, 2017 at 8:31 AM, Enrico Olivelli <eolive...@gmail.com> wrote: >> Hi, >> I am trying to split the patch for BP-14 in multiple pieces >> >> This is the umbrella issue, I will link here all the Pull Requests >> https://github.com/apache/bookkeeper/issues/471 >> >> I am actually in work-in-progress, I have covered metadata and client side >> changes with the first 2 PRs. >> >> It will take some more days to create all of the PRs. >> >> In order to make it simpler to create stacked PRs it would be better to >> create branches and PRs not against the master but every PR is to be sent >> against the previous one in the list, see [1] as Ivan suggested. >> >> I wounder if it would be better to use my own github repo or to create >> branches on Apache repo. >> I see many projects are using branches directly on apache repository, for >> instance Apache Maven. >> I am not a fan of this because it would lead to some kind of pollution in >> the primary repo. >> >> I will try to set up the whole thing in my repo and come back maybe with a >> better approach. >> >> For me it is a real experiment I hope I am not creating too much noise >> >> Cheers >> Enrico >> >> [1] >> https://graysonkoonce.com/stacked-pull-requests-keeping-github-diffs-small/
