Re: First patch of BP-41 Separated BookieID from BookieSocketAddress is ready

2020-10-10 Thread Enrico Olivelli
Hi BookKeepers, this is the third and last patch for BP-41 https://github.com/apache/bookkeeper/pull/2435 With this change the Bookie will be able to have a fully dynamic network address ! And the clients will be able to follow changes After this patch I will probably have to send a few other mi

Re: First patch of BP-41 Separated BookieID from BookieSocketAddress is ready

2020-09-08 Thread Enrico Olivelli
Hi, the second patch is ready for review https://github.com/apache/bookkeeper/pull/2412 With this patch we can configure a "bookieId" in the Bookie, like a 128-bit UUID, definitely abstracting the Bookie Address from current network address. It is not the last patch in the series see the master i

Re: First patch of BP-41 Separated BookieID from BookieSocketAddress is ready

2020-09-07 Thread Enrico Olivelli
Jia and Anup already reviewed the patch https://github.com/apache/bookkeeper/pull/2404 In my opinion it is time to commit it if no one objects Enrico Il giorno mer 2 set 2020 alle ore 12:44 Enrico Olivelli ha scritto: > I see that Jia already approved the patch and JV took a look at it. > > S

Re: First patch of BP-41 Separated BookieID from BookieSocketAddress is ready

2020-09-02 Thread Enrico Olivelli
I see that Jia already approved the patch and JV took a look at it. Since it is a breaking change in the API (but it is still 100% backward compatible on the wire, on disk and on ZK) it would be great to have a few more eyes on it. We will keep the patch open for more time, but I would like to c