Jia and Anup already reviewed the patch
https://github.com/apache/bookkeeper/pull/2404

In my opinion it is time to commit it if no one objects


Enrico

Il giorno mer 2 set 2020 alle ore 12:44 Enrico Olivelli <eolive...@gmail.com>
ha scritto:

> I see that Jia already approved the patch and JV took a look at it.
>
> Since it is a breaking change in the API (but it is still 100% backward
> compatible on the wire, on disk and on ZK)  it would be great to have a few
> more eyes on it.
>
> We will keep the patch open for more time,
> but I would like to commit it soon, this way I can send the second part,
> about configuring a custom bookieId (bookie side changes)
>
> Enrico
>
> Il giorno lun 31 ago 2020 alle ore 17:32 Enrico Olivelli <
> eolive...@gmail.com> ha scritto:
>
>> Hi BookKeepers,
>> the first patch (the biggest one) is ready for review
>> https://github.com/apache/bookkeeper/pull/2404
>>
>> Enrico
>>
>

Reply via email to