Re: Apache Bookkeeper Checksum Validation

2019-10-05 Thread Enrico Olivelli
Il sab 5 ott 2019, 03:20 Karan Mehta ha scritto: > The Dos security issue is real and your comment makes sense, Enrico. > My earlier solution was to help ensure that bookie can recover from such > scenarios, mostly with a restart. I am not even sure under what conditions > does DigestManager does

Re: Apache Bookkeeper Checksum Validation

2019-10-04 Thread Karan Mehta
The Dos security issue is real and your comment makes sense, Enrico. My earlier solution was to help ensure that bookie can recover from such scenarios, mostly with a restart. I am not even sure under what conditions does DigestManager doesn't even instantiate. I will break it up in following PR's

Re: Apache Bookkeeper Checksum Validation

2019-10-04 Thread Venkateswara Rao Jujjuri
On Fri, Oct 4, 2019 at 12:16 AM Enrico Olivelli wrote: > Karan, > > Il giorno gio 3 ott 2019 alle ore 23:41 Karan Mehta > ha scritto: > > > Thanks for the feedback. I will create a BP soon. > > > > > I won't shutdown the bookie, simply fail the write. It may happen in > case > > of a partial upg

Re: Apache Bookkeeper Checksum Validation

2019-10-04 Thread Enrico Olivelli
Karan, Il giorno gio 3 ott 2019 alle ore 23:41 Karan Mehta ha scritto: > Thanks for the feedback. I will create a BP soon. > > > I won't shutdown the bookie, simply fail the write. It may happen in case > of a partial upgrade of the cluster and a write with a new digest type > comes to the booki

Re: Apache Bookkeeper Checksum Validation

2019-10-03 Thread Karan Mehta
Thanks for the feedback. I will create a BP soon. > I won't shutdown the bookie, simply fail the write. It may happen in case of a partial upgrade of the cluster and a write with a new digest type comes to the bookie Interesting point. As per my assumptions, `All the options assume that the serve

Re: Apache Bookkeeper Checksum Validation

2019-10-03 Thread Enrico Olivelli
Thank you for sharing this work. Two initial comments: Error handling: Unable to instantiate digest manager for that type Decline the write, shutdown itself and wait for external orchestrator to restart I won't shutdown the bookie, simply fail the write. It may happen in case of a partial upgrad

Re: Apache Bookkeeper Checksum Validation

2019-10-03 Thread Sijie Guo
Hi Karan, Thank you for your proposal. Can you also add your proposal as a BP to the BP list? You can check the BP process here: http://bookkeeper.apache.org/community/bookkeeper_proposals/ Thanks, Sijie On Fri, Sep 27, 2019 at 5:53 AM Karan Mehta wrote: > Hello everyone, > > I wrote up a docu