Thank you for sharing this work. Two initial comments: Error handling: Unable to instantiate digest manager for that type Decline the write, shutdown itself and wait for external orchestrator to restart
I won't shutdown the bookie, simply fail the write. It may happen in case of a partial upgrade of the cluster and a write with a new digest type comes to the bookie Which option is better? Thinking about the future and about ideas shared with JV some month ago, I lean towards having ledger metadata in the bookie. Having metadata opens the way to new features, like per ledger storage type Enrico Il gio 3 ott 2019, 18:44 Sijie Guo <guosi...@gmail.com> ha scritto: > Hi Karan, > > Thank you for your proposal. Can you also add your proposal as a BP to the > BP list? You can check the BP process here: > http://bookkeeper.apache.org/community/bookkeeper_proposals/ > > Thanks, > Sijie > > On Fri, Sep 27, 2019 at 5:53 AM Karan Mehta <k.me...@salesforce.com > .invalid> > wrote: > > > Hello everyone, > > > > I wrote up a document here <https://salesforce.quip.com/FmlEAnMbtjnU> > for > > Apache Bookkeeper Checksum Validation for the issue > > <https://github.com/apache/bookkeeper/issues/1046>. I have added certain > > options and highlighted the pros/cons of each design. I would like to > hear > > everyone's thoughts on it. Feel free to comment on the doc to suggest > > ideas. Thanks for your inputs! > > > > -- > > Karan Mehta > > > > <http://smart.salesforce.com/sig/k.mehta//us_mb/default/link.html> > > >
