Re: BP-27: New BookKeeper CLI

2018-01-31 Thread Yiming Zang
+1 to improve the the tool. On Wed, Jan 31, 2018 at 5:52 PM, Jia Zhai wrote: > +1, It is great to break down this huge file, and make it more > structure-able. > The prototype PR seems more clear, and jcommander is nice. > > On Thu, Feb 1, 2018 at 7:22 AM, Sijie Guo wrote: > > > Hi all, > > > >

Re: BP-27: New BookKeeper CLI

2018-01-31 Thread Jia Zhai
+1, It is great to break down this huge file, and make it more structure-able. The prototype PR seems more clear, and jcommander is nice. On Thu, Feb 1, 2018 at 7:22 AM, Sijie Guo wrote: > Hi all, > > I created a new proposal for refactoring `BookieShell` into a new > bookkeeper CLI. > > Because

BP-27: New BookKeeper CLI

2018-01-31 Thread Sijie Guo
Hi all, I created a new proposal for refactoring `BookieShell` into a new bookkeeper CLI. Because currently `BookieShell` becomes a giant class and there is no clear definitions on the operation scope for each command, and the lack of testability and extensibility makes things a bit hard to contr