+1 to improve the the tool. On Wed, Jan 31, 2018 at 5:52 PM, Jia Zhai <zhaiji...@gmail.com> wrote:
> +1, It is great to break down this huge file, and make it more > structure-able. > The prototype PR seems more clear, and jcommander is nice. > > On Thu, Feb 1, 2018 at 7:22 AM, Sijie Guo <guosi...@gmail.com> wrote: > > > Hi all, > > > > I created a new proposal for refactoring `BookieShell` into a new > > bookkeeper CLI. > > > > Because currently `BookieShell` becomes a giant class and there is no > clear > > definitions on the operation scope for each command, and the lack of > > testability and extensibility makes things a bit hard to control and > > maintain, when more and more commands are added into this class. > > > > Here is the proposal: > > > > https://github.com/sijie/bookkeeper/blob/1f710b9c85d5790035ec4ff96f748a > > 1aadef5161/site/bps/BP-27-new-bookkeeper-cli.md > > > > The proposal PR: https://github.com/apache/bookkeeper/pull/1093 > > A prototype to demonstrate the changes: > > https://github.com/apache/bookkeeper/pull/1094 > > > > Please take a look and comments are welcome. > > > > - Sijie > > >
