Re: [DISCUSS] BP-58 Change the API for org.apache.bookkeeper.stats.Counter

Got it thanks Nicolò Boschi Nicolò Boschi 于2022年9月27日周二 16:10写道： > +1 for the BP, thanks Steven > > Usually is a good practice to put the pull request in the "Draft" status to > ensure nobody is able to merge it > > Nicolò Boschi > > > Il giorno mar 27 set 2022 alle ore 08:59 Enrico Olivelli < >

Re: [DISCUSS] BP-58 Change the API for org.apache.bookkeeper.stats.Counter

+1 for the BP, thanks Steven Usually is a good practice to put the pull request in the "Draft" status to ensure nobody is able to merge it Nicolò Boschi Il giorno mar 27 set 2022 alle ore 08:59 Enrico Olivelli < eolive...@gmail.com> ha scritto: > Hello, > The PR has been merged without running

Re: [DISCUSS] BP-58 Change the API for org.apache.bookkeeper.stats.Counter

Hello, The PR has been merged without running a formal VOTE. https://github.com/apache/bookkeeper/pull/3501 I think that given the impact of this change for this time we can move forward and consider the BP "accepted" A few people already commented by "supporting" the BP Thoughts ? Enrico Il

Re: [DISCUSS] BP-58 Change the API for org.apache.bookkeeper.stats.Counter

LGTM. Best, Yong On Mon, 26 Sept 2022 at 15:56, wenbing shen wrote: > +1 （non-binding） > > Thanks. > Wenbing Shen > > ZhangJian He 于2022年9月26日周一 11:15写道： > > > +1 （non-binding） > > > > Thanks > > ZhangJian He > > > > On Sun, 25 Sept 2022 at 20:45, Enrico Olivelli > > wrote: > > > > > I agree

Re: [DISCUSS] BP-58 Change the API for org.apache.bookkeeper.stats.Counter

+1 （non-binding） Thanks. Wenbing Shen ZhangJian He 于2022年9月26日周一 11:15写道： > +1 （non-binding） > > Thanks > ZhangJian He > > On Sun, 25 Sept 2022 at 20:45, Enrico Olivelli > wrote: > > > I agree > > > > Enrico > > > > Il Dom 25 Set 2022, 03:09 steven lu ha scritto: > > > > > Hi BookKeepers, I'v

Re: [DISCUSS] BP-58 Change the API for org.apache.bookkeeper.stats.Counter

+1 （non-binding） Thanks ZhangJian He On Sun, 25 Sept 2022 at 20:45, Enrico Olivelli wrote: > I agree > > Enrico > > Il Dom 25 Set 2022, 03:09 steven lu ha scritto: > > > Hi BookKeepers, I've changed the API for > > org.apache.bookkeeper.stats.Counter: > > BP-58

Re: [DISCUSS] BP-58 Change the API for org.apache.bookkeeper.stats.Counter

I agree Enrico Il Dom 25 Set 2022, 03:09 steven lu ha scritto: > Hi BookKeepers, I've changed the API for > org.apache.bookkeeper.stats.Counter: > BP-58 > > > "Motivation" > > The latency of the OpStatsLogger.registerSuccessfulEvent calculation

[DISCUSS] BP-58 Change the API for org.apache.bookkeeper.stats.Counter

Hi BookKeepers, I've changed the API for org.apache.bookkeeper.stats.Counter: BP-58 "Motivation" The latency of the OpStatsLogger.registerSuccessfulEvent calculation is to convert the time to milliseconds but Counter.add nothing to do so when us