Re: [DISCUSS] BP-35: 128 bits support

2018-08-18 Thread Venkateswara Rao Jujjuri
I think we should avoid the long representation and interpretation in the new code, basically -1 should be looked as MSB of the lsb-ledgerIDset to 1. Also, we should be able to provide BC without special cases. Branching should be based on if msb-ledgerId(scopeID) is 0 or not. Maybe we should trea

Re: [DISCUSS] BP-35: 128 bits support

2018-08-18 Thread Enrico Olivelli
Il sab 18 ago 2018, 18:43 Sijie Guo ha scritto: > On Sat, Aug 18, 2018 at 9:28 AM Enrico Olivelli > wrote: > > > Il sab 18 ago 2018, 17:26 Sijie Guo ha scritto: > > > > > On Sat, Aug 18, 2018 at 2:12 AM Enrico Olivelli > > > wrote: > > > > > > > Nice work Sijie, > > > > Some comments after the

Re: [DISCUSS] BP-35: 128 bits support

2018-08-18 Thread Sijie Guo
On Sat, Aug 18, 2018 at 9:28 AM Enrico Olivelli wrote: > Il sab 18 ago 2018, 17:26 Sijie Guo ha scritto: > > > On Sat, Aug 18, 2018 at 2:12 AM Enrico Olivelli > > wrote: > > > > > Nice work Sijie, > > > Some comments after the first read, just thinking out loud... > > > Overall looks a good ide

Re: [DISCUSS] BP-35: 128 bits support

2018-08-18 Thread Enrico Olivelli
Il sab 18 ago 2018, 17:26 Sijie Guo ha scritto: > On Sat, Aug 18, 2018 at 2:12 AM Enrico Olivelli > wrote: > > > Nice work Sijie, > > Some comments after the first read, just thinking out loud... > > Overall looks a good idea and implementable. > > > > We should cite somewhere the case of scope=

Re: [DISCUSS] BP-35: 128 bits support

2018-08-18 Thread Sijie Guo
On Sat, Aug 18, 2018 at 2:12 AM Enrico Olivelli wrote: > Nice work Sijie, > Some comments after the first read, just thinking out loud... > Overall looks a good idea and implementable. > > We should cite somewhere the case of scope=0 and ledgerId = -1 which is a > very special case for usthe. >

Re: [DISCUSS] BP-35: 128 bits support

2018-08-18 Thread Enrico Olivelli
Nice work Sijie, Some comments after the first read, just thinking out loud... Overall looks a good idea and implementable. We should cite somewhere the case of scope=0 and ledgerId = -1 which is a very special case for usthe. We should also state that scopeid and ledgerid < 0 is not supported or

Re: [DISCUSS] BP-35: 128 bits support

2018-08-17 Thread Venkateswara Rao Jujjuri
Thanks a lot, Sijie for the awesome doc. Let's pool some more thoughts into this and size the work. Thanks, JV On Fri, Aug 17, 2018 at 2:36 PM, Sijie Guo wrote: > Hi all, > > As promised in last community meeting, I put up all the thoughts and > discussion with JV I had into a BP for supporting

[DISCUSS] BP-35: 128 bits support

2018-08-17 Thread Sijie Guo
Hi all, As promised in last community meeting, I put up all the thoughts and discussion with JV I had into a BP for supporting 128-bit ledger id. I tried my best to cover all the aspects that I can think of. There can be places that I miss. so please take a look and let me know what you think. BP