Nice work Sijie, Some comments after the first read, just thinking out loud... Overall looks a good idea and implementable.
We should cite somewhere the case of scope=0 and ledgerId = -1 which is a very special case for usthe. We should also state that scopeid and ledgerid < 0 is not supported or it is not clear to me how we will handle that case. The case of scope < 0 is not clear to me as well, maybe I have to read more carefully the doc. We are treating the global space of ledgerids as a 2 level hierarchy and this is good for compatibility. But thinking about a new application, which starts with uuids I think it can be tricky, maybe we should add utilities/APIs to work with UUID directly. For this new kind of application the space of ids would be flat and not hierarchical (UUID are not hierarchical as far as I know, but I may be wrong). We should also support listing the whole flat space or as a last alternative we should add a way to list the space of scopeids, because otherwise the application must store the list of scopeids, and for it it will be a set of half UUIDs. Thanks for driving this Enrico Il ven 17 ago 2018, 23:52 Venkateswara Rao Jujjuri <jujj...@gmail.com> ha scritto: > Thanks a lot, Sijie for the awesome doc. > Let's pool some more thoughts into this and size the work. > > Thanks, > JV > > On Fri, Aug 17, 2018 at 2:36 PM, Sijie Guo <guosi...@gmail.com> wrote: > > > Hi all, > > > > As promised in last community meeting, I put up all the thoughts and > > discussion with JV I had into a BP for supporting 128-bit ledger id. I > > tried my best to cover all the aspects that I can think of. There can be > > places that I miss. so please take a look and let me know what you think. > > > > BP PR: https://github.com/apache/bookkeeper/pull/1611 > > Google doc: > > https://docs.google.com/document/d/1cu54dNSV2ZrdWCi40LcyX8NxXGRCW > > 0609T_ewmK9BWM > > > > - Sijie > > > > > > -- > Jvrao > --- > First they ignore you, then they laugh at you, then they fight you, then > you win. - Mahatma Gandhi > -- -- Enrico Olivelli
