Re: Still Failing: apache/bookkeeper#4573 (master - f89e3fb)

2019-06-03 Thread Ivan Kelly
Actually, I can't merge master into it because it's sijie's branch. Sijie will have to do so. On Mon, Jun 3, 2019 at 1:51 PM Ivan Kelly wrote: > > Master has been failing for a long time. A failing PR was merged in > https://github.com/apache/bookkeeper/pull/2066 > > The fix is available in > htt

Re: Still Failing: apache/bookkeeper#4573 (master - f89e3fb)

2019-06-03 Thread Ivan Kelly
Master has been failing for a long time. A failing PR was merged in https://github.com/apache/bookkeeper/pull/2066 The fix is available in https://github.com/apache/bookkeeper/pull/2102. I'll merge master into that. It should pass and we can merge. -Ivan On Fri, May 31, 2019 at 7:29 PM Enrico Ol

Re: Changing ledger metadata to binary format

2019-06-03 Thread Ivan Kelly
On Thu, May 30, 2019 at 12:15 AM Venkateswara Rao Jujjuri wrote: > > > "Let's decide this when we need it" > > Right. This is the time as we are trying to add fault domain info to the > cookie. When you say cookie, you mean under /ledgers/cookies? That falls outside the scope of binary metadata.