Actually, I can't merge master into it because it's sijie's branch. Sijie will have to do so.
On Mon, Jun 3, 2019 at 1:51 PM Ivan Kelly <iv...@apache.org> wrote: > > Master has been failing for a long time. A failing PR was merged in > https://github.com/apache/bookkeeper/pull/2066 > > The fix is available in > https://github.com/apache/bookkeeper/pull/2102. I'll merge master into > that. It should pass and we can merge. > > -Ivan > > On Fri, May 31, 2019 at 7:29 PM Enrico Olivelli <eolive...@gmail.com> wrote: > > > > It seems that travis is not very happy > > > > Enrico > > > > ---------- Forwarded message --------- > > Da: Travis CI <bui...@travis-ci.org> > > Date: ven 31 mag 2019, 18:48 > > Subject: Still Failing: apache/bookkeeper#4573 (master - f89e3fb) > > To: <eolive...@gmail.com> > > > > > > apache > > > > / > > > > bookkeeper > > <https://travis-ci.org/apache/bookkeeper?utm_medium=notification&utm_source=email> > > > > [image: branch icon]master > > <https://github.com/apache/bookkeeper/tree/master> > > [image: build has failed] > > Build #4573 is still failing > > <https://travis-ci.org/apache/bookkeeper/builds/539745986?utm_medium=notification&utm_source=email> > > [image: arrow to build time] > > [image: clock icon]22 mins and 53 secs > > > > [image: karanmehta93 avatar]karanmehta93 > > f89e3fb CHANGESET → > > <https://github.com/apache/bookkeeper/compare/26e8004e6b93...f89e3fbb751f> > > > > Update lastLogMark to EOF when replaying journal > > > > Descriptions of the changes in this PR: > > > > ### Motivation > > > > The [commit]( > > https://github.com/apache/bookkeeper/commit/36be8362399341022c8de64f9319270726df2cb3) > > caused integration test failure `test101_RegenerateIndex`, with the > > exception > > ``` > > ```java.io.IOException: Invalid argument > > at sun.nio.ch.FileDispatcherImpl.read0(Native Method) > > at sun.nio.ch.FileDispatcherImpl.read(FileDispatcherImpl.java:46) > > at sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:223) > > at sun.nio.ch.IOUtil.read(IOUtil.java:197) > > at sun.nio.ch.FileChannelImpl.read(FileChannelImpl.java:159) > > at > > org.apache.bookkeeper.bookie.JournalChannel.read(JournalChannel.java:257) > > at org.apache.bookkeeper.bookie.Journal.fullRead(Journal.java:1171) > > at org.apache.bookkeeper.bookie.Journal.scanJournal(Journal.java:792) > > at org.apache.bookkeeper.bookie.Bookie.replay(Bookie.java:924) > > at org.apache.bookkeeper.bookie.Bookie.readJournal(Bookie.java:886) > > at org.apache.bookkeeper.bookie.Bookie.start(Bookie.java:943) > > at org.apache.bookkeeper.proto.BookieServer.start(BookieServer.java:141) > > at > > org.apache.bookkeeper.server.service.BookieService.doStart(BookieService.java:58) > > > > at > > org.apache.bookkeeper.common.component.AbstractLifecycleComponent.start(AbstractLifecycleComponent.java:78) > > > > at > > org.apache.bookkeeper.common.component.LifecycleComponentStack.lambda$start$2(LifecycleComponentStack.java:113) > > > > at com.google.common.collect.ImmutableList.forEach(ImmutableList.java:408) > > at > > org.apache.bookkeeper.common.component.LifecycleComponentStack.start(LifecycleComponentStack.java:113) > > > > at > > org.apache.bookkeeper.common.component.ComponentStarter.startComponent(ComponentStarter.java:80) > > > > at org.apache.bookkeeper.server.Main.doMain(Main.java:229) > > at org.apache.bookkeeper.server.Main.main(Main.java:203) > > ``` > > > > As discussed on slack, it is hard to figure out an exact reason as to why > > the native JNI call fails with an invalid argument. Hence this PR proposes > > that the `lastLogMark` is updated to journal EOF instead of an arbitrary > > LONG.MAX_VALUE. The FileChannel interface defines that the implementors can > > pass in any long offset and the file handler should return EOF immediately > > when trying to read it. However it doesn't seem to be working as expected. > > > > ### Changes > > > > Updated `Journal#setLastLogMark()` method to accept an `scanOffset` instead > > of constant `LONG.MAX_VALUE`. > > > > ivankelly eolivelli > > > > Reviewers: Ivan Kelly <iv...@apache.org>, Enrico Olivelli < > > eolive...@gmail.com> > > > > This closes #2105 from karanmehta93/master > > > > Want to know about upcoming build environment updates? > > > > Would you like to stay up-to-date with the upcoming Travis CI build > > environment updates? We set up a mailing list for you! > > SIGN UP HERE <http://eepurl.com/9OCsP> > > > > [image: book icon] > > > > Documentation <https://docs.travis-ci.com/> about Travis CI > > Have any questions? We're here to help. <supp...@travis-ci.com> > > Unsubscribe > > <https://travis-ci.org/account/preferences/unsubscribe?repository=69758&utm_medium=notification&utm_source=email> > > from build emails from the apache/bookkeeper repository. > > To unsubscribe from *all* build emails, please update your settings > > <https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email>. > > > > [image: black and white travis ci logo] <https://travis-ci.com> > > > > Travis CI GmbH, Rigaer Str. 8, 10427 Berlin, Germany | GF/CEO: Randy Jacops > > | Contact: cont...@travis-ci.com | Amtsgericht Charlottenburg, Berlin, HRB > > 140133 B | Umsatzsteuer-ID gemäß §27 a Umsatzsteuergesetz: DE282002648
