Committed to master branch by mistake

2019-01-22 Thread Enrico Olivelli
I am sorry, I had committed this change to master branch https://github.com/apache/bookkeeper/commit/615f96701a461160d6d246e5387668b0e3406609 I have immediately pushed the revert. I can ask infra for a force push and clean up I apologize Enrico

Re: EnsemblePlacementPolicy exposes third party API "Pair" from commons-lang3 in a public API

2019-01-22 Thread Enrico Olivelli
Il mar 22 gen 2019, 18:38 Sijie Guo ha scritto: > On Tue, Jan 22, 2019 at 8:40 AM Enrico Olivelli > wrote: > > > Hi all, > > while reviewing 4.9 release I found this problem around a change about > > EnsemblePlacementPolicy > > > > this is the issue > > https://github.com/apache/bookkeeper/issue

Re: EnsemblePlacementPolicy exposes third party API "Pair" from commons-lang3 in a public API

2019-01-22 Thread Sijie Guo
On Tue, Jan 22, 2019 at 8:40 AM Enrico Olivelli wrote: > Hi all, > while reviewing 4.9 release I found this problem around a change about > EnsemblePlacementPolicy > > this is the issue > https://github.com/apache/bookkeeper/issues/1914 > > The problem is that in public API we should not use thir

EnsemblePlacementPolicy exposes third party API "Pair" from commons-lang3 in a public API

2019-01-22 Thread Enrico Olivelli
Hi all, while reviewing 4.9 release I found this problem around a change about EnsemblePlacementPolicy this is the issue https://github.com/apache/bookkeeper/issues/1914 The problem is that in public API we should not use third party classes in order to preserve compatibility with incompatible ch

Re: [VOTE] Release 4.9.0, release candidate #0

2019-01-22 Thread Enrico Olivelli
I am sorry I think this is a -1 from me. I have found an important forward compatibility issue on an API, we are introducing the usage of class Pair from commons-lang3 in the EnsemblePlacementPolicy API. More explanations on the issue https://github.com/apache/bookkeeper/issues/1914 I am sorry I