I am sorry I think this is a -1 from me. I have found an important forward compatibility issue on an API, we are introducing the usage of class Pair from commons-lang3 in the EnsemblePlacementPolicy API.
More explanations on the issue https://github.com/apache/bookkeeper/issues/1914 I am sorry I missed this patch https://github.com/apache/bookkeeper/pull/1883 from Charan A part from these all of my other checks were okay. Hopefully we will find a solution to the problem Enrico Il giorno mar 22 gen 2019 alle ore 03:28 Sijie Guo <si...@apache.org> ha scritto: > > Hi everyone, > > Please review and vote on the release candidate #0 for the version 0.4.0, > as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > The complete staging area is available for your review, which includes: > > * Release notes [1] > * The official Apache source and binary distributions to be deployed to > dist.apache.org [2] > * All artifacts to be deployed to the Maven Central Repository [3] > * Source code tag "v4.9.0-rc0" [4] with git sha > fc513dc3cb5817e5516aa0fd26115b35cc84b24a > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > Please download these packages and review this release candidate: > > - Review release notes > - Download the source package (verify shasum, and asc) and follow the > instructions to build and run the bookkeeper service. > - Download the binary package (verify shasum, and asc) and follow the > instructions to run the bookkeeper service. > - Review maven repo, release tag, licenses, and any other things you think > it is important to a release. > > The vote will be open for at least 72 hours. It is adopted by majority > approval, with at least 3 PMC affirmative votes. > > Thanks, > Sijie Guo > > [1] https://github.com/apache/bookkeeper/pull/1910 > [2] https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.9.0-rc0/ > [3] > https://repository.apache.org/content/repositories/orgapachebookkeeper-1037/ > [4] https://github.com/apache/bookkeeper/tree/v4.9.0-rc0
