+1
* Check binary, checksums, and ran a localbookie
* Source, checked rat and compiled with tests
--
Matteo Merli
On Fri, Nov 30, 2018 at 2:53 AM Sijie Guo wrote:
> Hi everyone,
>
> Please review and vote on the release candidate #0 for the version 4.7.3,
> as follows:
> [ ] +1, Approve th
On Mon, Dec 3, 2018 at 1:40 AM Ivan Kelly wrote:
> > This may not be an issue with the master as we moved to immutable
> metadata,
>
> Not an issue with master as blockAddCompletions has been replaced with
> a simple boolean and failure handling changed to only deal with one
> failure at a time.
+1 (binding)
downloaded all artifacts, checked signatures and checksums
checked RAT on staged sources
run tests (jdk8, linux) on the source package, I got some "flaky"
error on some test (all stuff already seen in the past, so non blocker
for me, and they have already been fixed in 4.8 and master)
> This may not be an issue with the master as we moved to immutable metadata,
Not an issue with master as blockAddCompletions has been replaced with
a simple boolean and failure handling changed to only deal with one
failure at a time. However, looking at it again, I think I did spot a
similar bug
