On Mon, Dec 3, 2018 at 1:40 AM Ivan Kelly <iv...@apache.org> wrote: > > This may not be an issue with the master as we moved to immutable > metadata, > > Not an issue with master as blockAddCompletions has been replaced with > a simple boolean and failure handling changed to only deal with one > failure at a time. However, looking at it again, I think I did spot a > similar bug. will dig in after I send this. >
Great; looking forward. > Your email client mangled the code, but as far as I could untangle it. > > updateMetadataIfPossible: No bug. decrement gets called when > ChangeEnsembleCb completes. > updateMetadataIfPossible() is called from resolveConflict() -> "return updateMetadataIfPossible(newMeta);" There is only one case in the updateMetadataIfPossible(newMeta); that will rereadMetadata in other cases it can just return TRUE so there is no ChangeEnsembleCb. I will work on test cases. Thanks, JV > resolveConflict: Looks like a bug. Would be good to had a test case > that tickles it. > > -Ivan > -- Jvrao --- First they ignore you, then they laugh at you, then they fight you, then you win. - Mahatma Gandhi
