[GitHub] eolivelli closed pull request #317: Issue-316 BookKeeperTest#testReadEntryReleaseByteBufs is failing

2017-08-01 Thread git
eolivelli closed pull request #317: Issue-316 BookKeeperTest#testReadEntryReleaseByteBufs is failing URL: https://github.com/apache/bookkeeper/pull/317 This is an automated message from the Apache Git Service. To respond to

[GitHub] eolivelli commented on issue #317: Issue-316 BookKeeperTest#testReadEntryReleaseByteBufs is failing

2017-08-01 Thread git
eolivelli commented on issue #317: Issue-316 BookKeeperTest#testReadEntryReleaseByteBufs is failing URL: https://github.com/apache/bookkeeper/pull/317#issuecomment-319583008 already fixed with #340 This is an automated messa

[GitHub] eolivelli commented on issue #347: Provide a zero-copy write protocol

2017-08-01 Thread git
eolivelli commented on issue #347: Provide a zero-copy write protocol URL: https://github.com/apache/bookkeeper/issues/347#issuecomment-319582316 @merlimat it would be great to be compatibile on the wire protocol as @sijie told it seems that ProtoBuf3 supports usage of ByteBuffers

[GitHub] jiazhai commented on issue #342: Issue 338: add first draft Docker image including community suggestions

2017-08-01 Thread git
jiazhai commented on issue #342: Issue 338: add first draft Docker image including community suggestions URL: https://github.com/apache/bookkeeper/pull/342#issuecomment-319575237 @caiok , as we discussed on slack channel, this introducing the "apply-config-from-env.py" to provide more easy

[GitHub] jiazhai commented on issue #342: Issue 338: add first draft Docker image including community suggestions

2017-08-01 Thread git
jiazhai commented on issue #342: Issue 338: add first draft Docker image including community suggestions URL: https://github.com/apache/bookkeeper/pull/342#issuecomment-319575237 @caiok , as we discussed on slack channel, this introducing the "apply-config-from-env.py" to provide more easy

Build failed in Jenkins: bookkeeper-master #1839

2017-08-01 Thread Apache Jenkins Server
See Changes: [sijie] ISSUE #351: Apache rat check failed on master -- [...truncated 35.04 KB...] [INFO] Exclude: .git/**/* [INFO] Exclude: .github/**/* [INFO] Exclude: **

[GitHub] sijie closed pull request #352: Issue 351: Apache rat check failed on master

2017-08-01 Thread git
sijie closed pull request #352: Issue 351: Apache rat check failed on master URL: https://github.com/apache/bookkeeper/pull/352 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] sijie closed issue #351: Apache rat check failed on master

2017-08-01 Thread git
sijie closed issue #351: Apache rat check failed on master URL: https://github.com/apache/bookkeeper/issues/351 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and us

[GitHub] sijie commented on issue #351: Apache rat check failed on master

2017-08-01 Thread git
sijie commented on issue #351: Apache rat check failed on master URL: https://github.com/apache/bookkeeper/issues/351#issuecomment-319577803 nice caught @zhaijack This is an automated message from the Apache Git Service. To

[GitHub] jiazhai commented on issue #342: Issue 338: add first draft Docker image including community suggestions

2017-08-01 Thread git
jiazhai commented on issue #342: Issue 338: add first draft Docker image including community suggestions URL: https://github.com/apache/bookkeeper/pull/342#issuecomment-319575237 @caiok , as we discussed on slack channel, this introducing the "apply-config-from-env.py" to provide more easy

[GitHub] zhaijack opened a new pull request #352: Issue 351: Apache rat check failed on master

2017-08-01 Thread git
zhaijack opened a new pull request #352: Issue 351: Apache rat check failed on master URL: https://github.com/apache/bookkeeper/pull/352 Descriptions of the changes in this PR: Excludes cacerts from apache-rat check T

[GitHub] zhaijack commented on issue #351: Apache rat check failed on master

2017-08-01 Thread git
zhaijack commented on issue #351: Apache rat check failed on master URL: https://github.com/apache/bookkeeper/issues/351#issuecomment-319576586 The cacerts introduced in #183 is supposed to be binary. however the behavior on jenkins is a bit different from on mac. The fix should be s

[GitHub] zhaijack opened a new issue #351: Apache rat check failed on master

2017-08-01 Thread git
zhaijack opened a new issue #351: Apache rat check failed on master URL: https://github.com/apache/bookkeeper/issues/351 **BUG REPORT** 1. Please describe the issue you observed: - What did you do? run `apache-rat:check` - What did you expect to see? th

[GitHub] merlimat commented on a change in pull request #350: Issue 349: Documentation for security feature in 4.5.0

2017-08-01 Thread git
merlimat commented on a change in pull request #350: Issue 349: Documentation for security feature in 4.5.0 URL: https://github.com/apache/bookkeeper/pull/350#discussion_r130791526 ## File path: site/docs/security/tls.md ## @@ -0,0 +1,178 @@ +--- +title: Encryption and Aut

[GitHub] merlimat commented on a change in pull request #350: Issue 349: Documentation for security feature in 4.5.0

2017-08-01 Thread git
merlimat commented on a change in pull request #350: Issue 349: Documentation for security feature in 4.5.0 URL: https://github.com/apache/bookkeeper/pull/350#discussion_r130791144 ## File path: site/docs/security/tls.md ## @@ -0,0 +1,178 @@ +--- +title: Encryption and Aut

[GitHub] merlimat commented on a change in pull request #350: Issue 349: Documentation for security feature in 4.5.0

2017-08-01 Thread git
merlimat commented on a change in pull request #350: Issue 349: Documentation for security feature in 4.5.0 URL: https://github.com/apache/bookkeeper/pull/350#discussion_r130785731 ## File path: site/docs/security/sasl.md ## @@ -0,0 +1,197 @@ +--- +title: Authentication us

Build failed in Jenkins: bookkeeper-master #1838

2017-08-01 Thread Apache Jenkins Server
See -- [...truncated 34.82 KB...] [INFO] 61 implicit excludes (use -debug for more details). [INFO] Exclude: .git/**/* [INFO] Exclude: .github/**/* [INFO] Exclude: **/target/**/* [INFO]

[GitHub] jiazhai commented on issue #342: Issue 338: add first draft Docker image including community suggestions

2017-08-01 Thread git
jiazhai commented on issue #342: Issue 338: add first draft Docker image including community suggestions URL: https://github.com/apache/bookkeeper/pull/342#issuecomment-319575237 @caiok , as we discussed on slack channel, this introducing the "apply-config-from-env.py" to provide more easy

Build failed in Jenkins: bookkeeper-master #1837

2017-08-01 Thread Apache Jenkins Server
See Changes: [sijie] ISSUE #321: Update "who are we?" [sijie] ISSUE #339: Use ephemeral port for bookkeeper tests and variable unit [sijie] ISSUE #344: add a releases page [sijie] ISSUE #333: [WEBSITE] add bo

[jira] [Commented] (BOOKKEEPER-588) SSL support

2017-08-01 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110352#comment-16110352 ] Hudson commented on BOOKKEEPER-588: --- FAILURE: Integrated in Jenkins build bookkeeper

[GitHub] caiok commented on issue #342: Issue 338: add first draft Docker image including community suggestions(WIP)

2017-08-01 Thread git
caiok commented on issue #342: Issue 338: add first draft Docker image including community suggestions(WIP) URL: https://github.com/apache/bookkeeper/pull/342#issuecomment-319568245 @jiazhai There should be some misunderstanding, I fear. I thought that there was a general consensus about #

[GitHub] sijie commented on issue #350: Issue 349: Documentation for security feature in 4.5.0

2017-08-01 Thread git
sijie commented on issue #350: Issue 349: Documentation for security feature in 4.5.0 URL: https://github.com/apache/bookkeeper/pull/350#issuecomment-319546115 @kishorekasi : can you review the details for tls support? @eolivelli : can you review the details for SASL and zookeeper authe

[GitHub] sijie commented on issue #350: Issue 349: Documentation for security feature in 4.5.0

2017-08-01 Thread git
sijie commented on issue #350: Issue 349: Documentation for security feature in 4.5.0 URL: https://github.com/apache/bookkeeper/pull/350#issuecomment-319545955 You can review the staging site here: https://sijie.github.io/bookkeeper-staging-site/docs/security/ ---

[GitHub] sijie opened a new pull request #350: Issue 349: Documentation for security feature in 4.5.0

2017-08-01 Thread git
sijie opened a new pull request #350: Issue 349: Documentation for security feature in 4.5.0 URL: https://github.com/apache/bookkeeper/pull/350 Descriptions of the changes in this PR: - add a section for `security` - overview to introduce security feature - encryption and authe

[GitHub] yzang commented on a change in pull request #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint

2017-08-01 Thread git
yzang commented on a change in pull request #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint URL: https://github.com/apache/bookkeeper/pull/278#discussion_r130768541 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/http/ConfigurationService.java ##

[GitHub] yzang commented on a change in pull request #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint

2017-08-01 Thread git
yzang commented on a change in pull request #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint URL: https://github.com/apache/bookkeeper/pull/278#discussion_r130768500 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/http/JsonUtil.java ## @@

[GitHub] yzang commented on a change in pull request #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint

2017-08-01 Thread git
yzang commented on a change in pull request #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint URL: https://github.com/apache/bookkeeper/pull/278#discussion_r130768490 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java ###

[GitHub] sijie opened a new issue #349: Documentation for security feature in 4.5.0

2017-08-01 Thread git
sijie opened a new issue #349: Documentation for security feature in 4.5.0 URL: https://github.com/apache/bookkeeper/issues/349 We need documentation for all the security features introduced in 4.5.0 - TLS Authentication - SASL Authentication - ZooKeeper Authentication ---

[GitHub] jiazhai closed pull request #348: Address the problem on merging #183

2017-08-01 Thread git
jiazhai closed pull request #348: Address the problem on merging #183 URL: https://github.com/apache/bookkeeper/pull/348 This is an automated message from the Apache Git Service. To respond to the message, please log on GitH

[GitHub] sijie opened a new pull request #348: Address the problem on merging #183

2017-08-01 Thread git
sijie opened a new pull request #348: Address the problem on merging #183 URL: https://github.com/apache/bookkeeper/pull/348 Descriptions of the changes in this PR: listenOn should be running in constructing netty server. because we use binding to prevent two bookies start at the sam

[GitHub] sijie closed pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-08-01 Thread git
sijie closed pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183 This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (BOOKKEEPER-588) SSL support

2017-08-01 Thread Kishore Kasi Udayashankar (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109920#comment-16109920 ] Kishore Kasi Udayashankar commented on BOOKKEEPER-588: -- kishoreka

[jira] [Commented] (BOOKKEEPER-588) SSL support

2017-08-01 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109844#comment-16109844 ] Sijie Guo commented on BOOKKEEPER-588: -- what is kishorekasi 's jira id? > SSL s

[jira] [Commented] (BOOKKEEPER-575) Bookie SSL support

2017-08-01 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109837#comment-16109837 ] Sijie Guo commented on BOOKKEEPER-575: -- [~ikelly] did most of the sub-tasks of th

[jira] [Assigned] (BOOKKEEPER-575) Bookie SSL support

2017-08-01 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo reassigned BOOKKEEPER-575: Assignee: Ivan Kelly > Bookie SSL support > -- > > Key:

[jira] [Commented] (BOOKKEEPER-816) use native fallocate & sync_file_range to improve journal allocation

2017-08-01 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109831#comment-16109831 ] Sijie Guo commented on BOOKKEEPER-816: -- moved this to 4.6.0 > use native falloca

[jira] [Updated] (BOOKKEEPER-816) use native fallocate & sync_file_range to improve journal allocation

2017-08-01 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-816: - Fix Version/s: (was: 4.5.0) 4.6.0 > use native fallocate & sync_file_ra

[GitHub] sijie closed issue #195: Update JMX documentation

2017-08-01 Thread git
sijie closed issue #195: Update JMX documentation URL: https://github.com/apache/bookkeeper/issues/195 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] sijie commented on issue #195: Update JMX documentation

2017-08-01 Thread git
sijie commented on issue #195: Update JMX documentation URL: https://github.com/apache/bookkeeper/issues/195#issuecomment-319503576 Closed this as "Won't Fix" This is an automated message from the Apache Git Service. To respo

[GitHub] sijie commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-08-01 Thread git
sijie commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#issuecomment-319502198 merging this (will resolve the conflicts manually) This is an automated messag

[GitHub] sijie closed issue #333: [website] add bookkeeper slack channel to README.md and website

2017-08-01 Thread git
sijie closed issue #333: [website] add bookkeeper slack channel to README.md and website URL: https://github.com/apache/bookkeeper/issues/333 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] sijie closed pull request #341: Issue 333: [website] add bookkeeper slack channel to README.md and website

2017-08-01 Thread git
sijie closed pull request #341: Issue 333: [website] add bookkeeper slack channel to README.md and website URL: https://github.com/apache/bookkeeper/pull/341 This is an automated message from the Apache Git Service. To resp

[GitHub] sijie closed pull request #345: Issue 344: add a releases page

2017-08-01 Thread git
sijie closed pull request #345: Issue 344: add a releases page URL: https://github.com/apache/bookkeeper/pull/345 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] sijie closed issue #344: [website] add a releases page

2017-08-01 Thread git
sijie closed issue #344: [website] add a releases page URL: https://github.com/apache/bookkeeper/issues/344 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use t

[GitHub] sijie commented on a change in pull request #345: Issue 344: add a releases page

2017-08-01 Thread git
sijie commented on a change in pull request #345: Issue 344: add a releases page URL: https://github.com/apache/bookkeeper/pull/345#discussion_r130730229 ## File path: site/releases.md ## @@ -0,0 +1,113 @@ +--- +title: Apache BookKeeper Releases +layout: community +--- + +#

[GitHub] merlimat commented on issue #347: Provide a zero-copy write protocol (replace Google ProtoBuf ?)

2017-08-01 Thread git
merlimat commented on issue #347: Provide a zero-copy write protocol (replace Google ProtoBuf ?) URL: https://github.com/apache/bookkeeper/issues/347#issuecomment-319488245 @eolivelli My preference would be to keep the current Protobuf wire protocol and use a zero-copy implementation to se

[GitHub] sijie commented on issue #266: Issue 265: Add persistable bookie status

2017-08-01 Thread git
sijie commented on issue #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#issuecomment-319483635 thank you @yzang This is an automated message from the Apache Git Service. To

[GitHub] sijie commented on issue #347: Provide a zero-copy write protocol (replace Google ProtoBuf ?)

2017-08-01 Thread git
sijie commented on issue #347: Provide a zero-copy write protocol (replace Google ProtoBuf ?) URL: https://github.com/apache/bookkeeper/issues/347#issuecomment-319483462 this is going to a big change. can we first unmark the milestone? before we come up with a method, let's not mark it in

[GitHub] sijie commented on issue #347: Provide a zero-copy write protocol (replace Google ProtoBuf ?)

2017-08-01 Thread git
sijie commented on issue #347: Provide a zero-copy write protocol (replace Google ProtoBuf ?) URL: https://github.com/apache/bookkeeper/issues/347#issuecomment-319482467 @eolivelli can you remove 'replace google protobuf' from caption? this is going to be misleading. I don't see replacing

[GitHub] eolivelli commented on issue #347: Provide a zero-copy write protocol (replace Google ProtoBuf ?)

2017-08-01 Thread git
eolivelli commented on issue #347: Provide a zero-copy write protocol (replace Google ProtoBuf ?) URL: https://github.com/apache/bookkeeper/issues/347#issuecomment-319480950 We are looking for something like this https://dwrensha.github.io/capnproto-java/index.html /cc @merlimat @

[GitHub] eolivelli opened a new issue #347: Provide a zero-copy write protocol (replace Google ProtoBuf ?)

2017-08-01 Thread git
eolivelli opened a new issue #347: Provide a zero-copy write protocol (replace Google ProtoBuf ?) URL: https://github.com/apache/bookkeeper/issues/347 **FEATURE REQUEST** 1. Please describe the feature you are requesting. In the V3 protocol we use Google Protobuf, which is great f

[GitHub] sijie commented on a change in pull request #345: Issue 344: add a releases page

2017-08-01 Thread git
sijie commented on a change in pull request #345: Issue 344: add a releases page URL: https://github.com/apache/bookkeeper/pull/345#discussion_r130711603 ## File path: site/releases.md ## @@ -0,0 +1,113 @@ +--- +title: Apache BookKeeper Releases +layout: community +--- + +#

[GitHub] sijie closed pull request #340: Issue 339: Use ephemeral port for bookkeeper tests and variable unit test improvements

2017-08-01 Thread git
sijie closed pull request #340: Issue 339: Use ephemeral port for bookkeeper tests and variable unit test improvements URL: https://github.com/apache/bookkeeper/pull/340 This is an automated message from the Apache Git Serv

[GitHub] sijie closed issue #339: Use ephemeral port for bookkeeper tests

2017-08-01 Thread git
sijie closed issue #339: Use ephemeral port for bookkeeper tests URL: https://github.com/apache/bookkeeper/issues/339 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] sijie commented on issue #335: Docker Image: tracking sub issues

2017-08-01 Thread git
sijie commented on issue #335: Docker Image: tracking sub issues URL: https://github.com/apache/bookkeeper/issues/335#issuecomment-319478930 @eolivelli +1 This is an automated message from the Apache Git Service. To respond t

[GitHub] eolivelli commented on issue #335: Docker Image: tracking sub issues

2017-08-01 Thread git
eolivelli commented on issue #335: Docker Image: tracking sub issues URL: https://github.com/apache/bookkeeper/issues/335#issuecomment-319478358 @jiazhai @sijie should we create a Github label "docker" ? there are plenty of issues/pull requests and I think it is worth a label so that con

[GitHub] sijie closed issue #321: [website] Update "who are we?"

2017-08-01 Thread git
sijie closed issue #321: [website] Update "who are we?" URL: https://github.com/apache/bookkeeper/issues/321 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use t

[GitHub] sijie closed pull request #334: Issue 321: Update "who are we?"

2017-08-01 Thread git
sijie closed pull request #334: Issue 321: Update "who are we?" URL: https://github.com/apache/bookkeeper/pull/334 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] sijie commented on issue #317: Issue-316 BookKeeperTest#testReadEntryReleaseByteBufs is failing

2017-08-01 Thread git
sijie commented on issue #317: Issue-316 BookKeeperTest#testReadEntryReleaseByteBufs is failing URL: https://github.com/apache/bookkeeper/pull/317#issuecomment-319478127 @eolivelli it seems that #340 addressed the problem here. can we close the pull request? -

[GitHub] lucperkins commented on a change in pull request #345: Issue 344: add a releases page

2017-08-01 Thread git
lucperkins commented on a change in pull request #345: Issue 344: add a releases page URL: https://github.com/apache/bookkeeper/pull/345#discussion_r130708523 ## File path: site/releases.md ## @@ -0,0 +1,113 @@ +--- +title: Apache BookKeeper Releases +layout: community +--

[GitHub] lucperkins commented on a change in pull request #345: Issue 344: add a releases page

2017-08-01 Thread git
lucperkins commented on a change in pull request #345: Issue 344: add a releases page URL: https://github.com/apache/bookkeeper/pull/345#discussion_r130709098 ## File path: site/releases.md ## @@ -0,0 +1,113 @@ +--- +title: Apache BookKeeper Releases +layout: community +--

[GitHub] sijie closed pull request #346: Issue 324: Add htaccess for handling redirections to old releases

2017-08-01 Thread git
sijie closed pull request #346: Issue 324: Add htaccess for handling redirections to old releases URL: https://github.com/apache/bookkeeper/pull/346 This is an automated message from the Apache Git Service. To respond to th

[GitHub] sijie commented on issue #346: Issue 324: Add htaccess for handling redirections to old releases

2017-08-01 Thread git
sijie commented on issue #346: Issue 324: Add htaccess for handling redirections to old releases URL: https://github.com/apache/bookkeeper/pull/346#issuecomment-319471811 note: this change is based on asf-site. it can not be merged by the merge script. we can merge it using the github merg

[GitHub] sijie opened a new pull request #346: Issue 324: Add htaccess for handling redirections to old releases

2017-08-01 Thread git
sijie opened a new pull request #346: Issue 324: Add htaccess for handling redirections to old releases URL: https://github.com/apache/bookkeeper/pull/346 Descriptions of the changes in this PR: Add a .htaccess file to redirect /archives to the old releases. ---

[GitHub] sijie commented on issue #345: Issue 344: add a releases page

2017-08-01 Thread git
sijie commented on issue #345: Issue 344: add a releases page URL: https://github.com/apache/bookkeeper/pull/345#issuecomment-319458478 /cc @lucperkins for a review This is basically the copy for http://bookkeeper.apache.org/releases.html You can review this from my staging sit

[GitHub] sijie opened a new pull request #345: Issue 344: add a releases page

2017-08-01 Thread git
sijie opened a new pull request #345: Issue 344: add a releases page URL: https://github.com/apache/bookkeeper/pull/345 Descriptions of the changes in this PR: Add a releases page for keeping the history of apache releases. ---

[GitHub] sijie opened a new issue #344: [website] add a releases page

2017-08-01 Thread git
sijie opened a new issue #344: [website] add a releases page URL: https://github.com/apache/bookkeeper/issues/344 We need to a `releases` page to keep the records for all apache releases. http://bookkeeper.apache.org/releases.html -

[GitHub] yzang commented on issue #266: Issue 265: Add persistable bookie status

2017-08-01 Thread git
yzang commented on issue #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#issuecomment-319457218 @sijie Sure, feel free to defer, it's not a critical feature to 4.5 This is an

[GitHub] sijie commented on issue #339: Use ephemeral port for bookkeeper tests

2017-08-01 Thread git
sijie commented on issue #339: Use ephemeral port for bookkeeper tests URL: https://github.com/apache/bookkeeper/issues/339#issuecomment-319456709 thank you @eolivelli @zhaijack . it is a good conversation. I marked this in 4.5.0. Let's try to include this for the release. ---

[GitHub] zhaijack opened a new issue #343: TestFencing.testManyOpenParallel

2017-08-01 Thread git
zhaijack opened a new issue #343: TestFencing.testManyOpenParallel URL: https://github.com/apache/bookkeeper/issues/343 **BUG REPORT** 1. Please describe the issue you observed: - What did you do? Run TestFencing - What did you expect to see? TestFencin

[GitHub] zhaijack commented on issue #340: Issue 339: Use ephemeral port for bookkeeper tests and variable unit test improvements

2017-08-01 Thread git
zhaijack commented on issue #340: Issue 339: Use ephemeral port for bookkeeper tests and variable unit test improvements URL: https://github.com/apache/bookkeeper/pull/340#issuecomment-319433015 TestFencing seems to be a flaky test for a while. I will create a separate issue for that. --

[GitHub] zhaijack commented on issue #340: Issue 339: Use ephemeral port for bookkeeper tests and variable unit test improvements

2017-08-01 Thread git
zhaijack commented on issue #340: Issue 339: Use ephemeral port for bookkeeper tests and variable unit test improvements URL: https://github.com/apache/bookkeeper/pull/340#issuecomment-319432073 The problem of BookieShutdownTest#testBookieRestartContinously: it requires restarting bookies

[GitHub] lucperkins commented on a change in pull request #341: Issue 333: [website] add bookkeeper slack channel to README.md and website

2017-08-01 Thread git
lucperkins commented on a change in pull request #341: Issue 333: [website] add bookkeeper slack channel to README.md and website URL: https://github.com/apache/bookkeeper/pull/341#discussion_r130661773 ## File path: site/community/slack.md ## @@ -0,0 +1,9 @@ +--- +title:

[GitHub] lucperkins commented on a change in pull request #341: Issue 333: [website] add bookkeeper slack channel to README.md and website

2017-08-01 Thread git
lucperkins commented on a change in pull request #341: Issue 333: [website] add bookkeeper slack channel to README.md and website URL: https://github.com/apache/bookkeeper/pull/341#discussion_r130661924 ## File path: site/community/slack.md ## @@ -0,0 +1,9 @@ +--- +title:

[GitHub] sijie commented on issue #341: Issue 333: [website] add bookkeeper slack channel to README.md and website

2017-08-01 Thread git
sijie commented on issue #341: Issue 333: [website] add bookkeeper slack channel to README.md and website URL: https://github.com/apache/bookkeeper/pull/341#issuecomment-319428089 LGTM but /cc @lucperkins for a review as well ---

[GitHub] zhaijack opened a new pull request #342: Issue 338: add dd first draft Docker image including community suggestions(WIP)

2017-08-01 Thread git
zhaijack opened a new pull request #342: Issue 338: add dd first draft Docker image including community suggestions(WIP) URL: https://github.com/apache/bookkeeper/pull/342 This is still work in progress(WIP). Currently after a build, a simple command to start it is like this: doc

[GitHub] caiok commented on issue #330: Docker Image v1.0

2017-08-01 Thread git
caiok commented on issue #330: Docker Image v1.0 URL: https://github.com/apache/bookkeeper/issues/330#issuecomment-319403339 @jiazhai opened #335 with the same aim of this issue This is an automated message from the Apache Gi

[GitHub] caiok closed issue #330: Docker Image v1.0

2017-08-01 Thread git
caiok closed issue #330: Docker Image v1.0 URL: https://github.com/apache/bookkeeper/issues/330 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above

[GitHub] eolivelli commented on issue #340: Issue 339: Use ephemeral port for bookkeeper tests and variable unit test improvements

2017-08-01 Thread git
eolivelli commented on issue #340: Issue 339: Use ephemeral port for bookkeeper tests and variable unit test improvements URL: https://github.com/apache/bookkeeper/pull/340#issuecomment-319380181 Overall is OK for me. There is still some failing test, like these, but it is not always re

[jira] [Commented] (BOOKKEEPER-1102) org.apache.bookkeeper.client.BookKeeperDiskSpaceWeightedLedgerPlacementTest.testDiskSpaceWeightedBookieSelectionWithBookiesBeingAdded is unreliable

2017-08-01 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108941#comment-16108941 ] Hudson commented on BOOKKEEPER-1102: FAILURE: Integrated in Jenkins build bookkee

Build failed in Jenkins: bookkeeper-master #1836

2017-08-01 Thread Apache Jenkins Server
See Changes: [sijie] ISSUE #323: [WEBSITE] ci job to automatically publish website to apache [sijie] ISSUE #314: Enable checkstyle on bookkeeper-server [sijie] BOOKKEEPER-1102: Clarify BookieInfoReader and fix

Re: [Draft] bookkeeper board report - August 2017

2017-08-01 Thread Enrico Olivelli
I Agree thanks Enrico 2017-08-01 13:50 GMT+02:00 Jia Zhai : > Thanks for Enrico and Sijie's comments. referenced the old reporting for > the content: https://whimsy.apache.org/board/minutes/BookKeeper.html, > seems > not too much tech-details mentioned. > > On Tue, Aug 1, 2017 at 5:37 PM, Sijie G

Re: Slack Channel

2017-08-01 Thread Jia Zhai
The links works well. I am updating the documentation for slack channel. https://github.com/apache/bookkeeper/pull/341 On Tue, Aug 1, 2017 at 10:46 AM, Sijie Guo wrote: > Hi all, > > The slack channel https://apachebookkeeper.slack.com is live now. If you > have emails (@apache.org), you can sig

Re: [Draft] bookkeeper board report - August 2017

2017-08-01 Thread Jia Zhai
Thanks for Enrico and Sijie's comments. referenced the old reporting for the content: https://whimsy.apache.org/board/minutes/BookKeeper.html, seems not too much tech-details mentioned. On Tue, Aug 1, 2017 at 5:37 PM, Sijie Guo wrote: > On Tue, Aug 1, 2017 at 2:29 AM, Enrico Olivelli > wrote: >

[GitHub] zhaijack commented on issue #333: [website] add bookkeeper slack channel to README.md and website

2017-08-01 Thread git
zhaijack commented on issue #333: [website] add bookkeeper slack channel to README.md and website URL: https://github.com/apache/bookkeeper/issues/333#issuecomment-319347192 updated the doc by PR https://github.com/apache/bookkeeper/pull/341 On Tue, Aug 1, 2017 at 10:49 AM, Sijie Guo

[GitHub] zhaijack opened a new pull request #341: Issue 333: [website] add bookkeeper slack channel to README.md and website

2017-08-01 Thread git
zhaijack opened a new pull request #341: Issue 333: [website] add bookkeeper slack channel to README.md and website URL: https://github.com/apache/bookkeeper/pull/341 Descriptions of the changes in this PR: - add slack channel to README - add slack channel to website ---

[GitHub] zhaijack commented on issue #339: Use ephemeral port for bookkeeper tests

2017-08-01 Thread git
zhaijack commented on issue #339: Use ephemeral port for bookkeeper tests URL: https://github.com/apache/bookkeeper/issues/339#issuecomment-319345321 @eolivelli I've fixed most of the issues in #340 please take a look. I addressed the broken tests not by adding ephemeral port. Those

[GitHub] eolivelli commented on issue #340: Issue 339: Use ephemeral port for bookkeeper tests and variable unit test improvements

2017-08-01 Thread git
eolivelli commented on issue #340: Issue 339: Use ephemeral port for bookkeeper tests and variable unit test improvements URL: https://github.com/apache/bookkeeper/pull/340#issuecomment-319343245 @zhaijack great work. I am checking on my laptop

[GitHub] eolivelli commented on issue #317: Issue-316 BookKeeperTest#testReadEntryReleaseByteBufs is failing

2017-08-01 Thread git
eolivelli commented on issue #317: Issue-316 BookKeeperTest#testReadEntryReleaseByteBufs is failing URL: https://github.com/apache/bookkeeper/pull/317#issuecomment-319343088 Thank you very much @zhaijack I have checked out locally #340 I am reviewing, will give my +1 soon -

[GitHub] eolivelli commented on issue #339: Use ephemeral port for bookkeeper tests

2017-08-01 Thread git
eolivelli commented on issue #339: Use ephemeral port for bookkeeper tests URL: https://github.com/apache/bookkeeper/issues/339#issuecomment-319341750 @zhaijack do you think that 'flakyness' is due to TCP port which are not closed correctly ? IMHO tests used to run smoothly last month, i

[GitHub] zhaijack commented on issue #317: Issue-316 BookKeeperTest#testReadEntryReleaseByteBufs is failing

2017-08-01 Thread git
zhaijack commented on issue #317: Issue-316 BookKeeperTest#testReadEntryReleaseByteBufs is failing URL: https://github.com/apache/bookkeeper/pull/317#issuecomment-319341758 @eolivelli I included the fix for BookKeeperTest in #340 --

[GitHub] zhaijack opened a new pull request #340: Issue 339: Use ephemeral port for bookkeeper tests and variable unit test improvements

2017-08-01 Thread git
zhaijack opened a new pull request #340: Issue 339: Use ephemeral port for bookkeeper tests and variable unit test improvements URL: https://github.com/apache/bookkeeper/pull/340 Descriptions of the changes in this PR: - Enable ephemeral port by default for all BookKeeperClusterTestC

[GitHub] zhaijack commented on issue #339: Use ephemeral port for bookkeeper tests

2017-08-01 Thread git
zhaijack commented on issue #339: Use ephemeral port for bookkeeper tests URL: https://github.com/apache/bookkeeper/issues/339#issuecomment-319338661 @eolivelli the main reason for this is to ensure we have a stable test for cutting 4.5.0. If we can't get the unit test back to stable, we do

[GitHub] jiazhai closed issue #288: Docker image: provide a template related way to handle different version

2017-08-01 Thread git
jiazhai closed issue #288: Docker image: provide a template related way to handle different version URL: https://github.com/apache/bookkeeper/issues/288 This is an automated message from the Apache Git Service. To respond t

[GitHub] eolivelli commented on issue #339: Use ephemeral port for bookkeeper tests

2017-08-01 Thread git
eolivelli commented on issue #339: Use ephemeral port for bookkeeper tests URL: https://github.com/apache/bookkeeper/issues/339#issuecomment-319336136 @zhaijack maybe we can get this into 4.6, I would like not to apply this important change now that we are close to the release, what do you

[GitHub] zhaijack opened a new issue #339: Use ephemeral port for bookkeeper tests

2017-08-01 Thread git
zhaijack opened a new issue #339: Use ephemeral port for bookkeeper tests URL: https://github.com/apache/bookkeeper/issues/339 *Problem* Ephemeral port was introduced at #296 . It would be good if we can use ephmeral port in bookkeeper tests to improve the stability of unit tests.

[GitHub] eolivelli commented on issue #317: Issue-316 BookKeeperTest#testReadEntryReleaseByteBufs is failing

2017-08-01 Thread git
eolivelli commented on issue #317: Issue-316 BookKeeperTest#testReadEntryReleaseByteBufs is failing URL: https://github.com/apache/bookkeeper/pull/317#issuecomment-319328483 @zhaijack That was my suspect. I think it is better to drop the assertTrue(byteBuf.release()) a leave only "byteBuf

[GitHub] zhaijack commented on issue #317: Issue-316 BookKeeperTest#testReadEntryReleaseByteBufs is failing

2017-08-01 Thread git
zhaijack commented on issue #317: Issue-316 BookKeeperTest#testReadEntryReleaseByteBufs is failing URL: https://github.com/apache/bookkeeper/pull/317#issuecomment-319326481 there is in general a problem with #testReadEntryReleaseByteBufs - it made a very bad assumption that #release() call

[GitHub] eolivelli commented on issue #317: Issue-316 BookKeeperTest#testReadEntryReleaseByteBufs is failing

2017-08-01 Thread git
eolivelli commented on issue #317: Issue-316 BookKeeperTest#testReadEntryReleaseByteBufs is failing URL: https://github.com/apache/bookkeeper/pull/317#issuecomment-319324416 @zhaijack thank you for looking at this, I am ok with IllegalStateException @sijie are you ok ? --

Re: [Draft] bookkeeper board report - August 2017

2017-08-01 Thread Sijie Guo
On Tue, Aug 1, 2017 at 2:29 AM, Enrico Olivelli wrote: > Thank you Jia, > comments inline > > 2017-08-01 9:59 GMT+02:00 Jia Zhai : > > > Hi all, > > Here is a draft for our August report, Please help review and comments > on > > it. > > > > Thanks a lot. > > -Jia > > > > == > > ## De

  1   2   >