zhaijack opened a new pull request #340: Issue 339: Use ephemeral port for bookkeeper tests and variable unit test improvements URL: https://github.com/apache/bookkeeper/pull/340 Descriptions of the changes in this PR: - Enable ephemeral port by default for all BookKeeperClusterTestCase based test cases - Removed Multi* based classes. A lot of unit tests unnecessarily extended from those base classes. Converted them to extend BookKeeperClusterTestCase directly. Confirmed this with @sijie - Reduce sleep period for some test cases LedgerEntry fixes for #317 - use checkState rather than checkNull to keep the behavior consistent as before - fix BookKeeperTest#testReadEntryReleaseByteBufs TestBackwardCompat: - removed testCompact400 (400 has been very long time ago, no one is running 400) - BookKeeperNettyServer should shut down netty server when failed to construct a bookie TestDiskChecker: - increased the threshold to 0.99f. be consistent with TestBKConfiguration BookieInitializationTest - make each test method using different ledgers path, so registration won't be conflicting between tests ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
