[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891087 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java ## @@ -149,6 +150,8 @

[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891250 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +1,2

[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891093 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java ## @@ -748,7 +751,13

[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891128 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +1,2

[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891221 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +1,2

[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891200 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +1,2

[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891256 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +1,2

[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891187 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +1,2

[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891121 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java ## @@ -857,7 +884,13

[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891154 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +1,2

[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891189 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +1,2

[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891227 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +1,2

[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891030 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +1,2

[GitHub] sijie commented on issue #80: BOOKKEEPER-816: use native fallocate to improve journal allocation

sijie commented on issue #80: BOOKKEEPER-816: use native fallocate to improve journal allocation URL: https://github.com/apache/bookkeeper/pull/80#issuecomment-317160218 @eolivelli it is on my list. I will do it at the last.

[GitHub] sijie commented on a change in pull request #206: Issue-196 Create Jenkins configuration using OpenStack Jenkins Job Builder

sijie commented on a change in pull request #206: Issue-196 Create Jenkins configuration using OpenStack Jenkins Job Builder URL: https://github.com/apache/bookkeeper/pull/206#discussion_r128890903 ## File path: jenkins/bookkeeper-master-job-configuration.yaml ## @@ -0,0 +

[GitHub] sijie commented on a change in pull request #206: Issue-196 Create Jenkins configuration using OpenStack Jenkins Job Builder

sijie commented on a change in pull request #206: Issue-196 Create Jenkins configuration using OpenStack Jenkins Job Builder URL: https://github.com/apache/bookkeeper/pull/206#discussion_r128890895 ## File path: jenkins/README.md ## @@ -0,0 +1,65 @@ + + +Instructions for b

[GitHub] sijie commented on a change in pull request #206: Issue-196 Create Jenkins configuration using OpenStack Jenkins Job Builder

sijie commented on a change in pull request #206: Issue-196 Create Jenkins configuration using OpenStack Jenkins Job Builder URL: https://github.com/apache/bookkeeper/pull/206#discussion_r128890910 ## File path: jenkins/bookkeeper-master-job-configuration.yaml ## @@ -0,0 +

[GitHub] sijie commented on a change in pull request #206: Issue-196 Create Jenkins configuration using OpenStack Jenkins Job Builder

sijie commented on a change in pull request #206: Issue-196 Create Jenkins configuration using OpenStack Jenkins Job Builder URL: https://github.com/apache/bookkeeper/pull/206#discussion_r128890805 ## File path: jenkins/README.md ## @@ -0,0 +1,65 @@ + + +Instructions for b

[GitHub] eolivelli commented on issue #80: BOOKKEEPER-816: use native fallocate to improve journal allocation

eolivelli commented on issue #80: BOOKKEEPER-816: use native fallocate to improve journal allocation URL: https://github.com/apache/bookkeeper/pull/80#issuecomment-317159865 @sijie do you have time to look at this? Thank very much --

[GitHub] sijie commented on issue #81: BOOKKEEPER-753: Bookie should run garbage collection before startup when all directories became full

sijie commented on issue #81: BOOKKEEPER-753: Bookie should run garbage collection before startup when all directories became full URL: https://github.com/apache/bookkeeper/pull/81#issuecomment-317159391 this change has a huge conflict with Charan's change. Since it is not a blocker, I am

[GitHub] sijie closed pull request #81: BOOKKEEPER-753: Bookie should run garbage collection before startup when all directories became full

sijie closed pull request #81: BOOKKEEPER-753: Bookie should run garbage collection before startup when all directories became full URL: https://github.com/apache/bookkeeper/pull/81 This is an automated message from the Apa

[GitHub] sijie commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper

sijie commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#issuecomment-317159345 @kishorekasi do you have time to review the comments? It would be great if we can attempt to close this one --

[GitHub] sijie commented on a change in pull request #275: BOOKKEEPER-1102: Fix BookKeeeperDiskSpaceWeightedLedgerPlacementTest

sijie commented on a change in pull request #275: BOOKKEEPER-1102: Fix BookKeeeperDiskSpaceWeightedLedgerPlacementTest URL: https://github.com/apache/bookkeeper/pull/275#discussion_r128890618 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieInfoReade

[GitHub] sijie commented on a change in pull request #275: BOOKKEEPER-1102: Fix BookKeeeperDiskSpaceWeightedLedgerPlacementTest

sijie commented on a change in pull request #275: BOOKKEEPER-1102: Fix BookKeeeperDiskSpaceWeightedLedgerPlacementTest URL: https://github.com/apache/bookkeeper/pull/275#discussion_r128890595 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieInfoReade

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128885419 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128886421 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128886421 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128885294 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128886088 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java ## @@ -

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128877828 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128852961 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128853567 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128877878 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128852961 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128885419 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128886267 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128878688 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128877406 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieInitializationTest.java #

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128852987 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128886137 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java ## @@ -857,7 +884,

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128885877 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128885174 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java ## @@ -149,6 +150,

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128853243 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128886088 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java ## @@ -

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128878334 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128877828 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128885294 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128852987 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128878869 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128851579 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128877724 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128885181 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java ## @@ -748,7 +751,

[GitHub] athanatos opened a new pull request #275: BOOKKEEPER-1102: Fix BookKeeeperDiskSpaceWeightedLedgerPlacementTest

athanatos opened a new pull request #275: BOOKKEEPER-1102: Fix BookKeeeperDiskSpaceWeightedLedgerPlacementTest URL: https://github.com/apache/bookkeeper/pull/275 BookieInfoReader: The previous syncronization logic wasn't really correct, and the logic at the top of the method was f

[jira] [Created] (BOOKKEEPER-1102) org.apache.bookkeeper.client.BookKeeperDiskSpaceWeightedLedgerPlacementTest.testDiskSpaceWeightedBookieSelectionWithBookiesBeingAdded is unreliable

Samuel Just created BOOKKEEPER-1102: --- Summary: org.apache.bookkeeper.client.BookKeeperDiskSpaceWeightedLedgerPlacementTest.testDiskSpaceWeightedBookieSelectionWithBookiesBeingAdded is unreliable Key: BOOKKEEPER-1102

[GitHub] arvindkandhare opened a new issue #274: Write benchmark fails with `BkNotEnoughBookiesException` even when enough bookies are available

arvindkandhare opened a new issue #274: Write benchmark fails with `BkNotEnoughBookiesException` even when enough bookies are available URL: https://github.com/apache/bookkeeper/issues/274 **BUG REPORT** 1. Please describe the issue you observed: - What did you do? Compile

Jenkins build is back to normal : bookkeeper-master #1825

See

Re: BookKeeper 4.5.0 performance regression ?

Il ven 21 lug 2017, 20:32 Sijie Guo ha scritto: > As the discussion in a separate thread, it might be making sense to check > what is the difference between using pooled allocator and unpooled > allocator using v3 protocol. Also considering comparing using heap buffer > and direct buffer as well.

Re: BookKeeper 4.5.0 performance regression ?

As the discussion in a separate thread, it might be making sense to check what is the difference between using pooled allocator and unpooled allocator using v3 protocol. Also considering comparing using heap buffer and direct buffer as well. I am suspecting this might contribute latency. - Sijie

Re: ByteBuf memory leak after Netty 4 switch on the client API

Il ven 21 lug 2017, 20:11 Sijie Guo ha scritto: > Checked the code and also confirmed with Matteo: > > - if you are using V3 protocol, all the ByteBuf are unpooled because of the > deserialization of protobuf. It already makes the copy of the memory coming > from Netty. so there is not memory lea

Re: ByteBuf memory leak after Netty 4 switch on the client API

Checked the code and also confirmed with Matteo: - if you are using V3 protocol, all the ByteBuf are unpooled because of the deserialization of protobuf. It already makes the copy of the memory coming from Netty. so there is not memory leak even you don't iterate over the enumeration. - if you are

Re: ByteBuf memory leak after Netty 4 switch on the client API

Il ven 21 lug 2017, 18:39 Sijie Guo ha scritto: > On Jul 21, 2017 9:25 AM, "Enrico Olivelli" wrote: > > Il ven 21 lug 2017, 18:19 Sijie Guo ha scritto: > > > On Jul 21, 2017 12:59 AM, "Enrico Olivelli" wrote: > > > > Hi, > > I have just file this issue > > https://github.com/apache/bookkeeper/

Re: ByteBuf memory leak after Netty 4 switch on the client API

On Jul 21, 2017 9:25 AM, "Enrico Olivelli" wrote: Il ven 21 lug 2017, 18:19 Sijie Guo ha scritto: > On Jul 21, 2017 12:59 AM, "Enrico Olivelli" wrote: > > Hi, > I have just file this issue > https://github.com/apache/bookkeeper/issues/271 > > After the switch to Netty 4 I noticed this "API cha

Re: ByteBuf memory leak after Netty 4 switch on the client API

Il ven 21 lug 2017, 18:19 Sijie Guo ha scritto: > On Jul 21, 2017 12:59 AM, "Enrico Olivelli" wrote: > > Hi, > I have just file this issue > https://github.com/apache/bookkeeper/issues/271 > > After the switch to Netty 4 I noticed this "API change", that is very > important to be documented and/

Re: ByteBuf memory leak after Netty 4 switch on the client API

On Jul 21, 2017 9:17 AM, "Enrico Olivelli" wrote: Il ven 21 lug 2017, 16:55 Enrico Olivelli ha scritto: > (I am writing comments and proposals on the issue, I don't know where is > the best place to talk) > https://github.com/apache/bookkeeper/issues/271 > > > I think that we could break existi

Re: ByteBuf memory leak after Netty 4 switch on the client API

On Jul 21, 2017 12:59 AM, "Enrico Olivelli" wrote: Hi, I have just file this issue https://github.com/apache/bookkeeper/issues/271 After the switch to Netty 4 I noticed this "API change", that is very important to be documented and/or to be addresses. I think documentation is important in this

Re: ByteBuf memory leak after Netty 4 switch on the client API

Il ven 21 lug 2017, 16:55 Enrico Olivelli ha scritto: > (I am writing comments and proposals on the issue, I don't know where is > the best place to talk) > https://github.com/apache/bookkeeper/issues/271 > > > I think that we could break existing downstream applications, we must > address this p

[GitHub] caiok commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-317041008 @jiazhai What are your concerns about this code duplication? I think providing a centos image for who is concerned about lice

Re: ByteBuf memory leak after Netty 4 switch on the client API

(I am writing comments and proposals on the issue, I don't know where is the best place to talk) https://github.com/apache/bookkeeper/issues/271 I think that we could break existing downstream applications, we must address this problem I think that we should change in a braking way the readEntri

[GitHub] eolivelli commented on issue #271: LedgerHandle#readEntries leaks ByteBufs if getEntry not called or getEntryInputStream() not called and closed

eolivelli commented on issue #271: LedgerHandle#readEntries leaks ByteBufs if getEntry not called or getEntryInputStream() not called and closed URL: https://github.com/apache/bookkeeper/issues/271#issuecomment-317019864 My proposal is not good, because the ByteBufInputStream will usually s

[GitHub] eolivelli commented on issue #271: LedgerHandle#readEntries leaks ByteBufs if getEntry not called or getEntryInputStream() not called and closed

eolivelli commented on issue #271: LedgerHandle#readEntries leaks ByteBufs if getEntry not called or getEntryInputStream() not called and closed URL: https://github.com/apache/bookkeeper/issues/271#issuecomment-317019864 My proposal is not good, because the ByteBufInputStream will usually s

Re: ByteBuf memory leak after Netty 4 switch on the client API

Can we also add some stats around this to track these. ? Discipline around memory release is new concept to Java world. On Fri, Jul 21, 2017 at 12:59 AM Enrico Olivelli wrote: > Hi, > I have just file this issue > https://github.com/apache/bookkeeper/issues/271 > > After the switch to Netty 4

[GitHub] eolivelli opened a new pull request #273: Provide a minimal test case using v2wireprotocol option

eolivelli opened a new pull request #273: Provide a minimal test case using v2wireprotocol option URL: https://github.com/apache/bookkeeper/pull/273 Add testcases on addEntry/readEntries and basic fencing This is an automate

[GitHub] eolivelli opened a new issue #272: Provide a minimal test case using v2wireprotocol option

eolivelli opened a new issue #272: Provide a minimal test case using v2wireprotocol option URL: https://github.com/apache/bookkeeper/issues/272 I would like to have at least a simple testcase around the UseV2WireProtocol feature ---

ByteBuf memory leak after Netty 4 switch on the client API

Hi, I have just file this issue https://github.com/apache/bookkeeper/issues/271 After the switch to Netty 4 I noticed this "API change", that is very important to be documented and/or to be addresses. Inside LedgerEntry object we retain a ByteBuf, which is turn is automatically 'released' only in

[GitHub] eolivelli opened a new issue #271: LedgerHandle#readEntries leaks ByteBufs if getEntry not called or getEntryInputStream() not called and closed

eolivelli opened a new issue #271: LedgerHandle#readEntries leaks ByteBufs if getEntry not called or getEntryInputStream() not called and closed URL: https://github.com/apache/bookkeeper/issues/271 After the switch to Netty 4 I noticed this import "API change", that is very important to be