eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128886137
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java ########## @@ -857,7 +884,13 @@ public synchronized void start() { ledgerStorage.start(); - syncThread.start(); + // check the bookie status to start with + if (forceReadOnly.get()) { Review comment: if force read only and read status from disk are mutually exclusive then this needs to be documented somewhere (that is, which one has precedence), right? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services