[GitHub] caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127387138 ## File path: docker/4.4.0-alpine/Dockerfile ## @@ -0,0 +1,59 @@ +FROM java:openjdk-8-jre-alpi

[GitHub] caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127384452 ## File path: docker/4.4.0-alpine/Dockerfile ## @@ -0,0 +1,59 @@ +FROM java:openjdk-8-jre-alpi

Re: BeWeekly Community Meeting

Thank you Enrico. Sorry that I missed the meeting due to jet lag. I will catch up the details in the minutes. - Sijie On Fri, Jul 14, 2017 at 12:03 AM, Enrico Olivelli wrote: > This is the link to the minutes > https://cwiki.apache.org/confluence/display/BOOKKEEPER/ > 2017-07-13+Meeting+Agenda

Re: BeWeekly Community Meeting

Thanks for the minutes. sorry for not able to join in because of network issue 2017年7月14日 上午12:03，"Enrico Olivelli" 写道： This is the link to the minutes https://cwiki.apache.org/confluence/display/BOOKKEEPER/ 2017-07-13+Meeting+Agenda Thank you to every one who attended the meeting! -- Enrico 20

Re: BeWeekly Community Meeting

This is the link to the minutes https://cwiki.apache.org/confluence/display/BOOKKEEPER/2017-07-13+Meeting+Agenda Thank you to every one who attended the meeting! -- Enrico 2017-07-13 15:59 GMT+02:00 Venkateswara Rao Jujjuri : > Today is my duty to drop kids, and I can join only after 8:30. Pleas

[GitHub] caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127252807 ## File path: docker/Makefile ## @@ -0,0 +1,180 @@ + +VERSION ?= 4.4.0-alpine +IMAGE ?= caiok/

[GitHub] caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127252406 ## File path: docker/Makefile ## @@ -0,0 +1,180 @@ + +VERSION ?= 4.4.0-alpine +IMAGE ?= caiok/

[GitHub] caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127249570 ## File path: docker/4.4.0-alpine/healthcheck.sh ## @@ -0,0 +1,6 @@ +#!/bin/bash + +set -x -e

[GitHub] caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127248747 ## File path: docker/4.4.0-alpine/Dockerfile ## @@ -0,0 +1,59 @@ +FROM java:openjdk-8-jre-alpi

[GitHub] caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127248390 ## File path: docker/4.4.0-alpine/Dockerfile ## @@ -0,0 +1,59 @@ +FROM java:openjdk-8-jre-alpi

[GitHub] caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127248048 ## File path: docker/4.4.0-alpine/Dockerfile ## @@ -0,0 +1,59 @@ +FROM java:openjdk-8-jre-alpi

[GitHub] caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127243877 ## File path: docker/4.4.0-alpine/Dockerfile ## @@ -0,0 +1,59 @@ +FROM java:openjdk-8-jre-alpi

[GitHub] caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127238474 ## File path: docker/4.4.0-alpine/Dockerfile ## @@ -0,0 +1,59 @@ +FROM java:openjdk-8-jre-alpi

[GitHub] caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127236866 ## File path: docker/4.4.0-alpine/Dockerfile ## @@ -0,0 +1,59 @@ +FROM java:openjdk-8-jre-alpi

[GitHub] eolivelli commented on issue #231: Issue 230: Add Checkstyle to the build process (Part 1)

eolivelli commented on issue #231: Issue 230: Add Checkstyle to the build process (Part 1) URL: https://github.com/apache/bookkeeper/pull/231#issuecomment-315095108 @sijie should we merge this patch now as it is ? This is an

[GitHub] caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127232920 ## File path: docker/Makefile ## @@ -0,0 +1,180 @@ + +VERSION ?= 4.4.0-alpine +IMAGE ?= caiok/

[GitHub] eolivelli commented on issue #233: WIP - Issue 232: Add code-coverage report

eolivelli commented on issue #233: WIP - Issue 232: Add code-coverage report URL: https://github.com/apache/bookkeeper/pull/233#issuecomment-315094588 Updated the PR with cobertura + coveralls.io as DL does This is an automat

[GitHub] caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127232485 ## File path: docker/4.4.0-alpine/run.sh ## @@ -0,0 +1,68 @@ +#/bin/bash + +# -- #

[GitHub] eolivelli commented on issue #232: Add code-coverage report using JaCoCo

eolivelli commented on issue #232: Add code-coverage report using JaCoCo URL: https://github.com/apache/bookkeeper/issues/232#issuecomment-315092290 in coveralls.io docs it seems that the best java8 support is with JaCoCo https://github.com/trautonen/coveralls-maven-plugin -

[GitHub] eolivelli commented on issue #232: Add code-coverage report using JaCoCo

eolivelli commented on issue #232: Add code-coverage report using JaCoCo URL: https://github.com/apache/bookkeeper/issues/232#issuecomment-315085394 @sijie it seems that DL uses Coveralls + Cobertura, I will try with Cobertura https://github.com/apache/incubator-distributedlog/blob/mast

Re: BeWeekly Community Meeting

Today is my duty to drop kids, and I can join only after 8:30. Please go ahead and I will catch the second half. Thanks, JV On Thu, Jul 13, 2017 at 3:58 AM, Enrico Olivelli wrote: > Hi, > this is just a reminder and invitation for all the new contributors (like > David) to our Community Meeting

[GitHub] eolivelli commented on issue #232: Add code-coverage report using JaCoCo

eolivelli commented on issue #232: Add code-coverage report using JaCoCo URL: https://github.com/apache/bookkeeper/issues/232#issuecomment-315085394 @sijie it seems that DL uses Overalls + Cobertura, I will try with Cobertura https://github.com/apache/incubator-distributedlog/blob/master

Build failed in Jenkins: bookkeeper-master #1814

See Changes: [jiazhai] ISSUE #239: typo in class name SpeculativeRequestExecutor (#240) -- [...truncated 508.50 KB...] Running org.apache.bookkeeper.util.collections.Conc

[GitHub] eolivelli commented on issue #240: ISSUE #239: typo in class name SpeculativeRequestExecutor

eolivelli commented on issue #240: ISSUE #239: typo in class name SpeculativeRequestExecutor URL: https://github.com/apache/bookkeeper/pull/240#issuecomment-315052197 @sigee @jiazhai this is the issue #241 This is an automa

[GitHub] eolivelli opened a new issue #241: Merge script does not deal well with non-ascii names of reviewers

eolivelli opened a new issue #241: Merge script does not deal well with non-ascii names of reviewers URL: https://github.com/apache/bookkeeper/issues/241 - What did you do? There is an error in the bk-merge-pr.py script in case of reviewers with non-ascii characters in name - Wha

BeWeekly Community Meeting

Hi, this is just a reminder and invitation for all the new contributors (like David) to our Community Meeting. Every two weeks we 'meet' in Hangout to talk about the status of the project and the current activity. Feel free to join, this is the link our Wiki, it contains the updated link to the ha

[GitHub] eolivelli commented on issue #240: ISSUE #239: typo in class name SpeculativeRequestExecutor

eolivelli commented on issue #240: ISSUE #239: typo in class name SpeculativeRequestExecutor URL: https://github.com/apache/bookkeeper/pull/240#issuecomment-315040278 @sigee the problem is not for @eribeiro, it is only for our internal commit/merge/push procedure. we will update it. At

[GitHub] sigee commented on issue #240: ISSUE #239: typo in class name SpeculativeRequestExecutor

sigee commented on issue #240: ISSUE #239: typo in class name SpeculativeRequestExecutor URL: https://github.com/apache/bookkeeper/pull/240#issuecomment-315030448 @eribeiro, Sorry. I'm hungarian. My name contains special characters. Would you like me to remove them from my name?

[GitHub] eolivelli commented on issue #240: ISSUE #239: typo in class name SpeculativeRequestExecutor

eolivelli commented on issue #240: ISSUE #239: typo in class name SpeculativeRequestExecutor URL: https://github.com/apache/bookkeeper/pull/240#issuecomment-315027977 @jiazhai I think that the problem is in dealing with the name of @sigee which contains non-ascii 7bit characters

[GitHub] jiazhai commented on issue #239: Typo in class name SpeculativeRequestExectuor

jiazhai commented on issue #239: Typo in class name SpeculativeRequestExectuor URL: https://github.com/apache/bookkeeper/issues/239#issuecomment-315027011 Merged by PR #240 This is an automated message from the Apache Git Se

[GitHub] jiazhai closed issue #239: Typo in class name SpeculativeRequestExectuor

jiazhai closed issue #239: Typo in class name SpeculativeRequestExectuor URL: https://github.com/apache/bookkeeper/issues/239 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] jiazhai closed pull request #240: ISSUE #239: typo in class name SpeculativeRequestExecutor

jiazhai closed pull request #240: ISSUE #239: typo in class name SpeculativeRequestExecutor URL: https://github.com/apache/bookkeeper/pull/240 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] jiazhai commented on issue #240: ISSUE #239: typo in class name SpeculativeRequestExecutor

jiazhai commented on issue #240: ISSUE #239: typo in class name SpeculativeRequestExecutor URL: https://github.com/apache/bookkeeper/pull/240#issuecomment-315026313 seems merge script meet this error: ``` (master) python dev/bk-merge-pr.py git rev-parse --abbrev-ref HEAD Which p

[GitHub] jiazhai commented on issue #240: ISSUE #239: typo in class name SpeculativeRequestExecutor

jiazhai commented on issue #240: ISSUE #239: typo in class name SpeculativeRequestExecutor URL: https://github.com/apache/bookkeeper/pull/240#issuecomment-315026313 seems merge script meet this error: ``` (master) python dev/bk-merge-pr.py git rev-parse --abbrev-ref HEAD Which p

[GitHub] merlimat commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes

merlimat commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes URL: https://github.com/apache/bookkeeper/pull/220#discussion_r127155264 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfo.java ##

[GitHub] merlimat commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes

merlimat commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes URL: https://github.com/apache/bookkeeper/pull/220#discussion_r127157862 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedAndE

[GitHub] merlimat commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes

merlimat commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes URL: https://github.com/apache/bookkeeper/pull/220#discussion_r127154693 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfo.java ##

[GitHub] merlimat commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes

merlimat commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes URL: https://github.com/apache/bookkeeper/pull/220#discussion_r127152321 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfo.java ##

[GitHub] merlimat commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes

merlimat commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes URL: https://github.com/apache/bookkeeper/pull/220#discussion_r127157308 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.

[GitHub] eolivelli commented on issue #81: BOOKKEEPER-753: Bookie should run garbage collection before startup when all directories became full

eolivelli commented on issue #81: BOOKKEEPER-753: Bookie should run garbage collection before startup when all directories became full URL: https://github.com/apache/bookkeeper/pull/81#issuecomment-314996409 @sigee we are not talking about JVM GC but the GC of the Bookie that is the auto c

[GitHub] sigee commented on issue #81: BOOKKEEPER-753: Bookie should run garbage collection before startup when all directories became full

sigee commented on issue #81: BOOKKEEPER-753: Bookie should run garbage collection before startup when all directories became full URL: https://github.com/apache/bookkeeper/pull/81#issuecomment-314996052 IMHO It is a terrible practice to use the garbage collector because the use of it c

Re: BookKeeper 4.5.0 performance regression ?

2017-07-13 4:11 GMT+02:00 Sijie Guo : > On Wed, Jul 12, 2017 at 10:35 PM, Enrico Olivelli > wrote: > > > Sijie, JV, just a recap my point of view: > > - considering latency = "time for asynchAddEntry to complete" > > - there is a some difference from 4.4 and 4.5 in the usage of memory, but > > no