caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an 
official bookkeeper docker image
URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127243877
 
 

 ##########
 File path: docker/4.4.0-alpine/Dockerfile
 ##########
 @@ -0,0 +1,59 @@
+FROM java:openjdk-8-jre-alpine
+MAINTAINER Francesco Caliumi <francesco.cali...@gmail.com>
+
+# Install required packages
+RUN apk add --no-cache \
+    bash \
+    su-exec
+
+ENV ZK_SERVERS= \
+    BK_USER=bookkeeper \
+    BK_PORT= \
+    BK_BUILD_PORT=3181 \
+    BOOKIE_OPTS="" \
+    BK_JOURNAL_DIR=/data/journal \
 
 Review comment:
   @sijie 
   1) IMO it's not particularly relevant because it's just a docker container 
internal dir and no other process are going to run in it out of bk
   2) The env variables BK_xxx_DIR are not in my opinion particularly useful to 
set up, being an internal of docker container. For achieving your configuration 
one has only to mount that journal-0, journal-1 dirs in docker container. If 
it's not clear I could explain it more in depth
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to