Approved pending pull requests merge order

Hi all, (just sending this email as we discussed about this topic at the meeting, without any decision) There is a bunch of "approved" pull requests which are falling into "conflict mode" due to minor changes appeared in recent commits https://github.com/apache/bookkeeper/pull/127 BOOKKEEPER-1028

[GitHub] eolivelli closed pull request #227: Add missed tests for SortedLedgerStorage

eolivelli closed pull request #227: Add missed tests for SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/227 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] eolivelli commented on a change in pull request #229: Issue 228: BookKeeper Server: Index Page Management Memory Growth

eolivelli commented on a change in pull request #229: Issue 228: BookKeeper Server: Index Page Management Memory Growth URL: https://github.com/apache/bookkeeper/pull/229#discussion_r125158396 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/IndexInMemPage

[jira] [Resolved] (BOOKKEEPER-772) Reorder read sequnce

[ https://issues.apache.org/jira/browse/BOOKKEEPER-772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jia Zhai resolved BOOKKEEPER-772. - Resolution: Fixed https://github.com/apache/bookkeeper/pull/224 merged it. > Reorder read seq

[GitHub] jiazhai closed pull request #224: BOOKKEEPER-772: Reorder Read Sequence

jiazhai closed pull request #224: BOOKKEEPER-772: Reorder Read Sequence URL: https://github.com/apache/bookkeeper/pull/224 This is an automated message from the Apache Git Service. To respond to the message, please log on Gi

[GitHub] jiazhai commented on issue #223: Clean up code rots

jiazhai commented on issue #223: Clean up code rots URL: https://github.com/apache/bookkeeper/issues/223#issuecomment-312776571 Merged by PR #217 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] jiazhai closed issue #223: Clean up code rots

jiazhai closed issue #223: Clean up code rots URL: https://github.com/apache/bookkeeper/issues/223 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL abo

[GitHub] jiazhai closed pull request #217: Issue 223: Code cleanups

jiazhai closed pull request #217: Issue 223: Code cleanups URL: https://github.com/apache/bookkeeper/pull/217 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] jiazhai commented on issue #217: Issue 223: Code cleanups

jiazhai commented on issue #217: Issue 223: Code cleanups URL: https://github.com/apache/bookkeeper/pull/217#issuecomment-312776133 @sijie The merge option issue has been fixed by INFRA team. Now we only have "squash and merge". And thanks @eolivelli for the explanation. Now seems it is

[GitHub] jiazhai closed issue #225: Remove Parameterized from CompactionTest

jiazhai closed issue #225: Remove Parameterized from CompactionTest URL: https://github.com/apache/bookkeeper/issues/225 This is an automated message from the Apache Git Service. To respond to the message, please log on GitH

[GitHub] jiazhai commented on issue #225: Remove Parameterized from CompactionTest

jiazhai commented on issue #225: Remove Parameterized from CompactionTest URL: https://github.com/apache/bookkeeper/issues/225#issuecomment-312775449 Merged by PR #226 This is an automated message from the Apache Git Service

[GitHub] jiazhai closed pull request #226: Issue 225: Remove Parameterized from CompactionTest

jiazhai closed pull request #226: Issue 225: Remove Parameterized from CompactionTest URL: https://github.com/apache/bookkeeper/pull/226 This is an automated message from the Apache Git Service. To respond to the message,

Re: Git protected branches

Agree to have them protected. Currently, seems these branches are not protected, at least master branch is not. The merge button is still available even "Jenkins: Maven clean install — Build finished." in some of PRs We may first need to make the test st

Re: [DISCUSS] BookKeeper - A High Performance and Low Latency Storage Service

Everything said on this thread is important and accurate. The description on the website must be a story rather than a blurb. We should talk about BK's strengths as Enrico pointed out, and because of its versatility it became fundamental building block for various other technologies and usecases. I

Git protected branches

Hi, I don't know current configuration but I would like to ensure that our release branches, that is master and branch-xx are 'protected'. I mean at least that 'force push' must be forbidden to everyone. In github it is simple to enable such protection, see https://help.github.com/articles/about-p

[GitHub] reddycharan commented on issue #127: BOOKKEEPER-1028 and BOOKKEEPER-1029

reddycharan commented on issue #127: BOOKKEEPER-1028 and BOOKKEEPER-1029 URL: https://github.com/apache/bookkeeper/pull/127#issuecomment-312699778 @sijie @eolivelli fixed all findbug errors. this commit is good to go. This is

[GitHub] reddycharan commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

reddycharan commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication URL: https://github.com/apache/bookkeeper/pull/189#issuecomment-312699560 @sijie if you don't have any more comments, this commit is good to go. --

Re: [DISCUSS] BookKeeper - A High Performance and Low Latency Storage Service

On Mon, Jul 3, 2017 at 1:35 AM, Enrico Olivelli wrote: > 2017-07-03 7:00 GMT+02:00 Sijie Guo : > > Hi all, > > > > It has been almost 6-7 years since Apache BookKeeper was born. Apache > > BookKeeper has already grown beyond a WAL system. Both Twitter and Yahoo > > have used it as their storage f

[GitHub] sijie commented on issue #217: Issue 223: Code cleanups

sijie commented on issue #217: Issue 223: Code cleanups URL: https://github.com/apache/bookkeeper/pull/217#issuecomment-312660858 okay This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] eolivelli commented on issue #217: Issue 223: Code cleanups

eolivelli commented on issue #217: Issue 223: Code cleanups URL: https://github.com/apache/bookkeeper/pull/217#issuecomment-312653622 @sijie I think that the problem is simply that the patch could not be applied without resolving conflicts. Aside from this I think that the way we are

[GitHub] sijie commented on issue #217: Issue 223: Code cleanups

sijie commented on issue #217: Issue 223: Code cleanups URL: https://github.com/apache/bookkeeper/pull/217#issuecomment-312648742 Re ""This branch cannot be rebased due to conflicts"" What should I do to fix it? I don't think you need to rebase your pull request. When we merge the pu

[GitHub] eolivelli commented on issue #217: Issue 223: Code cleanups

eolivelli commented on issue #217: Issue 223: Code cleanups URL: https://github.com/apache/bookkeeper/pull/217#issuecomment-312620002 @sigee you are right, usually we prefer to append only commits to existing PRs so that the conversation is more fluent. Sometimes it is not possible...

[GitHub] sigee commented on issue #217: Issue 223: Code cleanups

sigee commented on issue #217: Issue 223: Code cleanups URL: https://github.com/apache/bookkeeper/pull/217#issuecomment-312607890 @eolivelli, I've rebased my changes. Unfortunatelly I've needed to do a force push (this is why I didn't want it) with the new commits. (Rebase changed their ha

[GitHub] eolivelli commented on issue #217: Issue 223: Code cleanups

eolivelli commented on issue #217: Issue 223: Code cleanups URL: https://github.com/apache/bookkeeper/pull/217#issuecomment-312602273 Just issue a "git rebase master", this will be the output. Usually I am more comfortable with "git rebase master" instead of merging from master. We on

[GitHub] sigee commented on issue #217: Issue 223: Code cleanups

sigee commented on issue #217: Issue 223: Code cleanups URL: https://github.com/apache/bookkeeper/pull/217#issuecomment-312596254 @jiazhai, @eolivelli, @sijie, I've merged origin/master into my branch to resolve conflicts, but I see the following message: "This branch cannot be rebased due

Re: [DISCUSS] BookKeeper - A High Performance and Low Latency Storage Service

Agree, BookKeeper is far more than a WAL system, and maybe even more than "a High Performance and Low Latency Storage Service (that optimised for immutable/append-only data)", since the persistence and consistences. >From my view, to us engineers, WAL may be a good point, It means a lot of flexible

Re: Official Bookkeeper Docker Image

Hi Francesco, Is there any help wanted on this task? I would like to help on it, and pick this up, if you are too busy recently. :) Thanks a lot. -Jia On Thu, Jun 29, 2017 at 10:52 PM, Francesco Caliumi - Diennea < francesco.cali...@diennea.com> wrote: > I apologize for the delay answering PR c

Re: [DISCUSS] BookKeeper - A High Performance and Low Latency Storage Service

2017-07-03 7:00 GMT+02:00 Sijie Guo : > Hi all, > > It has been almost 6-7 years since Apache BookKeeper was born. Apache > BookKeeper has already grown beyond a WAL system. Both Twitter and Yahoo > have used it as their storage foundation for their messaging systems, > Salesforce is using it for s