eolivelli commented on issue #217: Issue 223: Code cleanups URL: https://github.com/apache/bookkeeper/pull/217#issuecomment-312653622 @sijie I think that the problem is simply that the patch could not be applied without resolving conflicts. Aside from this I think that the way we are merging patch leads to a linear git history, all made of "fast-forwards", which is equivalent to rebasing before merging I think, but I am not sure, that "git merge --squash" is like "git rebase -i" but automatic ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services