[GitHub] sijie commented on a change in pull request #190: BOOKKEEPER-1034: Bookie start in RO when diskfull

sijie commented on a change in pull request #190: BOOKKEEPER-1034: Bookie start in RO when diskfull URL: https://github.com/apache/bookkeeper/pull/190#discussion_r124972129 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java ## @@ -

[GitHub] sijie opened a new issue #221: TestAuth#testCloseMethodCalledOnAuthProvider is failing

sijie opened a new issue #221: TestAuth#testCloseMethodCalledOnAuthProvider is failing URL: https://github.com/apache/bookkeeper/issues/221 **BUG REPORT** 1. Please describe the issue you observed: - What did you do? Run TestAuth. - What did you expect to se

[GitHub] bookkeeper issue #221: TestAuth#testCloseMethodCalledOnAuthProvider is faili...

GitHub user sijie opened an issue: https://github.com/apache/bookkeeper/issues/221 TestAuth#testCloseMethodCalledOnAuthProvider is failing **BUG REPORT** 1. Please describe the issue you observed: - What did you do? Run TestAuth. - What did y

[GitHub] jiazhai closed issue #198: TestBackwardCompat.testCompat410 often fails due to io.netty.util.IllegalReferenceCountException

jiazhai closed issue #198: TestBackwardCompat.testCompat410 often fails due to io.netty.util.IllegalReferenceCountException URL: https://github.com/apache/bookkeeper/issues/198 This is an automated message from the Apache G

[GitHub] jiazhai closed pull request #219: Issue 198: TestBackwardCompat.testCompat410 often fails due to io.netty.util.IllegalReferenceCountException

jiazhai closed pull request #219: Issue 198: TestBackwardCompat.testCompat410 often fails due to io.netty.util.IllegalReferenceCountException URL: https://github.com/apache/bookkeeper/pull/219 This is an automated message f

[GitHub] bookkeeper issue #198: TestBackwardCompat.testCompat410 often fails due to i...

Github user jiazhai closed the issue at: https://github.com/apache/bookkeeper/issues/198 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] bookkeeper pull request #219: Issue 198: TestBackwardCompat.testCompat410 of...

Github user jiazhai closed the pull request at: https://github.com/apache/bookkeeper/pull/219 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (BOOKKEEPER-1095) Long Poll - Client side changes

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069289#comment-16069289 ] ASF GitHub Bot commented on BOOKKEEPER-1095: GitHub user sijie opened a p

[GitHub] bookkeeper pull request #220: BOOKKEEPER-1095: Server and Client Side Change...

GitHub user sijie opened a pull request: https://github.com/apache/bookkeeper/pull/220 BOOKKEEPER-1095: Server and Client Side Changes Descriptions of the changes in this PR: - changes on FileInfo to support notifications on LAC changes - a new ReadEntryLongPollV3 proces

[GitHub] sijie opened a new pull request #220: BOOKKEEPER-1095: Server and Client Side Changes

sijie opened a new pull request #220: BOOKKEEPER-1095: Server and Client Side Changes URL: https://github.com/apache/bookkeeper/pull/220 Descriptions of the changes in this PR: - changes on FileInfo to support notifications on LAC changes - a new ReadEntryLongPollV3 processor to p

[jira] [Resolved] (BOOKKEEPER-1095) Long Poll - Client side changes

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo resolved BOOKKEEPER-1095. --- Resolution: Duplicate > Long Poll - Client side changes > ---

[jira] [Updated] (BOOKKEEPER-1094) Long Poll - Server and Client Side Changes

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-1094: -- Summary: Long Poll - Server and Client Side Changes (was: Long Poll - Server Side Changes)

Re: Too many emails on the mailing list?

Filed an INFRA ticket: https://issues.apache.org/jira/browse/INFRA-14473 On Thu, Jun 29, 2017 at 3:15 PM, Sijie Guo wrote: > I have the same feeling. I think the git integration with email somehow is > duplicated when the gitbox was enabled. > > - Sijie > > > On Thu, Jun 29, 2017 at 3:12 PM, Ven

Re: Too many emails on the mailing list?

I have the same feeling. I think the git integration with email somehow is duplicated when the gitbox was enabled. - Sijie On Thu, Jun 29, 2017 at 3:12 PM, Venkateswara Rao Jujjuri wrote: > I get multiple emails for every comment added or any action taken. This is > really frustrating. > For ex

[GitHub] sijie closed pull request #202: BOOKKEEPER-759: Delay Ensemble Change & Disable Ensemble Change

sijie closed pull request #202: BOOKKEEPER-759: Delay Ensemble Change & Disable Ensemble Change URL: https://github.com/apache/bookkeeper/pull/202 This is an automated message from the Apache Git Service. To respond to the

Too many emails on the mailing list?

I get multiple emails for every comment added or any action taken. This is really frustrating. For example when Sijie closed Issue 209 I got 7 emails [image: Inline image 1] Everyone feeling this pain? Any easy way to avoid duplication? -- Jvrao --- First they ignore you, then they laugh at you

[GitHub] bookkeeper pull request #202: BOOKKEEPER-759: Delay Ensemble Change & Disabl...

Github user sijie closed the pull request at: https://github.com/apache/bookkeeper/pull/202 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[jira] [Commented] (BOOKKEEPER-759) bookkeeper: delay ensemble change if it doesn't break ack quorum requirement

[ https://issues.apache.org/jira/browse/BOOKKEEPER-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069081#comment-16069081 ] ASF GitHub Bot commented on BOOKKEEPER-759: --- Github user sijie closed the pu

[GitHub] sijie closed issue #209: Introduce a Speculative Read/Read LAC policy

sijie closed issue #209: Introduce a Speculative Read/Read LAC policy URL: https://github.com/apache/bookkeeper/issues/209 This is an automated message from the Apache Git Service. To respond to the message, please log on Gi

[GitHub] bookkeeper issue #209: Introduce a Speculative Read/Read LAC policy

Github user sijie closed the issue at: https://github.com/apache/bookkeeper/issues/209 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] bookkeeper pull request #200: Issue 209: Introduce Speculative Read/Read LAC...

Github user sijie closed the pull request at: https://github.com/apache/bookkeeper/pull/200 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] sijie closed pull request #200: Issue 209: Introduce Speculative Read/Read LAC policy

sijie closed pull request #200: Issue 209: Introduce Speculative Read/Read LAC policy URL: https://github.com/apache/bookkeeper/pull/200 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] bookkeeper pull request #199: Issue 207: change the HashSet to BitSet to han...

Github user sijie closed the pull request at: https://github.com/apache/bookkeeper/pull/199 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] bookkeeper issue #207: Change the HashSet to BitSet to handle duplicated boo...

Github user sijie closed the issue at: https://github.com/apache/bookkeeper/issues/207 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] sijie closed pull request #199: Issue 207: change the HashSet to BitSet to handle duplicated bookies on reading entries

sijie closed pull request #199: Issue 207: change the HashSet to BitSet to handle duplicated bookies on reading entries URL: https://github.com/apache/bookkeeper/pull/199 This is an automated message from the Apache Git Ser

[GitHub] sijie closed issue #207: Change the HashSet to BitSet to handle duplicated bookies on reading entries

sijie closed issue #207: Change the HashSet to BitSet to handle duplicated bookies on reading entries URL: https://github.com/apache/bookkeeper/issues/207 This is an automated message from the Apache Git Service. To respond

[GitHub] sijie opened a new pull request #219: Issue 198: TestBackwardCompat.testCompat410 often fails due to io.netty.util.IllegalReferenceCountException

sijie opened a new pull request #219: Issue 198: TestBackwardCompat.testCompat410 often fails due to io.netty.util.IllegalReferenceCountException URL: https://github.com/apache/bookkeeper/pull/219 Descriptions of the changes in this PR: ---

[GitHub] bookkeeper pull request #219: Issue 198: TestBackwardCompat.testCompat410 of...

GitHub user sijie opened a pull request: https://github.com/apache/bookkeeper/pull/219 Issue 198: TestBackwardCompat.testCompat410 often fails due to io.netty.util.IllegalReferenceCountException Descriptions of the changes in this PR: You can merge this pull request into a Gi

[GitHub] eolivelli commented on issue #198: TestBackwardCompat.testCompat410 often fails due to io.netty.util.IllegalReferenceCountException

eolivelli commented on issue #198: TestBackwardCompat.testCompat410 often fails due to io.netty.util.IllegalReferenceCountException URL: https://github.com/apache/bookkeeper/issues/198#issuecomment-312113298 @kishorekasi my error report was against an old version of the master. I think t

[GitHub] bookkeeper issue #198: TestBackwardCompat.testCompat410 often fails due to i...

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/issues/198 @kishorekasi my error report was against an old version of the master. I think that @merlimat suggestion is good. Can you give it a try? --- If your project is set up for it, you can repl

[GitHub] bookkeeper issue #206: Issue-196 Create Jenkins configuration using OpenStac...

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/206 @sijie I think that the readme file would be enough to start. It is important to use actual version, the trunk, of jenkins job builder, the latest released version is somehow buggy and does

[GitHub] eolivelli commented on issue #206: Issue-196 Create Jenkins configuration using OpenStack Jenkins Job Builder

eolivelli commented on issue #206: Issue-196 Create Jenkins configuration using OpenStack Jenkins Job Builder URL: https://github.com/apache/bookkeeper/pull/206#issuecomment-312109880 @sijie I think that the readme file would be enough to start. It is important to use actual version, the

[GitHub] sijie commented on a change in pull request #214: Fix ByteBuf refcount release

sijie commented on a change in pull request #214: Fix ByteBuf refcount release URL: https://github.com/apache/bookkeeper/pull/214#discussion_r124899962 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtoEncoding.java ## @@ -155,9 +155,8 @@

[GitHub] sijie commented on issue #198: TestBackwardCompat.testCompat410 often fails due to io.netty.util.IllegalReferenceCountException

sijie commented on issue #198: TestBackwardCompat.testCompat410 often fails due to io.netty.util.IllegalReferenceCountException URL: https://github.com/apache/bookkeeper/issues/198#issuecomment-312088728 @eolivelli @kishorekasi @merlimat and me were looking together at this issue.

[GitHub] bookkeeper issue #198: TestBackwardCompat.testCompat410 often fails due to i...

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/issues/198 @eolivelli @kishorekasi @merlimat and me were looking together at this issue. @merlimat found the problem on how do we handling the invalid op code in v2 protocol. in TestBackw

[GitHub] bookkeeper issue #218: NPE at TestLongZkLedgerIdGenerator.testGenerateLedger...

GitHub user sijie opened an issue: https://github.com/apache/bookkeeper/issues/218 NPE at TestLongZkLedgerIdGenerator.testGenerateLedgerId **BUG REPORT** 1. Please describe the issue you observed: - What did you do? I found the failed test case in CI b

[GitHub] sijie opened a new issue #218: NPE at TestLongZkLedgerIdGenerator.testGenerateLedgerId

sijie opened a new issue #218: NPE at TestLongZkLedgerIdGenerator.testGenerateLedgerId URL: https://github.com/apache/bookkeeper/issues/218 **BUG REPORT** 1. Please describe the issue you observed: - What did you do? I found the failed test case in CI build. https:

[GitHub] kishorekasi commented on issue #214: Fix ByteBuf refcount release

kishorekasi commented on issue #214: Fix ByteBuf refcount release URL: https://github.com/apache/bookkeeper/pull/214#issuecomment-312070962 @eolivelli Please confirm if your branch is different than bookkeeper master. From the stack trace in Journal.run() there seems to be a line of code r

[GitHub] bookkeeper issue #214: Fix ByteBuf refcount release

Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/214 @eolivelli Please confirm if your branch is different than bookkeeper master. From the stack trace in Journal.run() there seems to be a line of code releasing ByteBuf. I don't see that in mas

[GitHub] bookkeeper issue #205: Issue 208: Improve ledger fence logic

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/205 @jvrao I have addressed your comments. please take a look and let me know if it works for you. I'd like to move forward with other pull requests. --- If your project is set up for it, you can repl

[GitHub] sijie commented on issue #205: Issue 208: Improve ledger fence logic

sijie commented on issue #205: Issue 208: Improve ledger fence logic URL: https://github.com/apache/bookkeeper/pull/205#issuecomment-312052856 @jvrao I have addressed your comments. please take a look and let me know if it works for you. I'd like to move forward with other pull requests.

[GitHub] sijie commented on a change in pull request #205: Issue 208: Improve ledger fence logic

sijie commented on a change in pull request #205: Issue 208: Improve ledger fence logic URL: https://github.com/apache/bookkeeper/pull/205#discussion_r124876416 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/IndexPersistenceMgr.java ## @@ -177,

[GitHub] sijie commented on a change in pull request #205: Issue 208: Improve ledger fence logic

sijie commented on a change in pull request #205: Issue 208: Improve ledger fence logic URL: https://github.com/apache/bookkeeper/pull/205#discussion_r124876380 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.java ## @@ -81,

[GitHub] sijie commented on issue #206: Issue-196 Create Jenkins configuration using OpenStack Jenkins Job Builder

sijie commented on issue #206: Issue-196 Create Jenkins configuration using OpenStack Jenkins Job Builder URL: https://github.com/apache/bookkeeper/pull/206#issuecomment-312050685 @eolivelli @nicoloboschi can you document and provide instructions on how to verify this? -

[GitHub] bookkeeper issue #206: Issue-196 Create Jenkins configuration using OpenStac...

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/206 @eolivelli @nicoloboschi can you document and provide instructions on how to verify this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] bookkeeper issue #217: Code cleanups

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/217 I am okay with using a checkstyle plugin. it shouldn't be a big deal with existing pull requests. I am fine with merging this change and having a separate follow up jira to enable checksty

[GitHub] sijie commented on issue #217: Code cleanups

sijie commented on issue #217: Code cleanups URL: https://github.com/apache/bookkeeper/pull/217#issuecomment-312048837 I am okay with using a checkstyle plugin. it shouldn't be a big deal with existing pull requests. I am fine with merging this change and having a separate follow up

[jira] [Commented] (BOOKKEEPER-1033) Handle DirsPartitionDuplication

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068720#comment-16068720 ] ASF GitHub Bot commented on BOOKKEEPER-1033: Github user sijie commented

[GitHub] bookkeeper issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/189 @jvrao @reddycharan - that's one of my comments as well. because I don't have a clear picture what directories are concerned. --- If your project is set up for it, you can reply to this email and

[GitHub] sijie commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

sijie commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication URL: https://github.com/apache/bookkeeper/pull/189#issuecomment-312048047 @jvrao @reddycharan - that's one of my comments as well. because I don't have a clear picture what directories are concerned.

[GitHub] reddycharan commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

reddycharan commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication URL: https://github.com/apache/bookkeeper/pull/189#issuecomment-312035154 with this change they introduced multiplejournals/journaldirectories - https://github.com/apache/bookkeeper/commit/123eccd435a4a96

[jira] [Commented] (BOOKKEEPER-1033) Handle DirsPartitionDuplication

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068658#comment-16068658 ] ASF GitHub Bot commented on BOOKKEEPER-1033: Github user reddycharan comm

[GitHub] bookkeeper issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

Github user reddycharan commented on the issue: https://github.com/apache/bookkeeper/pull/189 with this change they introduced multiplejournals/journaldirectories - https://github.com/apache/bookkeeper/commit/123eccd435a4a96a9147ed4a24efbe9025fe79ba --- If your project is set up for

[jira] [Commented] (BOOKKEEPER-1033) Handle DirsPartitionDuplication

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068642#comment-16068642 ] ASF GitHub Bot commented on BOOKKEEPER-1033: Github user jvrao commented

[GitHub] jvrao commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

jvrao commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication URL: https://github.com/apache/bookkeeper/pull/189#issuecomment-312033277 In my comments I called journal dirs. but infact they are ledger dirs. Typos from my side. As far as journals are concerned, we can ha

[GitHub] bookkeeper issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

Github user jvrao commented on the issue: https://github.com/apache/bookkeeper/pull/189 In my comments I called journal dirs. but infact they are ledger dirs. Typos from my side. As far as journals are concerned, we can have only one journal dir right? @reddycharan what do you mea

[jira] [Commented] (BOOKKEEPER-1033) Handle DirsPartitionDuplication

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068636#comment-16068636 ] ASF GitHub Bot commented on BOOKKEEPER-1033: Github user reddycharan comm

[GitHub] reddycharan commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

reddycharan commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication URL: https://github.com/apache/bookkeeper/pull/189#issuecomment-312032618 and yes, I didn't add check for journaldirectories. Will add check for journaldirectories also. Thanks for pointing that out. --

[GitHub] bookkeeper issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

Github user reddycharan commented on the issue: https://github.com/apache/bookkeeper/pull/189 and yes, I didn't add check for journaldirectories. Will add check for journaldirectories also. Thanks for pointing that out. --- If your project is set up for it, you can reply to this emai

[GitHub] bookkeeper issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

Github user reddycharan commented on the issue: https://github.com/apache/bookkeeper/pull/189 @sijie considering we have come to an understanding regarding the need and purpose of this change, I'm keeping the logic as it is and just going to change the config variable name as we discu

[jira] [Commented] (BOOKKEEPER-1033) Handle DirsPartitionDuplication

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068599#comment-16068599 ] ASF GitHub Bot commented on BOOKKEEPER-1033: Github user reddycharan comm

[GitHub] reddycharan commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

reddycharan commented on issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication URL: https://github.com/apache/bookkeeper/pull/189#issuecomment-312025884 @sijie considering we have come to an understanding regarding the need and purpose of this change, I'm keeping the logic as it is

Re: community meeting?

This is the link to the minutes, feel free to change/modify/correct https://cwiki.apache.org/confluence/display/BOOKKEEPER/2017-06-29+Meeting+notes thank you all! -- Enrico 2017-06-29 17:02 GMT+02:00 Enrico Olivelli : > https://goo.gl/iyRA6G > > 2017-06-29 17:00 GMT+02:00 Enrico Olivelli : >> Y

[GitHub] sijie commented on a change in pull request #205: Issue 208: Improve ledger fence logic

sijie commented on a change in pull request #205: Issue 208: Improve ledger fence logic URL: https://github.com/apache/bookkeeper/pull/205#discussion_r124839179 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/IndexPersistenceMgr.java ## @@ -177,

[GitHub] sijie commented on a change in pull request #205: Issue 208: Improve ledger fence logic

sijie commented on a change in pull request #205: Issue 208: Improve ledger fence logic URL: https://github.com/apache/bookkeeper/pull/205#discussion_r124834567 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.java ## @@ -81,

[GitHub] sijie commented on a change in pull request #205: Issue 208: Improve ledger fence logic

sijie commented on a change in pull request #205: Issue 208: Improve ledger fence logic URL: https://github.com/apache/bookkeeper/pull/205#discussion_r124834954 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.java ## @@ -81,

Re: community meeting?

https://goo.gl/iyRA6G 2017-06-29 17:00 GMT+02:00 Enrico Olivelli : > Yes we are waiting for attendes > > 2017-06-29 16:58 GMT+02:00 Flavio Junqueira : >> Is there a meeting scheduled for today? The page says that the next one is >> on Jun 15. >> >> -Flavio

Re: community meeting?

Yes we are waiting for attendes 2017-06-29 16:58 GMT+02:00 Flavio Junqueira : > Is there a meeting scheduled for today? The page says that the next one is on > Jun 15. > > -Flavio

community meeting?

Is there a meeting scheduled for today? The page says that the next one is on Jun 15. -Flavio

Re: Official Bookkeeper Docker Image

I apologize for the delay answering PR comments, but I have no spare time to devote to this activity in these days. On Wed, 2017-06-21 at 22:51 +0200, Flavio Junqueira wrote: I haven't tested exhaustively, but as a first approximation, it works for me. I was able to get bookies up and running f

Next meeting agenda

Hi, I have just created the page for the meeting of today https://cwiki.apache.org/confluence/display/BOOKKEEPER/2017-06-29+Meeting+notes Feel free to add items -- Enrico

[GitHub] eolivelli commented on issue #217: Code cleanups

eolivelli commented on issue #217: Code cleanups URL: https://github.com/apache/bookkeeper/pull/217#issuecomment-311978968 @sigee I will be happy to have the checkstyle plugin on but we should discuss on the d...@bookeeper.apache.org list about the rules to set up, maybe you can start a ne

[GitHub] bookkeeper issue #217: Code cleanups

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/217 @sigee I will be happy to have the checkstyle plugin on but we should discuss on the d...@bookeeper.apache.org list about the rules to set up, maybe you can start a new thread --- If your pr

[GitHub] sigee commented on issue #217: Code cleanups

sigee commented on issue #217: Code cleanups URL: https://github.com/apache/bookkeeper/pull/217#issuecomment-311975748 @eolivelli, If it is fine for you I can keep this PR up to date after every merge you make (and break this one). So you can merge it when you want. ;) I can ad

[GitHub] jvrao commented on a change in pull request #205: Issue 208: Improve ledger fence logic

jvrao commented on a change in pull request #205: Issue 208: Improve ledger fence logic URL: https://github.com/apache/bookkeeper/pull/205#discussion_r124808898 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.java ## @@ -81,

[GitHub] bookkeeper issue #217: Code cleanups

Github user sigee commented on the issue: https://github.com/apache/bookkeeper/pull/217 @eolivelli, If it is fine for you I can keep this PR up to date after every merge you make (and break this one). So you can merge it when you want. ;) I can add maven checkstyle plu

[GitHub] sigee commented on issue #217: Code cleanups

sigee commented on issue #217: Code cleanups URL: https://github.com/apache/bookkeeper/pull/217#issuecomment-311975748 @eolivelli, If it is fine for you I can keep this PR up to date after every merge you make (and break this one). So you can merge it when you want. ;) I can ad

[GitHub] jvrao commented on a change in pull request #205: Issue 208: Improve ledger fence logic

jvrao commented on a change in pull request #205: Issue 208: Improve ledger fence logic URL: https://github.com/apache/bookkeeper/pull/205#discussion_r124806919 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.java ## @@ -81,

[GitHub] jvrao commented on a change in pull request #205: Issue 208: Improve ledger fence logic

jvrao commented on a change in pull request #205: Issue 208: Improve ledger fence logic URL: https://github.com/apache/bookkeeper/pull/205#discussion_r124806429 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/IndexPersistenceMgr.java ## @@ -177,

[GitHub] eolivelli commented on issue #217: Code cleanups

eolivelli commented on issue #217: Code cleanups URL: https://github.com/apache/bookkeeper/pull/217#issuecomment-311973591 Thank you @sigee interesting proposal. @sijie I think this patch could break some pending Pull Request in general I am OK with this kind of patch but I thi

[GitHub] bookkeeper issue #217: Code cleanups

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/217 Thank you @sigee interesting proposal. @sijie I think this patch could break some pending Pull Request in general I am OK with this kind of patch but I think it would be better

[GitHub] jvrao commented on a change in pull request #205: Issue 208: Improve ledger fence logic

jvrao commented on a change in pull request #205: Issue 208: Improve ledger fence logic URL: https://github.com/apache/bookkeeper/pull/205#discussion_r124805643 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/IndexPersistenceMgr.java ## @@ -177,

[GitHub] bookkeeper pull request #217: Code cleanups

GitHub user sigee opened a pull request: https://github.com/apache/bookkeeper/pull/217 Code cleanups Descriptions of the changes in this PR: There are some different kind of cleanups by commits. To make the code more readeable and improve code quality and improve performanc

[GitHub] sigee opened a new pull request #217: Code cleanups

sigee opened a new pull request #217: Code cleanups URL: https://github.com/apache/bookkeeper/pull/217 Descriptions of the changes in this PR: There are some different kind of cleanups by commits. To make the code more readeable and improve code quality and improve performance in som

Build failed in Jenkins: bookkeeper-master #1800

See -- [...truncated 1.11 MB...] Running org.apache.bookkeeper.client.TestGetBookieInfoTimeout Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.646 sec - in org.apache.

Re: BookKeeper repo has been moved into gitbox

Il gio 29 giu 2017, 12:52 Sijie Guo ha scritto: > Just to clarify - the merge script is effectively squash merge. it does > better job on collecting the pull request descriptions, reviewers' > information to form an better description for the commit. If we are using > 'squash merge' button, we ha

Re: BookKeeper repo has been moved into gitbox

Just to clarify - the merge script is effectively squash merge. it does better job on collecting the pull request descriptions, reviewers' information to form an better description for the commit. If we are using 'squash merge' button, we have to manually copy the description and write the commit m

Re: BookKeeper repo has been moved into gitbox

I don't use squash merge. I am still using the merge-script for merging pull requests. I've already updated the wiki page. You just need to configure 'apache' remote using github repo and you are done. - Sijie On Thu, Jun 29, 2017 at 1:20 AM, Enrico Olivelli wrote: > 2017-06-29 8:54 GMT+02:00 E

[GitHub] bookkeeper issue #206: Issue-196 Create Jenkins configuration using OpenStac...

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/206 @sijie I have tested the script on my companies Jenkins and it is working as expected. Do you want to try out locally ? Actual configuration of the master job is https://builds.

[GitHub] eolivelli commented on issue #206: Issue-196 Create Jenkins configuration using OpenStack Jenkins Job Builder

eolivelli commented on issue #206: Issue-196 Create Jenkins configuration using OpenStack Jenkins Job Builder URL: https://github.com/apache/bookkeeper/pull/206#issuecomment-311897883 @sijie I have tested the script on my companies Jenkins and it is working as expected. Do you want to t

[GitHub] eolivelli commented on a change in pull request #206: Issue-196 Create Jenkins configuration using OpenStack Jenkins Job Builder

eolivelli commented on a change in pull request #206: Issue-196 Create Jenkins configuration using OpenStack Jenkins Job Builder URL: https://github.com/apache/bookkeeper/pull/206#discussion_r124738911 ## File path: jenkins/bookkeeper-master-job-configuration.yaml ## @@ -0

Re: BookKeeper repo has been moved into gitbox

2017-06-29 8:54 GMT+02:00 Enrico Olivelli : > 2017-06-29 4:06 GMT+02:00 Jia Zhai : >> Hi Sijie, >> opened a ticket https://issues.apache.org/jira/browse/INFRA-14470 to only >> "squash merge" >> Thanks >> >> On Thu, Jun 29, 2017 at 5:17 AM, Sijie Guo wrote: >> >>> Hi Enrico, >>> >>> The gitbox is t

[GitHub] bookkeeper issue #212: Change pull request template to adjust both issue# an...

Github user eolivelli closed the issue at: https://github.com/apache/bookkeeper/issues/212 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] bookkeeper pull request #213: Issue 212: change github PR template to adjust...

Github user eolivelli closed the pull request at: https://github.com/apache/bookkeeper/pull/213 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] eolivelli closed pull request #213: Issue 212: change github PR template to adjust both issue# and jira#

eolivelli closed pull request #213: Issue 212: change github PR template to adjust both issue# and jira# URL: https://github.com/apache/bookkeeper/pull/213 This is an automated message from the Apache Git Service. To respon

[GitHub] eolivelli closed issue #212: Change pull request template to adjust both issue# and jira#

eolivelli closed issue #212: Change pull request template to adjust both issue# and jira# URL: https://github.com/apache/bookkeeper/issues/212 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] eolivelli commented on issue #213: Issue 212: change github PR template to adjust both issue# and jira#

eolivelli commented on issue #213: Issue 212: change github PR template to adjust both issue# and jira# URL: https://github.com/apache/bookkeeper/pull/213#issuecomment-311896023 this closes issue #212 This is an automated me

[GitHub] bookkeeper issue #213: Issue 212: change github PR template to adjust both i...

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/213 this closes issue #212 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis